Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

brotli: Add configuration options #12608

Merged
merged 3 commits into from
Aug 30, 2022
Merged

brotli: Add configuration options #12608

merged 3 commits into from
Aug 30, 2022

Conversation

vbieleny
Copy link
Contributor

Specify library name and version: brotli/1.0.9

We'd like to use configuration options in brotli, so I made these options configurable.

  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the conan-center hook activated.

vbieleny and others added 2 commits August 26, 2022 15:18
@vbieleny @SpaceIm
Remove private definitions
d248819 
Co-authored-by: SpaceIm <30052553+SpaceIm@users.noreply.github.com>
@vbieleny @SpaceIm
Fix formatting
7946a98 
Co-authored-by: SpaceIm <30052553+SpaceIm@users.noreply.github.com>
@github-actions github-actions bot mentioned this pull request Aug 26, 2022
Open
@conan-center-bot
Copy link
Collaborator

All green in build 3 (7946a987cc2180f1f052fc6948d612052abfc542):

  • brotli/1.0.9@:
    All packages built successfully! (All logs)

  • brotli/1.0.7@:
    All packages built successfully! (All logs)

SpaceIm
SpaceIm approved these changes Aug 26, 2022
View reviewed changes
Copy link
Contributor

@SpaceIm SpaceIm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@conan-center-bot conan-center-bot merged commit 97bb48f into conan-io:master Aug 30, 2022
@vbieleny vbieleny deleted the feature/brotli_options branch August 30, 2022 04:43
@prince-chrismc prince-chrismc mentioned this pull request Sep 9, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SpaceIm SpaceIm SpaceIm approved these changes

@uilianries uilianries uilianries approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vbieleny @conan-center-bot @uilianries @SpaceIm