-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fmt: conan v2 modernize #12847
fmt: conan v2 modernize #12847
Conversation
Co-authored-by: SpaceIm <30052553+SpaceIm@users.noreply.github.com>
Thank you for the super fast review. I did not play enough with this to see if more could be done any pointers are appreciated! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately GH doesn't allow you to make code suggestions for code that was touched in a PR. So let's post it as a simple i
comment.
I'm missing the test_type in the conanfile of the test_package. Apart from that LGTM
test_type = "explicit"
def requirements(self):
self.requires(self.tested_reference_str)
This comment has been minimized.
This comment has been minimized.
2722e5c
Tha ks for the suggestion. Working on my phone so sorry I did not add you as a co author |
No worries, it was also copy-paste from my side 😉 |
All green in build 6 (
|
@jwillikers Do you use the Cpplang's Slack? I sent you a message just want to make sure you saw it 😄 |
* fmt: conan v2 modernize * Update conanfile.py * Update conanfile.py * Update recipes/fmt/all/conanfile.py Co-authored-by: SpaceIm <30052553+SpaceIm@users.noreply.github.com> * Code review * Code review Co-authored-by: SpaceIm <30052553+SpaceIm@users.noreply.github.com>
…develop * 'master' of github.com:conan-io/conan-center-index: (conan-io#12847) fmt: conan v2 modernize (conan-io#11993) hazelcast-cpp-client: update dependencies and migration to Conan v2
Specify library name and version: lib/1.0
This is also a good place to share with all of us why you are submitting this PR (specially if it is a new addition to ConanCenter): is it a dependency of other libraries you want to package? Are you the author of the library? Thanks!