Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fmt: conan v2 modernize #12847

Merged
merged 6 commits into from
Sep 15, 2022
Merged

Conversation

prince-chrismc
Copy link
Contributor

Specify library name and version: lib/1.0

This is also a good place to share with all of us why you are submitting this PR (specially if it is a new addition to ConanCenter): is it a dependency of other libraries you want to package? Are you the author of the library? Thanks!


  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the conan-center hook activated.

Co-authored-by: SpaceIm <30052553+SpaceIm@users.noreply.github.com>
@prince-chrismc
Copy link
Contributor Author

Thank you for the super fast review. I did not play enough with this to see if more could be done

any pointers are appreciated!

Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job!

jwillikers
jwillikers previously approved these changes Sep 9, 2022
Copy link
Contributor

@jellespijker jellespijker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately GH doesn't allow you to make code suggestions for code that was touched in a PR. So let's post it as a simple i
comment.

I'm missing the test_type in the conanfile of the test_package. Apart from that LGTM

test_type = "explicit"

    def requirements(self):
        self.requires(self.tested_reference_str)

@conan-center-bot

This comment has been minimized.

uilianries
uilianries previously approved these changes Sep 14, 2022
@prince-chrismc
Copy link
Contributor Author

Tha ks for the suggestion. Working on my phone so sorry I did not add you as a co author

@jellespijker
Copy link
Contributor

No worries, it was also copy-paste from my side 😉

@conan-center-bot
Copy link
Collaborator

All green in build 6 (2722e5cb72f64f4defc3434fa2e414fc1091e598):

  • fmt/5.3.0@:
    All packages built successfully! (All logs)

  • fmt/9.1.0@:
    All packages built successfully! (All logs)

  • fmt/8.1.1@:
    All packages built successfully! (All logs)

  • fmt/6.2.1@:
    All packages built successfully! (All logs)

  • fmt/7.1.3@:
    All packages built successfully! (All logs)

  • fmt/8.0.1@:
    All packages built successfully! (All logs)

  • fmt/9.0.0@:
    All packages built successfully! (All logs)

@prince-chrismc
Copy link
Contributor Author

@jwillikers Do you use the Cpplang's Slack? I sent you a message just want to make sure you saw it 😄

@conan-center-bot conan-center-bot merged commit 328bff8 into conan-io:master Sep 15, 2022
ericLemanissier pushed a commit to ericLemanissier/conan-center-index that referenced this pull request Sep 26, 2022
* fmt: conan v2 modernize

* Update conanfile.py

* Update conanfile.py

* Update recipes/fmt/all/conanfile.py

Co-authored-by: SpaceIm <30052553+SpaceIm@users.noreply.github.com>

* Code review

* Code review

Co-authored-by: SpaceIm <30052553+SpaceIm@users.noreply.github.com>
datalogics-robb pushed a commit to datalogics-robb/conan-center-index that referenced this pull request Mar 6, 2023
…develop

* 'master' of github.com:conan-io/conan-center-index:
  (conan-io#12847) fmt: conan v2 modernize
  (conan-io#11993) hazelcast-cpp-client: update dependencies and migration to Conan v2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants