Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

poco: conan v2 support #12868

Merged
merged 6 commits into from
Sep 20, 2022
Merged

Conversation

SpaceIm
Copy link
Contributor

@SpaceIm SpaceIm commented Sep 8, 2022

Specify library name and version: lib/1.0

This is also a good place to share with all of us why you are submitting this PR (specially if it is a new addition to ConanCenter): is it a dependency of other libraries you want to package? Are you the author of the library? Thanks!


  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the conan-center hook activated.

jwillikers
jwillikers previously approved these changes Sep 9, 2022
prince-chrismc
prince-chrismc previously approved these changes Sep 9, 2022
@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

jwillikers
jwillikers previously approved these changes Sep 14, 2022
uilianries
uilianries previously approved these changes Sep 14, 2022
@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot
Copy link
Collaborator

All green in build 6 (8a4558aefd724b7c93705eaf5a40e636a744c45f):

  • poco/1.12.1@:
    All packages built successfully! (All logs)

  • poco/1.11.2@:
    All packages built successfully! (All logs)

  • poco/1.12.0@:
    All packages built successfully! (All logs)

  • poco/1.12.2@:
    All packages built successfully! (All logs)

  • poco/1.11.3@:
    All packages built successfully! (All logs)

  • poco/1.11.0@:
    All packages built successfully! (All logs)

  • poco/1.10.1@:
    All packages built successfully! (All logs)

  • poco/1.10.0@:
    All packages built successfully! (All logs)

  • poco/1.11.1@:
    All packages built successfully! (All logs)

  • poco/1.8.1@:
    All packages built successfully! (All logs)

  • poco/1.9.3@:
    All packages built successfully! (All logs)

  • poco/1.9.4@:
    All packages built successfully! (All logs)

Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@conan-center-bot conan-center-bot merged commit 570a2c3 into conan-io:master Sep 20, 2022
@SpaceIm SpaceIm deleted the poco-conan-v2 branch September 20, 2022 10:07
@db4
Copy link
Contributor

db4 commented Oct 13, 2022

This PR breaks compatibility with opessl/1.1.1n. Is this expected?

@SpaceIm
Copy link
Contributor Author

SpaceIm commented Oct 13, 2022

You can open an issue, but I don't understand what you mean by breaking compatibility with openssl/1.1.1n

@db4
Copy link
Contributor

db4 commented Oct 14, 2022

I don't understand what you mean by breaking compatibility with openssl/1.1.1n

Trying to use poco/1.12.2 with openssl/1.1.1n. Poco build fails:

...
-- Building: Encodings
-- Building: XML
-- Building: JSON
-- Building: Util
-- Building: Net
-- Building: MongoDB
-- Building: Redis
-- Building: JWT
-- Building: Data
-- Building: ActiveRecord
-- Building: Zip
-- Configuring done
CMake Error at JWT/CMakeLists.txt:24 (target_link_libraries):
  Target "JWT" links to:

    Poco::Crypto

  but the target was not found.  Possible reasons include:

    * There is a typo in the target name.
    * A find_package call is missing for an IMPORTED target.
    * An ALIAS target is missing.

poco/1.12.2@#a9ba7f0cfd6d672139d7f0f50f64bce4 works as expected

@SpaceIm
Copy link
Contributor Author

SpaceIm commented Oct 14, 2022

1/ Since #11663, openssl/1.1.1n recipe is not maintained anymore.
2/ This present PR of poco needs this fix in openssl recipe: #12838. But due to 1/, openssl/1.1.1n recipe doesn't have this fix.

@db4
Copy link
Contributor

db4 commented Oct 14, 2022

@SpaceIm thanks for looking into this. No, I don't need a specific version of openssl, upgrading to the latest version is OK

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants