[libffi] conan v2 ready #12904

jellespijker · 2022-09-12T07:52:55Z

Specify library name and version: libffi/x.x.x

This is also a good place to share with all of us why you are submitting this PR (specially if it is a new addition to ConanCenter): is it a dependency of other libraries you want to package? Are you the author of the library? Thanks!

I've read the guidelines for contributing.
I've followed the PEP8 style guides for Python code in the recipes.
I've used the latest Conan client version.
I've tried at least one configuration locally with the conan-center hook activated.

Based on this template: https://github.com/conan-io/conan-center-index/tree/master/docs/package_templates/autotools_package Contribute to CURA-9628

Contributes to CURA-9628

jellespijker · 2022-09-12T08:52:15Z

Depended on #12898 for the: env.define("AR", f"{unix_path(self, self.conf.get('tools.automake:ar-lib'))} lib") statement

Contributes to CURA-9628

jellespijker · 2022-09-12T12:44:06Z

Closing and reopening to trigger CI/CT again, due to an unexpected failure

uilianries · 2022-09-12T15:49:52Z

@jellespijker The CI is more busy than usual due boost and Qt builds. Your PR will take more time to be built. In case an unexpected error occur, the CI will restart your PR automatically. Please, avoid closing/opening for now, because every time you do it, your PR goes to the last position in the build queue. Sorry for the delay

jellespijker · 2022-09-12T15:52:12Z

Thx for lettinge know. I will refrain myself from pushing any random buttons 😉

uilianries · 2022-09-13T06:57:46Z

@jellespijker as extra information, the check continuous-integration/jenkins/pr-merge is what matters. If it's Pending — This commit is being built, means that your PR is running on CI. Other checks (except for GH linters and CLA), they are updated only after jenkins/pr-merge result. It's a bit confusing, because GH caches the last build result and we can't remove it, neither put jenkins/pr-merge on the top.

Should be reverted once conan-io#12898 has been merged Contribute to CURA-9628 and CURA-9575

Contributes to CURA-9628

jellespijker · 2022-09-14T13:38:34Z

Failing on Windows due to conan-io/conan#11980 with a proposed fix for Conan here: conan-io/conan#11981

"C:\J\w\prod\BuildSingleReference@2\.conan\data\libffi\3.2.1\_\_\build\b2b69efcc79a149e0bc765fb12ba0278d52fc260\build-debug\conan\conanbuild.bat" && "C:\J\w\prod\BuildSingleReference@2\.conan\data\libffi\3.2.1\_\_\build\b2b69efcc79a149e0bc765fb12ba0278d52fc260\build-debug\conan\msys2_mode.bat" && C:\J\w\prod\BuildSingleReference@2/s\9dc46d\1\bin\msys64\usr\bin\bash.exe -c ^". \^"C:\J\w\prod\BuildSingleReference@2\.conan\data\libffi\3.2.1\_\_\build\b2b69efcc79a149e0bc765fb12ba0278d52fc260\build-debug\conan\conanbuild.sh\^" ^&^& \^"/c/j/w/prod/buildsinglereference@2/.conan/data/libffi/3.2.1/_/_/build/b2b69efcc79a149e0bc765fb12ba0278d52fc260/libffi/configure\^" --disable-shared --enable-static --prefix=/ --bindir=${prefix}/bin --sbindir=${prefix}/bin --libdir=${prefix}/lib --includedir=${prefix}/include --oldincludedir=${prefix}/include --enable-debug=yes --datarootdir=${prefix}/res --enable-builddir=no --enable-docs=no --build=x86_64-win64-mingw64 --host=x86_64-win64-mingw64 ^"
-----------------
**********************************************************************
** Visual Studio 2019 Developer Command Prompt v16.11.17
** Copyright (c) 2021 Microsoft Corporation
**********************************************************************
[vcvarsall.bat] Environment initialized for: 'x64'
Capturing current environment in C:\J\w\prod\BuildSingleReference@2\.conan\data\libffi\3.2.1\_\_\build\b2b69efcc79a149e0bc765fb12ba0278d52fc260\build-debug\conan\deactivate_msys2_mode.bat
Configuring environment variables
Capturing current environment in C:\J\w\prod\BuildSingleReference@2\.conan\data\libffi\3.2.1\_\_\build\b2b69efcc79a149e0bc765fb12ba0278d52fc260\build-debug\conan\deactivate_conanautotoolstoolchain.sh
Configuring environment variables
Capturing current environment in C:\J\w\prod\BuildSingleReference@2\.conan\data\libffi\3.2.1\_\_\build\b2b69efcc79a149e0bc765fb12ba0278d52fc260\build-debug\conan\deactivate_conanbuildenv-debug-x86_64.sh
Configuring environment variables
checking build system type... x86_64-win64-mingw64
checking host system type... x86_64-win64-mingw64
checking target system type... x86_64-win64-mingw64
checking for gsed... sed
checking for a BSD-compatible install... /c/j/w/prod/buildsinglereference@2/.conan/data/libffi/3.2.1/_/_/build/b2b69efcc79a149e0bc765fb12ba0278d52fc260/libffi/install-sh
checking whether build environment is sane... yes
checking for a thread-safe mkdir -p... /c/j/w/prod/buildsinglereference@2/s/9dc46d/1/bin/msys64/usr/bin/mkdir -p
checking for gawk... gawk
checking whether make sets $(MAKE)... yes
checking whether make supports nested variables... yes
checking for x86_64-win64-mingw64-gcc... /c/j/w/prod/buildsinglereference@2/.conan/data/libffi/3.2.1/_/_/build/b2b69efcc79a149e0bc765fb12ba0278d52fc260/libffi/msvcc.sh -m64
checking whether the C compiler works... no
libffi/3.2.1: 
configure: WARNING: unrecognized options: --enable-docs
configure: error: in `/c/J/w/prod/BuildSingleReference@2/.conan/data/libffi/3.2.1/_/_/build/b2b69efcc79a149e0bc765fb12ba0278d52fc260/build-debug':
configure: error: C compiler cannot create executables
See `config.log' for more details
libffi/3.2.1: WARN: Using the new toolchains and generators without specifying a build profile (e.g: -pr:b=default) is discouraged and might cause failures and unexpected behavior
libffi/3.2.1: ERROR: Package 'b2b69efcc79a149e0bc765fb12ba0278d52fc260' build failed
libffi/3.2.1: WARN: Build folder C:\J\w\prod\BuildSingleReference@2\.conan\data\libffi\3.2.1\_\_\build\b2b69efcc79a149e0bc765fb12ba0278d52fc260\build-debug
ERROR: libffi/3.2.1: Error in build() method, line 170
	autotools.configure()
	ConanException: Error 77 while executing "/c/j/w/prod/buildsinglereference@2/.conan/data/libffi/3.2.1/_/_/build/b2b69efcc79a149e0bc765fb12ba0278d52fc260/libffi/configure" --disable-shared --enable-static --prefix=/ --bindir=${prefix}/bin --sbindir=${prefix}/bin --libdir=${prefix}/lib --includedir=${prefix}/include --oldincludedir=${prefix}/include --enable-debug=yes --datarootdir=${prefix}/res --enable-builddir=no --enable-docs=no --build=x86_64-win64-mingw64 --host=x86_64-win64-mingw64

Notice the: bash.exe -c ^". \^"C:\J\w\prod\BuildSingleReference@2\.conan\data\libffi\3.2.1\_\_\build\b2b69efcc79a149e0bc765fb12ba0278d52fc260\build-debug\conan\conanbuild.sh\^" ^&^& Windows path after the bash command

Contributes to CURA-9628

ghost · 2022-09-20T08:55:18Z

I detected other pull requests that are modifying libffi/all recipe:

libffi: Support Conan V2 #13355

This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there.

conan-center-bot · 2022-09-21T07:48:45Z

Failure in build 8 (d95490c631b09e767d7b2fda604b815b68dc28c5):

libffi/3.4.3@:
CI failed to create some packages (All logs)

Logs for packageID 19729b9559f3ae196cad45cb2b97468ccb75dcd1:

[settings]
arch=x86_64
build_type=Release
compiler=gcc
compiler.libcxx=libstdc++11
compiler.version=10
os=Linux
[options]
libffi:shared=False

[...]
autoconf/2.71: Appending PATH env var with : /home/conan/w/prod/BuildSingleReference/.conan/data/autoconf/2.71/_/_/package/5ab84d6acfe1f23c4fae0ab88f26e3a396351ac9/bin
autoconf/2.71: Setting AC_MACRODIR to /home/conan/w/prod/BuildSingleReference/.conan/data/autoconf/2.71/_/_/package/5ab84d6acfe1f23c4fae0ab88f26e3a396351ac9/bin/share/autoconf
autoconf/2.71: Setting AUTOCONF to /home/conan/w/prod/BuildSingleReference/.conan/data/autoconf/2.71/_/_/package/5ab84d6acfe1f23c4fae0ab88f26e3a396351ac9/bin/autoconf
autoconf/2.71: Setting AUTORECONF to /home/conan/w/prod/BuildSingleReference/.conan/data/autoconf/2.71/_/_/package/5ab84d6acfe1f23c4fae0ab88f26e3a396351ac9/bin/autoreconf
autoconf/2.71: Setting AUTOHEADER to /home/conan/w/prod/BuildSingleReference/.conan/data/autoconf/2.71/_/_/package/5ab84d6acfe1f23c4fae0ab88f26e3a396351ac9/bin/autoheader
autoconf/2.71: Setting AUTOM4TE to /home/conan/w/prod/BuildSingleReference/.conan/data/autoconf/2.71/_/_/package/5ab84d6acfe1f23c4fae0ab88f26e3a396351ac9/bin/autom4te
autoconf/2.71: Setting AUTOM4TE_PERLLIBDIR to /home/conan/w/prod/BuildSingleReference/.conan/data/autoconf/2.71/_/_/package/5ab84d6acfe1f23c4fae0ab88f26e3a396351ac9/bin/share/autoconf
automake/1.16.5: Appending PATH environment variable:: /home/conan/w/prod/BuildSingleReference/.conan/data/automake/1.16.5/_/_/package/258f6f05ca54813b3d7180161753df7f9ccf7e1d/bin
automake/1.16.5: Appending ACLOCAL environment variable with: /home/conan/w/prod/BuildSingleReference/.conan/data/automake/1.16.5/_/_/package/258f6f05ca54813b3d7180161753df7f9ccf7e1d/bin/aclocal
automake/1.16.5: Setting AUTOMAKE_DATADIR to /home/conan/w/prod/BuildSingleReference/.conan/data/automake/1.16.5/_/_/package/258f6f05ca54813b3d7180161753df7f9ccf7e1d/res
automake/1.16.5: Setting AUTOMAKE_LIBDIR to /home/conan/w/prod/BuildSingleReference/.conan/data/automake/1.16.5/_/_/package/258f6f05ca54813b3d7180161753df7f9ccf7e1d/res/automake-1.16
automake/1.16.5: Setting AUTOMAKE_PERLLIBDIR to /home/conan/w/prod/BuildSingleReference/.conan/data/automake/1.16.5/_/_/package/258f6f05ca54813b3d7180161753df7f9ccf7e1d/res/automake-1.16
automake/1.16.5: Setting AUTOMAKE to /home/conan/w/prod/BuildSingleReference/.conan/data/automake/1.16.5/_/_/package/258f6f05ca54813b3d7180161753df7f9ccf7e1d/bin/automake
automake/1.16.5: Append M4 include directories to AUTOMAKE_CONAN_INCLUDES environment variable
libtool/2.4.7: Appending PATH env: /home/conan/w/prod/BuildSingleReference/.conan/data/libtool/2.4.7/_/_/package/ae99c49d13e74caddafc3dc1668af6b86bdf63db/bin
libtool/2.4.7: Setting LIBTOOLIZE env to /home/conan/w/prod/BuildSingleReference/.conan/data/libtool/2.4.7/_/_/package/ae99c49d13e74caddafc3dc1668af6b86bdf63db/bin/libtoolize
libtool/2.4.7: Setting LIBTOOL_PREFIX environment variable to /home/conan/w/prod/BuildSingleReference/.conan/data/libtool/2.4.7/_/_/package/ae99c49d13e74caddafc3dc1668af6b86bdf63db
libtool/2.4.7: Setting LIBTOOL_DATADIR environment variable to /home/conan/w/prod/BuildSingleReference/.conan/data/libtool/2.4.7/_/_/package/ae99c49d13e74caddafc3dc1668af6b86bdf63db/res
libtool/2.4.7: Setting LIBTOOL_PKGAUXDIR environment variable to /home/conan/w/prod/BuildSingleReference/.conan/data/libtool/2.4.7/_/_/package/ae99c49d13e74caddafc3dc1668af6b86bdf63db/res/libtool/build-aux
libtool/2.4.7: Setting LIBTOOL_PKGLTDLDIR environment variable to /home/conan/w/prod/BuildSingleReference/.conan/data/libtool/2.4.7/_/_/package/ae99c49d13e74caddafc3dc1668af6b86bdf63db/res/libtool
libtool/2.4.7: Setting LIBTOOL_ACLOCALDIR environment variable to /home/conan/w/prod/BuildSingleReference/.conan/data/libtool/2.4.7/_/_/package/ae99c49d13e74caddafc3dc1668af6b86bdf63db/res/aclocal
libtool/2.4.7: Appending ACLOCAL_PATH env: /home/conan/w/prod/BuildSingleReference/.conan/data/libtool/2.4.7/_/_/package/ae99c49d13e74caddafc3dc1668af6b86bdf63db/res/aclocal
libtool/2.4.7: Appending AUTOMAKE_CONAN_INCLUDES environment variable: /home/conan/w/prod/BuildSingleReference/.conan/data/libtool/2.4.7/_/_/package/ae99c49d13e74caddafc3dc1668af6b86bdf63db/res/aclocal
libffi/3.4.3: Applying build-requirement: libtool/2.4.7
libffi/3.4.3: Applying build-requirement: automake/1.16.5
libffi/3.4.3: Applying build-requirement: autoconf/2.71
libffi/3.4.3: Applying build-requirement: m4/1.4.19
[HOOK - conan-center.py] pre_source(): [IMMUTABLE SOURCES (KB-H010)] OK
libffi/3.4.3: Configuring sources in /home/conan/w/prod/BuildSingleReference/.conan/data/libffi/3.4.3/_/_/source/libffi
libffi/3.4.3: 
[HOOK - conan-center.py] post_source(): [LIBCXX MANAGEMENT (KB-H011)] OK
[HOOK - conan-center.py] post_source(): [CPPSTD MANAGEMENT (KB-H022)] OK
[HOOK - conan-center.py] post_source(): [SHORT_PATHS USAGE (KB-H066)] OK
libffi/3.4.3: Copying sources to build folder
libffi/3.4.3: Building your package in /home/conan/w/prod/BuildSingleReference/.conan/data/libffi/3.4.3/_/_/build/19729b9559f3ae196cad45cb2b97468ccb75dcd1
libffi/3.4.3: Generator txt created conanbuildinfo.txt
libffi/3.4.3: Calling generate()
libffi/3.4.3: Aggregating env generators
[HOOK - conan-center.py] pre_build(): [FPIC MANAGEMENT (KB-H007)] OK. 'fPIC' option found and apparently well managed
[HOOK - conan-center.py] pre_build(): [FPIC MANAGEMENT (KB-H007)] OK
libffi/3.4.3: Calling build()
libffi/3.4.3: 
libffi/3.4.3: WARN: Using the new toolchains and generators without specifying a build profile (e.g: -pr:b=default) is discouraged and might cause failures and unexpected behavior
libffi/3.4.3: ERROR: Package '19729b9559f3ae196cad45cb2b97468ccb75dcd1' build failed
libffi/3.4.3: WARN: Build folder /home/conan/w/prod/BuildSingleReference/.conan/data/libffi/3.4.3/_/_/build/19729b9559f3ae196cad45cb2b97468ccb75dcd1/build-release
ERROR: libffi/3.4.3: Error in build() method, line 167
	self._patch_source()
while calling '_patch_source', line 153
	apply_conandata_patches(self)
	FileNotFoundError: [Errno 2] No such file or directory: '/home/conan/w/prod/BuildSingleReference/.conan/data/libffi/3.4.3/_/_/build/19729b9559f3ae196cad45cb2b97468ccb75dcd1/libffi/source_subfolder'

libffi/3.2.1@:
Didn't run or was cancelled before finishing
libffi/3.4.2@:
Didn't run or was cancelled before finishing
libffi/3.3@:
Didn't run or was cancelled before finishing

^{Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.}

planetmarshall · 2022-10-07T14:31:14Z

recipes/libffi/all/conandata.yml

@@ -22,33 +22,19 @@ patches:
    - base_path: "source_subfolder"


Remove this.

prince-chrismc · 2022-10-31T18:31:53Z

#13355 is merged so I will close this :)

Great work

jellespijker and others added 7 commits September 10, 2022 08:49

Added Conan v2 support

95d6167

Based on this template: https://github.com/conan-io/conan-center-index/tree/master/docs/package_templates/autotools_package Contribute to CURA-9628

catch ValueError instead of broad Exception catch

4dbe053

Contributes to CURA-9628

Validating not needed in this recipe

496845c

Contributes to CURA-9628

Clean-up various path references

bff26d3

Contributes to CURA-9628

Merge branch 'conan-io:master' into CURA-9628-libffi_conan_v2_ready

3edbb9e

Use modern apple rpath fix

a496788

Contributes to CURA-9628

Reapplied patches again

8949aba

Contributes to CURA-9628

This was referenced Sep 12, 2022

Conan 2.0 Migration Effort #12888

Closed

[libffi] Added Conan v2 support Ultimaker/conan-center-index#8

Open

github-actions bot mentioned this pull request Sep 12, 2022

Pull Requests Ready to be Reviewed prince-chrismc/conan-center-index-pending-review#1

Open

This comment has been minimized.

Sign in to view

conan-center-bot added the Failed label Sep 12, 2022

convert Path to str before passing to unix_path

a3ddea9

Contributes to CURA-9628

conan-center-bot removed the Failed label Sep 12, 2022

This comment has been minimized.

Sign in to view

conan-center-bot added the Failed label Sep 12, 2022

Removed clang exception in generate

601b6e0

Contributes to CURA-9628

conan-center-bot removed the Failed label Sep 12, 2022

This comment has been minimized.

Sign in to view

conan-center-bot added Failed Unexpected Error labels Sep 12, 2022

jellespijker closed this Sep 12, 2022

jellespijker reopened this Sep 12, 2022

conan-center-bot removed Unexpected Error Failed labels Sep 12, 2022

jellespijker closed this Sep 12, 2022

jellespijker reopened this Sep 12, 2022

This comment has been minimized.

Sign in to view

conan-center-bot added the Failed label Sep 14, 2022

Use user_info.ar_lib as a workaround

c42f0ed

Should be reverted once conan-io#12898 has been merged Contribute to CURA-9628 and CURA-9575

conan-center-bot removed the Failed label Sep 14, 2022

disable multi os directory when compiling with apple-clang

4dfc960

Contributes to CURA-9628

This comment has been minimized.

Sign in to view

conan-center-bot added the Failed label Sep 14, 2022

Use conf for AR variable

d95490c

Contributes to CURA-9628

conan-center-bot removed the Failed label Sep 17, 2022

This comment has been minimized.

Sign in to view

conan-center-bot added the Failed label Sep 17, 2022

This was referenced Sep 20, 2022

[service] Potentially conflicting recipes #3571

Closed

libffi 3.4.3 #13026

Merged

Merge branch 'conan-io:master' into CURA-9628-libffi_conan_v2_ready

4c81e7e

conan-center-bot removed the Failed label Sep 21, 2022

conan-center-bot added the Failed label Sep 21, 2022

planetmarshall reviewed Oct 7, 2022

View reviewed changes

jwillikers mentioned this pull request Oct 7, 2022

libffi: Support Conan V2 #13355

Merged

4 tasks

prince-chrismc closed this Oct 31, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[libffi] conan v2 ready #12904

[libffi] conan v2 ready #12904

jellespijker commented Sep 12, 2022

This comment has been minimized.

jellespijker commented Sep 12, 2022

This comment has been minimized.

This comment has been minimized.

jellespijker commented Sep 12, 2022

uilianries commented Sep 12, 2022

jellespijker commented Sep 12, 2022

uilianries commented Sep 13, 2022

This comment has been minimized.

This comment has been minimized.

jellespijker commented Sep 14, 2022

This comment has been minimized.

ghost commented Sep 20, 2022 •

edited by ghost

Loading

conan-center-bot commented Sep 21, 2022

planetmarshall Oct 7, 2022

prince-chrismc commented Oct 31, 2022

[libffi] conan v2 ready #12904

[libffi] conan v2 ready #12904

Conversation

jellespijker commented Sep 12, 2022

This comment has been minimized.

jellespijker commented Sep 12, 2022

This comment has been minimized.

This comment has been minimized.

jellespijker commented Sep 12, 2022

uilianries commented Sep 12, 2022

jellespijker commented Sep 12, 2022

uilianries commented Sep 13, 2022

This comment has been minimized.

This comment has been minimized.

jellespijker commented Sep 14, 2022

This comment has been minimized.

ghost commented Sep 20, 2022 • edited by ghost Loading

conan-center-bot commented Sep 21, 2022

planetmarshall Oct 7, 2022

Choose a reason for hiding this comment

prince-chrismc commented Oct 31, 2022

ghost commented Sep 20, 2022 •

edited by ghost

Loading