Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cctag: conan v2 support #13402

Merged
merged 8 commits into from
Jan 23, 2023
Merged

Conversation

SpaceIm
Copy link
Contributor

@SpaceIm SpaceIm commented Oct 10, 2022

Specify library name and version: lib/1.0

This is also a good place to share with all of us why you are submitting this PR (specially if it is a new addition to ConanCenter): is it a dependency of other libraries you want to package? Are you the author of the library? Thanks!


  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the conan-center hook activated.

jwillikers
jwillikers previously approved these changes Oct 10, 2022
@conan-center-bot

This comment has been minimized.

@SpaceIm
Copy link
Contributor Author

SpaceIm commented Oct 12, 2022

waiting for #13406 (which is also waiting for #13285).

@stale
Copy link

stale bot commented Nov 12, 2022

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Nov 12, 2022
@SpaceIm SpaceIm closed this Nov 20, 2022
@SpaceIm
Copy link
Contributor Author

SpaceIm commented Nov 20, 2022

don't close, still waiting for fix of conflicts in opencv dependency graph

@SpaceIm SpaceIm reopened this Nov 20, 2022
@stale stale bot removed stale labels Nov 20, 2022
@conan-center-bot

This comment has been minimized.

@stale
Copy link

stale bot commented Dec 20, 2022

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Dec 20, 2022
jwillikers
jwillikers previously approved these changes Jan 7, 2023
@conan-center-bot

This comment has been minimized.

@SpaceIm
Copy link
Contributor Author

SpaceIm commented Jan 9, 2023

CMakeFiles/CCTag.dir/cctag/utils/FileDebug.cpp.o:(.bss+0x4): multiple definition of `boost::phoenix::placeholders::uarg8'
CMakeFiles/CCTag.dir/cctag/Bresenham.cpp.o:(.bss+0x4): first defined here

I'll revert to boost 1.80.0 due to a bug in boost phoenix 1.81.0: boostorg/phoenix#111

waiting bugfix in boost phoenix 1.81.0, otherwise it breaks cctag shared libs build due to duplicated definitions (see boostorg/phoenix#111).
@conan-center-bot

This comment has been minimized.

@SpaceIm
Copy link
Contributor Author

SpaceIm commented Jan 9, 2023

ERROR: Missing binary: onetbb/2020.3:f42ebec2d0ee7d5c41713cd8eee15cf988b0d202
onetbb/2020.3: WARN: Can't find a 'onetbb/2020.3' package for the specified settings, options and dependencies:
- Settings: arch=x86_64, build_type=Release, compiler=Visual Studio, compiler.runtime=MT, compiler.version=15, os=Windows
- Options: shared=True, tbbmalloc=False, tbbproxy=False
- Dependencies: 
- Requirements: 
- Package ID: f42ebec2d0ee7d5c41713cd8eee15cf988b0d202

ERROR: Missing prebuilt package for 'onetbb/2020.3'
Use 'conan search onetbb/2020.3@ --table=table.html -r=remote' and open the table.html file to see available packages
Or try to build locally from sources with '--build=onetbb'

what?

@uilianries @danimtb could you have a look to this issue? It seems there are missing Windows shared MT packages of onetbb 2020.3 in conan-center.

EDIT: ok I understand. c3i doesn't build anymore shared MT. But onetbb is shared by default. So c3i tries to build cctag static with MT runtime, but can't find this shared MT package of onetbb.

jwillikers
jwillikers previously approved these changes Jan 9, 2023
@uilianries
Copy link
Member

@SpaceIm I would skip shared=True + MT with ConanInvalidConfiguration, as we can't skip it internally. We don't have black/white lists in C3I jenkins to skip packages. In case it's really needed, I could say people will open an issue asking for.

… to mising pre-built binary of onetbb shared with static runtime
@conan-center-bot

This comment has been minimized.

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 8 (cfe3d979d6a66483da5bad88aa5e90f6fc3da388):

  • cctag/1.0.1@:
    All packages built successfully! (All logs)

@conan-center-bot conan-center-bot merged commit 1054c71 into conan-io:master Jan 23, 2023
@SpaceIm SpaceIm deleted the cctag-conan-v2 branch January 23, 2023 22:48
StellaSmith pushed a commit to StellaSmith/conan-center-index that referenced this pull request Feb 2, 2023
* conan v2 support

* bump boost

* modernize more

* add patch fields

* back to boost 1.80.0

waiting bugfix in boost phoenix 1.81.0, otherwise it breaks cctag shared libs build due to duplicated definitions (see boostorg/phoenix#111).

* bump boost

* raise for the specific configuration which cannot be built in c3i due to mising pre-built binary of onetbb shared with static runtime

* back to boost 1.80.0 again
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants