cyrus-sasl: conan v2 support #13458
Merged
cyrus-sasl: conan v2 support #13458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
SpaceIm
force-pushed
the
cyrus-sasl-conan-v2
branch
from
834aaed to
f95053a
Compare
This comment has been minimized.
This comment has been minimized.
|
this PR needs a fix of openssl recipe due to conan-io/conan#12106 |
4 tasks
jwillikers
approved these changes
Oct 13, 2022
This comment has been minimized.
This comment has been minimized.
| autotools.configure(configure_dir=self._source_subfolder, args=args) | ||
| return autotools | ||
| def _patch_sources(self): | ||
| shutil.copy(self._user_info_build["gnu-config"].CONFIG_SUB, |
There was a problem hiding this comment.
can the new copy now be used here?
There was a problem hiding this comment.
Didn't you already ask in another PR? The answer is no.
There was a problem hiding this comment.
Yeah sorry but I'll probably ask again 😅 since it looks out of place and in a few hundred PR reviews I'll forget
|
All green in build 4 (
|
prince-chrismc
approved these changes
Oct 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specify library name and version: lib/1.0
This is also a good place to share with all of us why you are submitting this PR (specially if it is a new addition to ConanCenter): is it a dependency of other libraries you want to package? Are you the author of the library? Thanks!