nasm - upgrade to conan v2, based on prior work done by @czoido

[paulharris]

nasm wouldn't build for me as I'm using the "msvc" compiler, not the "Visual Studio" compiler.
So I thought I'd upgrade to conan v2 at the same time, based on the work found here:
https://github.com/czoido/conan-center-index/blob/master/recipes/nasm/all/conanfile.py
mentioned here: conan-io/conan#11751

---

• I've read the guidelines for contributing.
• I've followed the PEP8 style guides for Python code in the recipes.
• I've used the latest Conan client version.
• I've tried at least one configuration locally with the conan-center hook activated.

[paulharris]

Note: rolled back to #13485 (comment)
I have no idea re this error:

Configuring environment variables
nasm/2.15.05: 
configure.ac:1: error: possibly undefined macro: dnl
      If this token and others are legitimate, please use m4_pattern_allow.
      See the Autoconf documentation.
configure.ac:62: error: possibly undefined macro: AC_DEFINE
configure.ac:107: error: possibly undefined macro: AC_CHECK_PROGS
autoreconf: /usr/bin/autoconf failed with exit status: 1
nasm/2.15.05: WARN: Using the new toolchains and generators without specifying a build profile (e.g: -pr:b=default) is discouraged and might cause failures and unexpected behavior
nasm/2.15.05: ERROR: Package '24647d9fe8ec489125dfbae4b3ebefaf7581674c' build failed
nasm/2.15.05: WARN: Build folder /home/conan/w/prod/BuildSingleReference/.conan/data/nasm/2.15.05/_/_/build/24647d9fe8ec489125dfbae4b3ebefaf7581674c/build-release
ERROR: nasm/2.15.05: Error in build() method, line 96
	autotools.autoreconf()
	ConanException: Error 1 while executing autoreconf '--force' '--install'

[paulharris]

I'm not sure what to do about the errors in the build... help please?

[paulharris]

Help please, I don't understand why this failed... looks like python failed to substitute asm_file variable contents into f"etcetc {asm_file}" ... ?

[paulharris]

@czoido how does this look now?

[prince-chrismc]

Questions and some cleanup :)

[prince-chrismc]

this issue is closed, is this code still required?

[paulharris]

I'm not sure, it is hard for me to comment on or test as I don't cross-compile locally.
Also, I see there are a bunch of PRs open on AutoTools so I didn't want to test anything related to AutoTools specifically as whatever problems I hit may already be in the pipeline...

[prince-chrismc]

Maybe https://docs.conan.io/en/latest/reference/conanfile/tools/files/basic.html?highlight=get#conan-tools-files-rename

Or the tools copy helper... since it's more robust

[paulharris]

Yes well I don't understand how I'd do this with conan.tools.files.copy(),
I'd have to copy to a temporary folder and then rename into the right place, and then delete the temp folder?
Seems crazy?

I think we should:

• leave it there, with a FIXME or something
• add a conan.tools.files.copy_file() to 1.54
• add a linter check for shutil.copy() and shutil.copy2()

[prince-chrismc]

That does sound crazy 🤪 lol sorry I didn't realize it was not available 😅

[conan-center-bot]

All green in build 18 (0bd8f0d4523d2dc63d2dd1bc4b916204ca599578):

• nasm/2.15.05@:
  All packages built successfully! (All logs)

• nasm/2.13.01@:
  All packages built successfully! (All logs)

• nasm/2.14@:
  All packages built successfully! (All logs)

• nasm/2.13.02@:
  All packages built successfully! (All logs)