-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gstreamer: Add version 1.20 #13537
gstreamer: Add version 1.20 #13537
Conversation
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
I detected other pull requests that are modifying gstreamer/all recipe: This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there. |
This comment has been minimized.
This comment has been minimized.
4 similar comments
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
2 similar comments
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
2 similar comments
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Why is it not auto merged by bot since it's a version bump? |
This comment has been minimized.
This comment has been minimized.
Conan v1 pipeline ✔️All green in build 39 (
Conan v2 pipeline ✔️
All green in build 38 ( |
@@ -1,4 +1,10 @@ | |||
sources: | |||
"1.22.3": | |||
url: "https://gstreamer.freedesktop.org/src/gstreamer/gstreamer-1.22.3.tar.xz" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am fine with changing the URL to the gstreamer. instead of gitlab, because the later is non-navigable, but the former is.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GitLab/GitHub auto-generated archives cannot be trusted.
@@ -1,4 +1,10 @@ | |||
sources: | |||
"1.22.3": | |||
url: "https://gstreamer.freedesktop.org/src/gstreamer/gstreamer-1.22.3.tar.xz" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
url: "https://gstreamer.freedesktop.org/src/gstreamer/gstreamer-1.22.3.tar.xz" | |
url: "https://gitlab.freedesktop.org/gstreamer/gstreamer/-/archive/1.22.3/gstreamer-1.22.3.tar.gz" |
@uilianries suggest that they have had issues with the downloads from gstreamer.freedesktop, and gitlab downloads have been more reliable
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GitLab isn't reliable, as well as GitHub. they auto-generate these archives with git archive command. and sometimes they can upgrade git version, or change git config
, after that sha256 no longer matches previously generated archive. it's annoying, but it already happened in the past multiple times.
see Git archive checksums may change and Content of all release source code asset tarballs has changed.
we know these URLs were problematic in the past, therefore they can be no longer trusted.
url: "https://gstreamer.freedesktop.org/src/gstreamer/gstreamer-1.22.3.tar.xz" | ||
sha256: "9ffeab95053f9f6995eb3b3da225e88f21c129cd60da002d3f795db70d6d5974" | ||
"1.20.6": | ||
url: "https://gstreamer.freedesktop.org/src/gstreamer/gstreamer-1.20.6.tar.xz" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
url: "https://gstreamer.freedesktop.org/src/gstreamer/gstreamer-1.20.6.tar.xz" | |
url: "https://gitlab.freedesktop.org/gstreamer/gstreamer/-/archive/1.20.6/gstreamer-1.20.6.tar.gz" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GitLab/GitHub auto-generated archives cannot be trusted.
* gstreamer: (conan-io#13534) Add 1.20 version * gstreamer: (conan-io#13534) Add 1.22 version
* gstreamer: (conan-io#13534) Add 1.20 version * gstreamer: (conan-io#13534) Add 1.22 version
* gstreamer: (conan-io#13534) Add 1.20 version * gstreamer: (conan-io#13534) Add 1.22 version
Specify library name and version: gstreamer/1.20.4
The current recipe only contains the old 1.19 version of GStreamer, IMHO an update to the 1.20 is needed