Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gstreamer: Add version 1.20 #13537

Merged
merged 2 commits into from
May 27, 2023
Merged

gstreamer: Add version 1.20 #13537

merged 2 commits into from
May 27, 2023

Conversation

mjimenofluendo
Copy link
Contributor

@mjimenofluendo mjimenofluendo commented Oct 17, 2022

Specify library name and version: gstreamer/1.20.4

The current recipe only contains the old 1.19 version of GStreamer, IMHO an update to the 1.20 is needed


  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the conan-center hook activated.

@CLAassistant
Copy link

CLAassistant commented Oct 17, 2022

CLA assistant check
All committers have signed the CLA.

@conan-center-bot

This comment has been minimized.

1 similar comment
@conan-center-bot

This comment has been minimized.

@mjimenofluendo mjimenofluendo changed the title (#13534) Bump GStreamer to 1.20.4 gstreamer: Bump to 1.20.4 Oct 17, 2022
@ghost
Copy link

ghost commented Oct 17, 2022

I detected other pull requests that are modifying gstreamer/all recipe:

This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there.

@ghost ghost mentioned this pull request Oct 17, 2022
4 tasks
@conan-center-bot

This comment has been minimized.

4 similar comments
@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@mjimenofluendo mjimenofluendo mentioned this pull request Oct 17, 2022
@conan-center-bot

This comment has been minimized.

2 similar comments
@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

recipes/gstreamer/all/conandata.yml Outdated Show resolved Hide resolved
recipes/gstreamer/all/conanfile.py Outdated Show resolved Hide resolved
recipes/gstreamer/all/conanfile.py Outdated Show resolved Hide resolved
recipes/gstreamer/all/conanfile.py Outdated Show resolved Hide resolved
@conan-center-bot

This comment has been minimized.

2 similar comments
@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@stale
Copy link

stale bot commented Nov 25, 2022

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@stale
Copy link

stale bot commented May 1, 2023

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label May 1, 2023
@stale stale bot removed the stale label May 18, 2023
@conan-center-bot

This comment has been minimized.

@mjimenofluendo mjimenofluendo changed the title gstreamer: Add version 1.20.4 and adapt to Conan 2.0 gstreamer: Add version 1.20 May 24, 2023
@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@SpaceIm
Copy link
Contributor

SpaceIm commented May 24, 2023

Why is it not auto merged by bot since it's a version bump?

@conan-center-bot

This comment has been minimized.

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 39 (2bb0b516a27b7de3fa688dfaece487b80ee38826):

  • gstreamer/1.20.6@:
    All packages built successfully! (All logs)

  • gstreamer/1.22.3@:
    All packages built successfully! (All logs)


Conan v2 pipeline ✔️

Note: Conan v2 builds may be required once they are on the v2 ready list

All green in build 38 (2bb0b516a27b7de3fa688dfaece487b80ee38826):

  • gstreamer/1.22.3@:
    All packages built successfully! (All logs)

  • gstreamer/1.20.6@:
    All packages built successfully! (All logs)

@@ -1,4 +1,10 @@
sources:
"1.22.3":
url: "https://gstreamer.freedesktop.org/src/gstreamer/gstreamer-1.22.3.tar.xz"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am fine with changing the URL to the gstreamer. instead of gitlab, because the later is non-navigable, but the former is.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GitLab/GitHub auto-generated archives cannot be trusted.

@@ -1,4 +1,10 @@
sources:
"1.22.3":
url: "https://gstreamer.freedesktop.org/src/gstreamer/gstreamer-1.22.3.tar.xz"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
url: "https://gstreamer.freedesktop.org/src/gstreamer/gstreamer-1.22.3.tar.xz"
url: "https://gitlab.freedesktop.org/gstreamer/gstreamer/-/archive/1.22.3/gstreamer-1.22.3.tar.gz"

@uilianries suggest that they have had issues with the downloads from gstreamer.freedesktop, and gitlab downloads have been more reliable

Copy link
Contributor

@SSE4 SSE4 May 27, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GitLab isn't reliable, as well as GitHub. they auto-generate these archives with git archive command. and sometimes they can upgrade git version, or change git config, after that sha256 no longer matches previously generated archive. it's annoying, but it already happened in the past multiple times.
see Git archive checksums may change and Content of all release source code asset tarballs has changed.
we know these URLs were problematic in the past, therefore they can be no longer trusted.

url: "https://gstreamer.freedesktop.org/src/gstreamer/gstreamer-1.22.3.tar.xz"
sha256: "9ffeab95053f9f6995eb3b3da225e88f21c129cd60da002d3f795db70d6d5974"
"1.20.6":
url: "https://gstreamer.freedesktop.org/src/gstreamer/gstreamer-1.20.6.tar.xz"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
url: "https://gstreamer.freedesktop.org/src/gstreamer/gstreamer-1.20.6.tar.xz"
url: "https://gitlab.freedesktop.org/gstreamer/gstreamer/-/archive/1.20.6/gstreamer-1.20.6.tar.gz"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GitLab/GitHub auto-generated archives cannot be trusted.

@conan-center-bot conan-center-bot merged commit 7e6d6f5 into conan-io:master May 27, 2023
@mjimenofluendo mjimenofluendo deleted the bump_to_1.20.4 branch May 29, 2023 06:27
mlutken pushed a commit to mlutken/conan-center-index that referenced this pull request May 31, 2023
* gstreamer: (conan-io#13534) Add 1.20 version

* gstreamer: (conan-io#13534) Add 1.22 version
pezy pushed a commit to pezy/conan-center-index that referenced this pull request Jun 1, 2023
* gstreamer: (conan-io#13534) Add 1.20 version

* gstreamer: (conan-io#13534) Add 1.22 version
samuel-emrys pushed a commit to samuel-emrys/conan-center-index that referenced this pull request Jun 3, 2023
* gstreamer: (conan-io#13534) Add 1.20 version

* gstreamer: (conan-io#13534) Add 1.22 version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants