Add libmicrohttpd/0.9.75 recipe #13564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
uilianries
reviewed
Oct 18, 2022
| default_options = { | ||
| "shared": False, | ||
| "fPIC": True, | ||
| "with_https": False, # FIXME: should be True, but gnutls is not yet available in cci |
There was a problem hiding this comment.
I started a PR for GNU TlS, need to resume it.
There was a problem hiding this comment.
I stopped when I failed to get it building for MSVC x years ago.
Would be nice if you get it working.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
madebr
force-pushed
the
add-libmicrohttpd-recipe
branch
from
f1563cd to
95f281e
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
jwillikers
suggested changes
Oct 19, 2022
| name = "libmicrohttpd" | ||
| description = "A small C library that is supposed to make it easy to run an HTTP server" | ||
| homepage = "https://www.gnu.org/software/libmicrohttpd/" | ||
| topics = ("libmicrohttpd", "httpd", "server", "service") |
There was a problem hiding this comment.
The package name doesn't need to be in topics.
Suggested change
| topics = ("libmicrohttpd", "httpd", "server", "service") | |
| topics = ("httpd", "server", "service") |
Comment on lines
83
to
84
| if self._settings_build.os == "Windows" and not is_msvc(self) and not self.conf.get("tools.microsoft.bash:path", default=False, check_type=str): | ||
| self.build_requires("msys2/cci.latest") |
There was a problem hiding this comment.
I think self.win_bash should be set to True here.
Suggested change
| if self._settings_build.os == "Windows" and not is_msvc(self) and not self.conf.get("tools.microsoft.bash:path", default=False, check_type=str): | |
| self.build_requires("msys2/cci.latest") | |
| if self._settings_build.os == "Windows" and not is_msvc(self) : | |
| self.win_bash = True | |
| if not self.conf.get("tools.microsoft.bash:path", default=False, check_type=str): | |
| self.tool_requires("msys2/cci.latest") |
| @functools.lru_cache(1) | ||
| def _configure_autotools(self): | ||
| yes_no = lambda v: "yes" if v else "no" | ||
| autotools = AutoToolsBuildEnvironment(self, win_bash=self._settings_build.os == "Windows") |
There was a problem hiding this comment.
Is it possible to use AutotoolsToolchain?
There was a problem hiding this comment.
Yes, but I got bitten by 2 bugs: conan-io/conan#12193 and conan-io/conan#12338
| "epoll": True, | ||
| "with_zlib": True, | ||
| } | ||
| generators = "pkg_config" |
There was a problem hiding this comment.
PkgConfigDeps + generate() method?
This was referenced Oct 19, 2022
This comment has been minimized.
This comment has been minimized.
uilianries
reviewed
Oct 19, 2022
madebr
commented
Oct 19, 2022
Co-authored-by: Uilian Ries <uilianries@gmail.com> Co-authored-by: Jordan Williams <jordan@jwillikers.com>
This comment has been minimized.
This comment has been minimized.
|
All green in build 13 (
|
uilianries
approved these changes
Oct 20, 2022
jwillikers
approved these changes
Oct 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specify library name and version: libmicrohttpd/0.9.75
Tested with MSVC2019 + MinGW@Windows