Update mold to 1.7.1 #13666

ericriff · 2022-10-21T13:38:20Z

No description provided.

…in one

ericriff · 2022-10-21T14:03:54Z

It looks like the hooks are broken. I'm raising from validate_build not from build

ericriff · 2022-10-21T16:16:06Z

And there is another issue. The install stage is silently failing here: https://github.com/rui314/mold/blob/c4850273c79548b6bc46a094b0119c27434dfaa7/CMakeLists.txt#L368-L369

This is because the conan-generated toolchain sets set(CMAKE_INSTALL_LIBEXECDIR "bin") instead of libexec, which I believe is the default. So Cmake tries to create a folder that already exists and fails, so some of the files do not get installed. This fundamentally breaks the usage of this linker for GCC older than 12, since in those cases you need to pass the path to libexec/mold using the -Bpath thing. See https://github.com/rui314/mold/blob/main/README.md#how-to-use for reference.
What should we do here?
This is how the conan package looks like

tree /home/eriff/.conan/data/mold/1.6.0/eriff/test/package/bfd8a9f3504587959491e9a5d7d3de4654e50db6/
/home/eriff/.conan/data/mold/1.6.0/eriff/test/package/bfd8a9f3504587959491e9a5d7d3de4654e50db6/
├── bin
│   ├── ld64.mold -> mold
│   ├── ld.mold -> mold
│   └── mold
├── conaninfo.txt
├── conanmanifest.txt
├── lib
│   └── mold
│       └── mold-wrapper.so
└── licenses
    └── LICENSE

Where as a conan-less build (is that a word?) produces this

├── bin
│   ├── ld64.mold -> mold
│   ├── ld.mold -> mold
│   └── mold
├── conaninfo.txt
├── conanmanifest.txt
├── lib
│   └── mold
│       └── mold-wrapper.so
└── libexec
    └── mold
        └── ld -> ../../bin/mold

Is it OK if I recreate libexec/mold/ld on the package step? Should I patch the CMakelists to avoid creating those folders and store the ld symlink in bin? I don't think that's the best approach.

For reference, this is what the error looks like

mold/1.6.0@eriff/test: Calling package()
mold/1.6.0@eriff/test: CMake command: cmake --install "/home/eriff/.conan/data/mold/1.6.0/eriff/test/build/bfd8a9f3504587959491e9a5d7d3de4654e50db6/build/Release" --prefix "/home/eriff/.conan/data/mold/1.6.0/eriff/test/package/bfd8a9f3504587959491e9a5d7d3de4654e50db6"
Capturing current environment in /home/eriff/.conan/data/mold/1.6.0/eriff/test/build/bfd8a9f3504587959491e9a5d7d3de4654e50db6/build/generators/deactivate_conanbuildenv-release-x86_64.sh
Configuring environment variables
-- Install configuration: "Release"
-- Installing: /home/eriff/.conan/data/mold/1.6.0/eriff/test/package/bfd8a9f3504587959491e9a5d7d3de4654e50db6/lib/mold/mold-wrapper.so
-- Installing: /home/eriff/.conan/data/mold/1.6.0/eriff/test/package/bfd8a9f3504587959491e9a5d7d3de4654e50db6/bin/mold
-- Set runtime path of "/home/eriff/.conan/data/mold/1.6.0/eriff/test/package/bfd8a9f3504587959491e9a5d7d3de4654e50db6/bin/mold" to ""
-- Installing: /home/eriff/.conan/data/mold/1.6.0/eriff/test/package/bfd8a9f3504587959491e9a5d7d3de4654e50db6/share/doc/mold/LICENSE
-- Installing: /home/eriff/.conan/data/mold/1.6.0/eriff/test/package/bfd8a9f3504587959491e9a5d7d3de4654e50db6/share/man/man1/mold.1
Error creating directory "//home/eriff/.conan/data/mold/1.6.0/eriff/test/package/bfd8a9f3504587959491e9a5d7d3de4654e50db6/bin/mold".
CMake Error: cmake version 3.24.1
Usage: /home/eriff/.local/lib/python3.8/site-packages/cmake/data/bin/cmake -E <command> [arguments...]
Available commands: 
  capabilities              - Report capabilities built into cmake in JSON format
  cat [--] <files>...       - concat the files and print them to the standard output
  chdir dir cmd [args...]   - run command in a given directory
  compare_files [--ignore-eol] file1 file2
                              - check if file1 is same as file2
  copy <file>... destination  - copy files to destination (either file or directory)
  copy_directory <dir>... destination   - copy content of <dir>... directories to 'destination' directory
  copy_if_different <file>... destination  - copy files if it has changed
  echo [<string>...]        - displays arguments as text
  echo_append [<string>...] - displays arguments as text but no new line
  env [--unset=NAME ...] [NAME=VALUE ...] [--] <command> [<arg>...]
                            - run command in a modified environment
  environment               - display the current environment
  make_directory <dir>...   - create parent and <dir> directories
  md5sum <file>...          - create MD5 checksum of files
  sha1sum <file>...         - create SHA1 checksum of files
  sha224sum <file>...       - create SHA224 checksum of files
  sha256sum <file>...       - create SHA256 checksum of files
  sha384sum <file>...       - create SHA384 checksum of files
  sha512sum <file>...       - create SHA512 checksum of files
  remove [-f] <file>...     - remove the file(s), use -f to force it (deprecated: use rm instead)
  remove_directory <dir>... - remove directories and their contents (deprecated: use rm instead)
  rename oldname newname    - rename a file or directory (on one volume)
  rm [-rRf] [--] <file/dir>... - remove files or directories, use -f to force it, r or R to remove directories and their contents recursively
  sleep <number>...         - sleep for given number of seconds
  tar [cxt][vf][zjJ] file.tar [file/dir1 file/dir2 ...]
                            - create or extract a tar or zip archive
  time command [args...]    - run command and display elapsed time
  touch <file>...           - touch a <file>.
  touch_nocreate <file>...  - touch a <file> but do not create it.
  create_symlink old new    - create a symbolic link new -> old
  create_hardlink old new   - create a hard link new -> old
  true                      - do nothing with an exit code of 0
  false                     - do nothing with an exit code of 1

mold/1.6.0@eriff/test: Copied 1 file: LICENSE
mold/1.6.0@eriff/test package(): Packaged 2 files: LICENSE, mold
mold/1.6.0@eriff/test package(): Packaged 1 '.so' file: mold-wrapper.so
mold/1.6.0@eriff/test package(): Packaged 2 '.mold' files: ld.mold, ld64.mold
mold/1.6.0@eriff/test: Package 'bfd8a9f3504587959491e9a5d7d3de4654e50db6' created
mold/1.6.0@eriff/test: Created package revision 6498ac069fe971f32620cc81a672eb5d
mold/1.6.0@eriff/test: Appending PATH environment variable: /home/eriff/.conan/data/mold/1.6.0/eriff/test/package/bfd8a9f3504587959491e9a5d7d3de4654e50db6/bin

ericriff · 2022-10-25T21:48:12Z

@uilianries maybe you have some input?

uilianries · 2022-10-26T13:38:29Z

It looks like the hooks are broken. I'm raising from validate_build not from build

Yes. Not first PR with same problem. We have a half PR ready to fix it, but it will require a new CI release 😞

ericriff · 2022-10-27T15:54:46Z

What about the rest of my questions? Do you have any input?

uilianries · 2022-10-28T08:11:27Z

@ericriff Have you tried forcing CMAKE_INSTALL_LIBEXECDIR to libexec instead? You could use cmake.cached_variables["CMAKE_INSTALL_LIBEXECDIR"] = "libexec"

stale · 2022-11-27T08:33:45Z

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

…l if we use it

mold wants to install it on package_folder/libexec/mold, but the libexcec foder is forbidden in conan index

ericriff · 2022-12-09T19:56:48Z

Well, I had to patch the sources to make CMake install the ld -> mold symlink on the bin folder instead of libexec. I really don't like this since the libexec path is explicitly named on the mold README as the way to consume the linker. Conan complains about the existence of the libexec folder and blocks the PR if present.

On the other hand there is something weird with the test package. If, present, the build fails if two profiles (pr:b/pr:h) are used. It looks like in this case the generate() method is not called. If I remove the test package then it works as expected. Comments?

conan create recipes/mold/all mold/1.7.1@asd/asd -pr:b x86_64_gcc10 -pr:h x86_64_gcc10
Exporting package recipe
mold/1.7.1@asd/asd exports: File 'conandata.yml' found. Exporting it...
mold/1.7.1@asd/asd exports: Copied 1 '.yml' file: conandata.yml
mold/1.7.1@asd/asd: Calling export_sources()
mold/1.7.1@asd/asd: A new conanfile.py version was exported
mold/1.7.1@asd/asd: Folder: /home/eriff/.conan/data/mold/1.7.1/asd/asd/export
mold/1.7.1@asd/asd: Using the exported files summary hash as the recipe revision: bce3ad60132e3c0ed52bf109f160d8fb 
mold/1.7.1@asd/asd: Package recipe modified in export, forcing source folder removal
mold/1.7.1@asd/asd: Use the --keep-source, -k option to skip it
mold/1.7.1@asd/asd: Removing the local binary packages from different recipe revisions
mold/1.7.1@asd/asd: Exported revision: bce3ad60132e3c0ed52bf109f160d8fb
Configuration (profile_host):
[settings]
arch=x86_64
arch_build=x86_64
build_type=Release
compiler=gcc
compiler.libcxx=libstdc++11
compiler.version=10
os=Linux
os_build=Linux
[options]
[build_requires]
[env]
CC=/usr/bin/gcc-10
CXX=/usr/bin/g++-10
[conf]
tools.system.package_manager:mode=install
tools.system.package_manager:sudo=True

Configuration (profile_build):
[settings]
arch=x86_64
arch_build=x86_64
build_type=Release
compiler=gcc
compiler.libcxx=libstdc++11
compiler.version=10
os=Linux
os_build=Linux
[options]
[build_requires]
[env]
CC=/usr/bin/gcc-10
CXX=/usr/bin/g++-10
[conf]
tools.system.package_manager:mode=install
tools.system.package_manager:sudo=True

mold/1.7.1@asd/asd: Forced build from source
mold/1.7.1@asd/asd (test package): Installing package
Requirements
Packages
Build requirements
    mold/1.7.1@asd/asd from local cache - Cache
    onetbb/2021.3.0 from 'conancenter' - Cache
    openssl/1.1.1q from 'conancenter' - Cache
    xxhash/0.8.1 from 'conancenter' - Cache
    zlib/1.2.12 from 'conancenter' - Cache
Build requirements packages
    mold/1.7.1@asd/asd:cb98efe3cc008371f789eb28289810b8ecd5546a - Build
    onetbb/2021.3.0:79f200efe18f84353bb1264b3eeee74874c3dd69 - Cache
    openssl/1.1.1q:19729b9559f3ae196cad45cb2b97468ccb75dcd1 - Cache
    xxhash/0.8.1:d750cfef2639f696140dcb4782e5fd0eb44bb369 - Cache
    zlib/1.2.12:19729b9559f3ae196cad45cb2b97468ccb75dcd1 - Cache

Installing (downloading, building) binaries...
onetbb/2021.3.0: Already installed!
openssl/1.1.1q: Already installed!
xxhash/0.8.1: Already installed!
xxhash/0.8.1: Appending PATH environment variable: /home/eriff/.conan/data/xxhash/0.8.1/_/_/package/d750cfef2639f696140dcb4782e5fd0eb44bb369/bin
zlib/1.2.12: Already installed!
mold/1.7.1@asd/asd: Configuring sources in /home/eriff/.conan/data/mold/1.7.1/asd/asd/source/src
Downloading v1.7.1.tar.gz completed [8185.48k]                                           mold/1.7.1@asd/asd: sd: 
mold/1.7.1@asd/asd: 
mold/1.7.1@asd/asd: Copying sources to build folder
mold/1.7.1@asd/asd: Building your package in /home/eriff/.conan/data/mold/1.7.1/asd/asd/build/cb98efe3cc008371f789eb28289810b8ecd5546a
mold/1.7.1@asd/asd: Generator txt created conanbuildinfo.txt
mold/1.7.1@asd/asd: Calling generate()
mold/1.7.1@asd/asd: Preset 'release' added to CMakePresets.json. Invoke it manually using 'cmake --preset release'
mold/1.7.1@asd/asd: If your CMake version is not compatible with CMakePresets (<3.19) call cmake like: 'cmake <path> -G "Unix Makefiles" -DCMAKE_TOOLCHAIN_FILE=/home/eriff/.conan/data/mold/1.7.1/asd/asd/build/cb98efe3cc008371f789eb28289810b8ecd5546a/build/generators/conan_toolchain.cmake -DCMAKE_POLICY_DEFAULT_CMP0091=NEW -DCMAKE_BUILD_TYPE=Release'
mold/1.7.1@asd/asd: Aggregating env generators
mold/1.7.1@asd/asd: Calling build()
mold/1.7.1@asd/asd: Apply patch (conan): Change install folder of the ld symlink since conan center doesn't allow the libexec folder
mold/1.7.1@asd/asd: CMake command: cmake -G "Unix Makefiles" -DCMAKE_TOOLCHAIN_FILE="/home/eriff/.conan/data/mold/1.7.1/asd/asd/build/cb98efe3cc008371f789eb28289810b8ecd5546a/build/generators/conan_toolchain.cmake" -DCMAKE_INSTALL_PREFIX="/home/eriff/.conan/data/mold/1.7.1/asd/asd/package/cb98efe3cc008371f789eb28289810b8ecd5546a" -DCMAKE_POLICY_DEFAULT_CMP0091="NEW" -DCMAKE_BUILD_TYPE="Release" "/home/eriff/.conan/data/mold/1.7.1/asd/asd/build/cb98efe3cc008371f789eb28289810b8ecd5546a/src"
-- Using Conan toolchain: /home/eriff/.conan/data/mold/1.7.1/asd/asd/build/cb98efe3cc008371f789eb28289810b8ecd5546a/build/generators/conan_toolchain.cmake
-- The C compiler identification is GNU 10.3.0
-- The CXX compiler identification is GNU 10.3.0
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working C compiler: /usr/bin/gcc-10 - skipped
-- Detecting C compile features
-- Detecting C compile features - done
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: /usr/bin/g++-10 - skipped
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Looking for zstd.h
-- Looking for zstd.h - found
-- Performing Test P32
-- Performing Test P32 - Failed
CMake Error at CMakeLists.txt:179 (find_package):
  By not providing "FindTBB.cmake" in CMAKE_MODULE_PATH this project has
  asked CMake to find a package configuration file provided by "TBB", but
  CMake did not find one.

  Could not find a package configuration file provided by "TBB" with any of
  the following names:

    TBBConfig.cmake
    tbb-config.cmake

  Add the installation prefix of "TBB" to CMAKE_PREFIX_PATH or set "TBB_DIR"
  to a directory containing one of the above files.  If "TBB" provides a
  separate development package or SDK, be sure it has been installed.


-- Configuring incomplete, errors occurred!
See also "/home/eriff/.conan/data/mold/1.7.1/asd/asd/build/cb98efe3cc008371f789eb28289810b8ecd5546a/build/Release/CMakeFiles/CMakeOutput.log".
See also "/home/eriff/.conan/data/mold/1.7.1/asd/asd/build/cb98efe3cc008371f789eb28289810b8ecd5546a/build/Release/CMakeFiles/CMakeError.log".
mold/1.7.1@asd/asd: 
mold/1.7.1@asd/asd: ERROR: Package 'cb98efe3cc008371f789eb28289810b8ecd5546a' build failed
mold/1.7.1@asd/asd: WARN: Build folder /home/eriff/.conan/data/mold/1.7.1/asd/asd/build/cb98efe3cc008371f789eb28289810b8ecd5546a/build/Release
ERROR: mold/1.7.1@asd/asd: Error in build() method, line 81
	cmake.configure()
	ConanException: Error 1 while executing cmake -G "Unix Makefiles" -DCMAKE_TOOLCHAIN_FILE="/home/eriff/.conan/data/mold/1.7.1/asd/asd/build/cb98efe3cc008371f789eb28289810b8ecd5546a/build/generators/conan_toolchain.cmake" -DCMAKE_INSTALL_PREFIX="/home/eriff/.conan/data/mold/1.7.1/asd/asd/package/cb98efe3cc008371f789eb28289810b8ecd5546a" -DCMAKE_POLICY_DEFAULT_CMP0091="NEW" -DCMAKE_BUILD_TYPE="Release" "/home/eriff/.conan/data/mold/1.7.1/asd/asd/build/cb98efe3cc008371f789eb28289810b8ecd5546a/src"

ericriff · 2022-12-10T10:07:37Z

Well, generate() is being called, but the CMakeDeps files are not there

ls -lah ~/.conan/data/mold/1.7.1/asd/asd/build/cb98efe3cc008371f789eb28289810b8ecd5546a/build/generators
total 36K
drwxrwxr-x 2 eriff eriff 4,0K dic 10 07:05 .
drwxrwxr-x 4 eriff eriff 4,0K dic 10 07:05 ..
-rw-rw-r-- 1 eriff eriff 3,0K dic 10 07:05 cmakedeps_macros.cmake
-rw-rw-r-- 1 eriff eriff  958 dic 10 07:05 CMakePresets.json
-rw-rw-r-- 1 eriff eriff  717 dic 10 07:05 conanbuildenv-release-x86_64.sh
-rw-rw-r-- 1 eriff eriff  142 dic 10 07:05 conanbuild.sh
-rw-rw-r-- 1 eriff eriff 3,8K dic 10 07:05 conan_toolchain.cmake
-rw-rw-r-- 1 eriff eriff   27 dic 10 07:05 deactivate_conanbuildenv-release-x86_64.sh
-rw-rw-r-- 1 eriff eriff  153 dic 10 07:05 deactivate_conanbuild.sh

prince-chrismc · 2022-12-13T18:05:37Z

Well, I had to patch the sources to make CMake install the ld -> mold symlink on the bin folder instead of libexec. I really don't like this since the libexec path is explicitly named on the mold README as the way to consume the linker. Conan complains about the existence of the libexec folder and blocks the PR if present.

[HOOK - conan-center.py] post_package(): ERROR: [DEFAULT PACKAGE LAYOUT (KB-H013)] Unknown folder 'libexec' in the package (https://github.com/conan-io/conan-center-index/blob/master/docs/error_knowledge_base.md#KB-H013)
ERROR: [HOOK - conan-center.py] post_package(): Some checks failed running the hook, check the output

We can add exceptions to the hooks FYI its common on that one https://github.com/conan-io/hooks/blob/d587cfebbf2b31c16e477b79c0c2fd4501f60fc8/hooks/conan-center.py#L1089

ericriff · 2022-12-13T18:09:53Z

Well, I had to patch the sources to make CMake install the ld -> mold symlink on the bin folder instead of libexec. I really don't like this since the libexec path is explicitly named on the mold README as the way to consume the linker. Conan complains about the existence of the libexec folder and blocks the PR if present.

[HOOK - conan-center.py] post_package(): ERROR: [DEFAULT PACKAGE LAYOUT (KB-H013)] Unknown folder 'libexec' in the package (master/docs/error_knowledge_base.md#KB-H013)
ERROR: [HOOK - conan-center.py] post_package(): Some checks failed running the hook, check the output

We can add exceptions to the hooks FYI its common on that one conan-io/hooks@d587cfe/hooks/conan-center.py#L1089

That would be ideal. I also had to revert the usage of validate_build because the hooks think that I'm raising a conan invalid config within build :(

prince-chrismc · 2022-12-14T18:27:54Z

That would be ideal. I also had to revert the usage of validate_build because the hooks think that I'm raising a conan invalid config within build :(

To my knowledge validate_build is not ready for prime time, the migration path is still unclear so I would typicallly advice to avoid it for now 🙊

ericriff · 2022-12-19T15:19:06Z

@prince-chrismc I created a PR for the hooks as you suggested. Thanks!

prince-chrismc · 2022-12-26T06:11:20Z

Hooks are updated

conan-center-bot · 2022-12-26T06:30:33Z

Conan v1 pipeline

All green in build 6 (d4ec4bd65db023ef7a6d39e43843b6ff9a364f3f):

mold/1.4.2@:
All packages built successfully! (All logs)
mold/1.5.1@:
All packages built successfully! (All logs)
mold/1.7.1@:
All packages built successfully! (All logs)

Conan v2 pipeline (informative, not required for merge)

Failure in build 6 (d4ec4bd65db023ef7a6d39e43843b6ff9a364f3f):

mold/1.5.1@:
CI failed to create some packages (All logs)

Logs for packageID null:

[settings]
arch=x86_64
build_type=Release
compiler=gcc
compiler.libcxx=libstdc++11
compiler.version=11
os=Linux

********************************************************************************
conan install --require=mold/1.5.1@#68f9054c7b9f081a7ba6c65bb8410d0a --build=mold/1.5.1 -pr:h /home/conan/w/prod-v2/BuildSingleReference/6269/4bace54d-dbde-4db7-a35b-e7e93864f039/profile_linux_11_libstdcpp11_gcc_release_64..txt -c:h tools.system.package_manager:mode=install -c:h tools.system.package_manager:sudo=True -pr:b /home/conan/w/prod-v2/BuildSingleReference/6269/4bace54d-dbde-4db7-a35b-e7e93864f039/profile_linux_11_libstdcpp11_gcc_release_64..txt -c:b tools.system.package_manager:mode=install -c:b tools.system.package_manager:sudo=True
********************************************************************************

-------- Input profiles --------
Profile host:
[settings]
arch=x86_64
build_type=Release
compiler=gcc
compiler.libcxx=libstdc++11
compiler.version=11
os=Linux
[conf]
tools.system.package_manager:mode=install
tools.system.package_manager:sudo=True

Profile build:
[settings]
arch=x86_64
build_type=Release
compiler=gcc
compiler.libcxx=libstdc++11
compiler.version=11
os=Linux
[conf]
tools.system.package_manager:mode=install
tools.system.package_manager:sudo=True


-------- Computing dependency graph --------
zlib/1.2.12: Not found in local cache, looking in remotes...
zlib/1.2.12: Checking remote: conan-center-v2
zlib/1.2.12: Checking remote: c3i_PR-v2-13666
Graph root
    virtual
Requirements
    mold/1.5.1#68f9054c7b9f081a7ba6c65bb8410d0a - Cache
Graph error
    Package 'zlib/1.2.12' not resolved: Unable to find 'zlib/1.2.12' in remotes

-------- Computing necessary packages --------
ERROR: Package 'zlib/1.2.12' not resolved: Unable to find 'zlib/1.2.12' in remotes

mold/1.4.2@:
Didn't run or was cancelled before finishing
mold/1.7.1@:
Didn't run or was cancelled before finishing

^{Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.}

uilianries

LGTM

* Add version 1.6.0 * Rename VirtualBuildEnv variable so we don't override the CMakeToolchain one * Move some checks to validate_build * Fix LD env variable * Replace 1.6.0 with latest release 1.7.1 * Fix install * Do not use validate_build(), the conancenter hooks are broken and fail if we use it * Patch the location of the ld symlink mold wants to install it on package_folder/libexec/mold, but the libexcec foder is forbidden in conan index * Remove commented out code

ericriff added 3 commits October 21, 2022 10:12

Add version 1.6.0

b5135a0

Rename VirtualBuildEnv variable so we don't override the CMakeToolcha…

6f5f295

…in one

Move some checks to validate_build

b2d709c

github-actions bot mentioned this pull request Oct 21, 2022

Pull Requests Ready to be Reviewed prince-chrismc/conan-center-index-pending-review#1

Open

conan-center-bot added the Failed label Oct 21, 2022

This comment has been minimized.

Sign in to view

Fix LD env variable

5ef3f12

This was referenced Oct 21, 2022

Updatable recipes qchateau/conan-center-bot#1

Open

[request] Updatable recipes #3470

Closed

stale bot added the stale label Nov 27, 2022

ericriff added 2 commits December 9, 2022 13:36

Replace 1.6.0 with latest release 1.7.1

65c75cb

Fix install

eee8661

stale bot removed the stale label Dec 9, 2022

This comment has been minimized.

Sign in to view

Do not use validate_build(), the conancenter hooks are broken and fai…

acd062f

…l if we use it

jcar87 self-assigned this Dec 9, 2022

This comment has been minimized.

Sign in to view

Patch the location of the ld symlink

5483aec

mold wants to install it on package_folder/libexec/mold, but the libexcec foder is forbidden in conan index

conan-center-bot removed the Failed label Dec 9, 2022

This comment has been minimized.

Sign in to view

ericriff changed the title ~~[Help Needed] Add mold 1.6.0 and try to allow the usage of this tool on projects based on older gcc versions~~ Update mold to 1.7.1 Dec 9, 2022

Remove commented out code

d4ec4bd

This comment has been minimized.

Sign in to view

ericriff mentioned this pull request Dec 19, 2022

Do not enforce KB-H013 on mold conan-io/hooks#464

Merged

prince-chrismc closed this Dec 26, 2022

prince-chrismc reopened this Dec 26, 2022

conan-center-bot added the Failed label Dec 26, 2022

uilianries approved these changes Dec 27, 2022

View reviewed changes

prince-chrismc approved these changes Dec 27, 2022

View reviewed changes

conan-center-bot merged commit 69fbb53 into conan-io:master Dec 27, 2022

ericriff mentioned this pull request Jan 2, 2023

[Mold] Use the official libexecdir now that the CCI hooks allow it #15068

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update mold to 1.7.1 #13666

Update mold to 1.7.1 #13666

ericriff commented Oct 21, 2022 •

edited

Loading

This comment has been minimized.

ericriff commented Oct 21, 2022

ericriff commented Oct 21, 2022 •

edited

Loading

ericriff commented Oct 25, 2022

uilianries commented Oct 26, 2022

ericriff commented Oct 27, 2022

uilianries commented Oct 28, 2022

stale bot commented Nov 27, 2022

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

ericriff commented Dec 9, 2022 •

edited

Loading

This comment has been minimized.

ericriff commented Dec 10, 2022

prince-chrismc commented Dec 13, 2022

ericriff commented Dec 13, 2022

prince-chrismc commented Dec 14, 2022

ericriff commented Dec 19, 2022

prince-chrismc commented Dec 26, 2022

conan-center-bot commented Dec 26, 2022

uilianries left a comment

Update mold to 1.7.1 #13666

Update mold to 1.7.1 #13666

Conversation

ericriff commented Oct 21, 2022 • edited Loading

This comment has been minimized.

ericriff commented Oct 21, 2022

ericriff commented Oct 21, 2022 • edited Loading

ericriff commented Oct 25, 2022

uilianries commented Oct 26, 2022

ericriff commented Oct 27, 2022

uilianries commented Oct 28, 2022

stale bot commented Nov 27, 2022

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

ericriff commented Dec 9, 2022 • edited Loading

This comment has been minimized.

ericriff commented Dec 10, 2022

prince-chrismc commented Dec 13, 2022

ericriff commented Dec 13, 2022

prince-chrismc commented Dec 14, 2022

ericriff commented Dec 19, 2022

prince-chrismc commented Dec 26, 2022

conan-center-bot commented Dec 26, 2022

Conan v1 pipeline

Conan v2 pipeline (informative, not required for merge)

uilianries left a comment

Choose a reason for hiding this comment

ericriff commented Oct 21, 2022 •

edited

Loading

ericriff commented Oct 21, 2022 •

edited

Loading

ericriff commented Dec 9, 2022 •

edited

Loading