-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CMake Conan 2.0 compatibility #13739
CMake Conan 2.0 compatibility #13739
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Co-authored-by: Uilian Ries <uilianries@gmail.com>
Co-authored-by: Uilian Ries <uilianries@gmail.com>
Co-authored-by: Uilian Ries <uilianries@gmail.com>
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This counts towards #12888 🚀 |
I detected other pull requests that are modifying cmake/3.x.x recipe: This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there. |
Co-authored-by: SpaceIm <30052553+SpaceIm@users.noreply.github.com>
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks really good there's a lot of good work, I dont see any blockers (nor any issue for that matter) I think this good unless there's a blockers.
Check from me!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Co-authored-by: SpaceIm <30052553+SpaceIm@users.noreply.github.com>
182c7d4
Conan v1 pipelineAll green in build 40 (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Thanks so much @System-Arch, on top of Conan 2.0 compatibility this receives a much needed improvement. Thanks to all reviewers as well!
* CMake Conan 2.0 compatibility * Fix lint errors * Avoid lint error with Conan 2.0 argument name * Avoid lint error with Conan 2.0 argument name * Removed unused imports * Handle Conan version disparities * Use basic_layout with Autotools Co-authored-by: Uilian Ries <uilianries@gmail.com> * Call AutotoolsDeps generate Co-authored-by: Uilian Ries <uilianries@gmail.com> * Call CMakeDeps generate Co-authored-by: Uilian Ries <uilianries@gmail.com> * Update imports per suggestioned changes * Removed extra space * Remove extraneous items * Determine require_version in a version-agnostic manner * Use Conan 1.53 * Handle @ in ref * Fix lint errors * Bigger hammer * Remove PATH addition in package_id Co-authored-by: Chris Mc <prince.chrismc@gmail.com> * Use validate_build instead of validate * Moved Mac x86 check to validate() method. * Bump openssl version Co-authored-by: Chris Mc <prince.chrismc@gmail.com> * Add blank line to trigger CI build * Eliminate use of validate_build() * Restore use of validate_build() * Removed blank line to trigger CI * Add blank line to trigger CI * Added boostrap options and removed unneeded env. vars * Deal with Conan 1.x vs 2.0 inconsistencies * Fixed lint issue * Placate linter * Apply suggestions from code review Co-authored-by: SpaceIm <30052553+SpaceIm@users.noreply.github.com> * Use save & load for bootstrap args; Use tool_requires in test packages * Eliminate use of validate_build; Add more settings to test recipes * Set PATH in package_info() for v1.x; Lower req. ver. to 1.50 * Apply suggestions from code review Co-authored-by: SpaceIm <30052553+SpaceIm@users.noreply.github.com> * Added AutotoolsDeps generator; Eliminated can_run() from tests * Correct msvc version Co-authored-by: SpaceIm <30052553+SpaceIm@users.noreply.github.com> * Use f-strings * Replace VirtualRunEnv with VirtualBuildEnv Co-authored-by: SpaceIm <30052553+SpaceIm@users.noreply.github.com> Co-authored-by: Uilian Ries <uilianries@gmail.com> Co-authored-by: Chris Mc <prince.chrismc@gmail.com> Co-authored-by: SpaceIm <30052553+SpaceIm@users.noreply.github.com>
* CMake Conan 2.0 compatibility * Fix lint errors * Avoid lint error with Conan 2.0 argument name * Avoid lint error with Conan 2.0 argument name * Removed unused imports * Handle Conan version disparities * Use basic_layout with Autotools Co-authored-by: Uilian Ries <uilianries@gmail.com> * Call AutotoolsDeps generate Co-authored-by: Uilian Ries <uilianries@gmail.com> * Call CMakeDeps generate Co-authored-by: Uilian Ries <uilianries@gmail.com> * Update imports per suggestioned changes * Removed extra space * Remove extraneous items * Determine require_version in a version-agnostic manner * Use Conan 1.53 * Handle @ in ref * Fix lint errors * Bigger hammer * Remove PATH addition in package_id Co-authored-by: Chris Mc <prince.chrismc@gmail.com> * Use validate_build instead of validate * Moved Mac x86 check to validate() method. * Bump openssl version Co-authored-by: Chris Mc <prince.chrismc@gmail.com> * Add blank line to trigger CI build * Eliminate use of validate_build() * Restore use of validate_build() * Removed blank line to trigger CI * Add blank line to trigger CI * Added boostrap options and removed unneeded env. vars * Deal with Conan 1.x vs 2.0 inconsistencies * Fixed lint issue * Placate linter * Apply suggestions from code review Co-authored-by: SpaceIm <30052553+SpaceIm@users.noreply.github.com> * Use save & load for bootstrap args; Use tool_requires in test packages * Eliminate use of validate_build; Add more settings to test recipes * Set PATH in package_info() for v1.x; Lower req. ver. to 1.50 * Apply suggestions from code review Co-authored-by: SpaceIm <30052553+SpaceIm@users.noreply.github.com> * Added AutotoolsDeps generator; Eliminated can_run() from tests * Correct msvc version Co-authored-by: SpaceIm <30052553+SpaceIm@users.noreply.github.com> * Use f-strings * Replace VirtualRunEnv with VirtualBuildEnv Co-authored-by: SpaceIm <30052553+SpaceIm@users.noreply.github.com> Co-authored-by: Uilian Ries <uilianries@gmail.com> Co-authored-by: Chris Mc <prince.chrismc@gmail.com> Co-authored-by: SpaceIm <30052553+SpaceIm@users.noreply.github.com>
Hi, I was looking for cmake/3.20.0 in linux ( ubuntu , arch x86_64, gcc=9) for conan 2 |
But looks like the binary went missing. can you help me on this. likewise I have few other packages which didn't work on conan-v2 , but not sure how I can contribute the built packages to conan-center. |
Hi @sabapathi20 - will continue in this issue: #24939 |
Specify library name and version: cmake/3.24.2
Updated conanfile.py and test_package/conanfile.py to work with Conan 2.0.0-beta4 (Resolves #13613)
Changes involve leveraging Conan 2.0 generators and other syntactic changes
Tested on Linux (including bootstrap option) and Windows
Note that many of the test files packaged with the CMake source code trigger conan-center hook failures due to missing trailing endlines and missing CMake minimum version declarations.