-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
grpc: more conan v2 stuff + bump zlib #13817
Conversation
SpaceIm
commented
Oct 27, 2022
- use conan.tools.files.copy instead of self.copy
- no more usage of msvc_version_to_vs_ide_version, it's not part of conan public API. Use check_min_vs instead.
- access to dependencies options through self.dependencies
- self.info in validate()
- bump zlib to 1.2.13
- I've read the guidelines for contributing.
- I've followed the PEP8 style guides for Python code in the recipes.
- I've used the latest Conan client version.
- I've tried at least one configuration locally with the conan-center hook activated.
- use conan.tools.files.copy instead of self.copy - no more usage of msvc_version_to_vs_ide_version, it's not part of conan public API. Use check_min_vs instead. - access to dependencies options through self.dependencies
b7f99ae
to
b338e49
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
waiting for #13820 |
Conan v1 pipelineAll green in build 6 (
|
@@ -95,35 +101,32 @@ def requirements(self): | |||
self.requires("c-ares/1.18.1") | |||
self.requires("openssl/1.1.1q") | |||
self.requires("re2/20220601") | |||
self.requires("zlib/1.2.12") | |||
self.requires("zlib/1.2.13") | |||
self.requires("protobuf/3.21.4") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When cross compiling, shoulnd't the protoc binaries only be built for the host platform and not the target platform?
self.options["protobuf"].with_protoc_binaries = False
However, this will only work if protobuf recipe is updated fjp@cc59b53
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it doesn't matter for grpc recipe, so there is no reason to force this option in grpc recipe itself.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your quick response.
Sure, it can also be set in a profile or from the command line. But my point is that there seems to be an issue when cross building grpc. Cross-build from 'Linux:x86_64' to 'Linux:armv7hf' using -b missing
I get build errors for protobuf:
...
usr/include/c++/v1/cstdlib:123:9: error: target of using declaration conflicts with declaration already in scope
using ::abs _LIBCPP_USING_IF_EXISTS;
...
protobuf/3.20.0: ERROR: Package '4c113c49faf2c4384d5b6d4b12ce3565050d800e' build failed
protobuf/3.20.0: WARN: Build folder /root/.conan/data/protobuf/3.20.0/_/_/build/4c113c49faf2c4384d5b6d4b12ce3565050d800e
root@0ec9a559fe37:~# conan or in build() method, line 203
ConanException: Error 2 while executing cmake --build '/root/.conan/data/protobuf/3.20.0/_/_/build/4c113c49faf2c4384d5b6d4b12ce3565050d800e/build_subfolder' '--' '-j8'
Are there any build jobs on conan-center-index that run cross compilation? I have just seen #13817 (comment) which doesn't seem to use different host and build profiles, but please correct me if I am wrong.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In c3i, there is one cross-build with 2 profiles: from macOS Intel to macOS M1.
From what I see from your log, it may be a protobuf recipe issue, when target is Linux armv7hf.
@SpaceIm is there any particular reason for this line?
|