Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fontconfig] use new meson toolchain where supported #13845

Merged

Conversation

planetmarshall
Copy link
Contributor

Specify library name and version: fontconfig

Split the version of fontconfig supporting Meson into its own folder and use the new toolchain.


  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the conan-center hook activated.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

Copy link
Contributor

@prince-chrismc prince-chrismc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a lot of diff, but I just noticed what you are doing so i will circle back

@conan-center-bot

This comment has been minimized.

@prince-chrismc
Copy link
Contributor

This is also towards #12888 🚀 amazing work

even if it's only the new version thats still great

prince-chrismc
prince-chrismc previously approved these changes Nov 1, 2022
recipes/fontconfig/all/conanfile.py Outdated Show resolved Hide resolved
recipes/fontconfig/meson/conanfile.py Outdated Show resolved Hide resolved
recipes/fontconfig/meson/conanfile.py Outdated Show resolved Hide resolved
recipes/fontconfig/meson/conanfile.py Outdated Show resolved Hide resolved
Co-authored-by: Uilian Ries <uilianries@gmail.com>
planetmarshall and others added 3 commits November 6, 2022 14:53
Co-authored-by: Uilian Ries <uilianries@gmail.com>
Co-authored-by: Uilian Ries <uilianries@gmail.com>
Co-authored-by: Uilian Ries <uilianries@gmail.com>
@conan-center-bot

This comment has been minimized.

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline

All green in build 9 (5133ccd83c4b76a9dd8261ee21ec1b9c23b6e67d):

  • fontconfig/2.13.92@:
    All packages built successfully! (All logs)

    🔸 Informative: This recipe is not ready for Conan v2

    We have started the migration process to Conan v2 and exporting recipes successfully will be required in the future.
    This is just an informative note to gain awareness about the process, no need to take any action. The plan is to enforce smaller steps that are easier to fix and, eventually, this conan export step will work.
    See the recipe migration guide to know more about the changes required.

    ERROR: Error loading conanfile at '/home/conan/w/prod_cci_PR-13845/recipes/fontconfig/all/conanfile.py': Unable to load conanfile in /home/conan/w/prod_cci_PR-13845/recipes/fontconfig/all/conanfile.py
      File "<frozen importlib._bootstrap_external>", line 728, in exec_module
      File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
      File "/home/conan/w/prod_cci_PR-13845/recipes/fontconfig/all/conanfile.py", line 4, in <module>
        from conans import tools, AutoToolsBuildEnvironment
    ImportError: cannot import name 'tools' from 'conans' (/opt/pyenv/versions/3.7.13/lib/python3.7/site-packages/conans/__init__.py)
    
  • fontconfig/2.13.91@:
    All packages built successfully! (All logs)

    🔸 Informative: This recipe is not ready for Conan v2

    We have started the migration process to Conan v2 and exporting recipes successfully will be required in the future.
    This is just an informative note to gain awareness about the process, no need to take any action. The plan is to enforce smaller steps that are easier to fix and, eventually, this conan export step will work.
    See the recipe migration guide to know more about the changes required.

    ERROR: Error loading conanfile at '/home/conan/w/prod_cci_PR-13845/recipes/fontconfig/all/conanfile.py': Unable to load conanfile in /home/conan/w/prod_cci_PR-13845/recipes/fontconfig/all/conanfile.py
      File "<frozen importlib._bootstrap_external>", line 728, in exec_module
      File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
      File "/home/conan/w/prod_cci_PR-13845/recipes/fontconfig/all/conanfile.py", line 4, in <module>
        from conans import tools, AutoToolsBuildEnvironment
    ImportError: cannot import name 'tools' from 'conans' (/opt/pyenv/versions/3.7.13/lib/python3.7/site-packages/conans/__init__.py)
    
  • fontconfig/2.13.93@:
    All packages built successfully! (All logs)

@conan-center-bot conan-center-bot merged commit 8f900f9 into conan-io:master Nov 8, 2022
@planetmarshall planetmarshall deleted the fontconfig-new-toolchain branch March 4, 2024 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants