Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

openh264/* upgrade to conan v2 #13849

Merged
merged 11 commits into from
Nov 10, 2022
Merged

openh264/* upgrade to conan v2 #13849

merged 11 commits into from
Nov 10, 2022

Conversation

Nomalah
Copy link
Contributor

@Nomalah Nomalah commented Oct 28, 2022

Specify library name and version: openh264/*

Upgrade openh264 to conan v2


  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the conan-center hook activated.

@conan-center-bot

This comment has been minimized.

@Nomalah
Copy link
Contributor Author

Nomalah commented Oct 29, 2022

(also added v2.3.1)

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

recipes/openh264/all/conanfile.py Outdated Show resolved Hide resolved
recipes/openh264/all/conanfile.py Outdated Show resolved Hide resolved
recipes/openh264/all/test_v1_package/conanfile.py Outdated Show resolved Hide resolved
@conan-center-bot

This comment has been minimized.

@Nomalah Nomalah requested a review from SpaceIm October 29, 2022 21:33
Copy link
Contributor

@prince-chrismc prince-chrismc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for adding the patch fields just would like to change them to match the docs.

I believe they are all about fixes for different system and they should be type portability

Please let me know if that's not correct:)

@conan-center-bot

This comment has been minimized.

@prince-chrismc
Copy link
Contributor

This counts towards #12888 🚀 amazing contribution

prince-chrismc
prince-chrismc previously approved these changes Oct 31, 2022
recipes/openh264/all/conanfile.py Outdated Show resolved Hide resolved
@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline

All green in build 8 (9f6d17507e8336393c6cf560666cbd9b2cb9eae0):

  • openh264/2.1.1@:
    All packages built successfully! (All logs)

    🔸 Informative: This recipe is not ready for Conan v2

    We have started the migration process to Conan v2 and exporting recipes successfully will be required in the future.
    This is just an informative note to gain awareness about the process, no need to take any action. The plan is to enforce smaller steps that are easier to fix and, eventually, this conan export step will work.
    See the recipe migration guide to know more about the changes required.

    ERROR: Error loading conanfile at '/home/conan/w/prod_cci_PR-13849/recipes/openh264/all/conanfile.py': Unable to load conanfile in /home/conan/w/prod_cci_PR-13849/recipes/openh264/all/conanfile.py
      File "<frozen importlib._bootstrap_external>", line 728, in exec_module
      File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
      File "/home/conan/w/prod_cci_PR-13849/recipes/openh264/all/conanfile.py", line 2, in <module>
        from conans import tools
    ImportError: cannot import name 'tools' from 'conans' (/opt/pyenv/versions/3.7.13/lib/python3.7/site-packages/conans/__init__.py)
    
  • openh264/1.7.0@:
    All packages built successfully! (All logs)

    🔸 Informative: This recipe is not ready for Conan v2

    We have started the migration process to Conan v2 and exporting recipes successfully will be required in the future.
    This is just an informative note to gain awareness about the process, no need to take any action. The plan is to enforce smaller steps that are easier to fix and, eventually, this conan export step will work.
    See the recipe migration guide to know more about the changes required.

    ERROR: Error loading conanfile at '/home/conan/w/prod_cci_PR-13849/recipes/openh264/all/conanfile.py': Unable to load conanfile in /home/conan/w/prod_cci_PR-13849/recipes/openh264/all/conanfile.py
      File "<frozen importlib._bootstrap_external>", line 728, in exec_module
      File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
      File "/home/conan/w/prod_cci_PR-13849/recipes/openh264/all/conanfile.py", line 2, in <module>
        from conans import tools
    ImportError: cannot import name 'tools' from 'conans' (/opt/pyenv/versions/3.7.13/lib/python3.7/site-packages/conans/__init__.py)
    
  • openh264/2.3.1@:
    All packages built successfully! (All logs)

    🔸 Informative: This recipe is not ready for Conan v2

    We have started the migration process to Conan v2 and exporting recipes successfully will be required in the future.
    This is just an informative note to gain awareness about the process, no need to take any action. The plan is to enforce smaller steps that are easier to fix and, eventually, this conan export step will work.
    See the recipe migration guide to know more about the changes required.

    ERROR: Error loading conanfile at '/home/conan/w/prod_cci_PR-13849/recipes/openh264/all/conanfile.py': Unable to load conanfile in /home/conan/w/prod_cci_PR-13849/recipes/openh264/all/conanfile.py
      File "<frozen importlib._bootstrap_external>", line 728, in exec_module
      File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
      File "/home/conan/w/prod_cci_PR-13849/recipes/openh264/all/conanfile.py", line 2, in <module>
        from conans import tools
    ImportError: cannot import name 'tools' from 'conans' (/opt/pyenv/versions/3.7.13/lib/python3.7/site-packages/conans/__init__.py)
    

@conan-center-bot conan-center-bot merged commit 10cf6a7 into conan-io:master Nov 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants