libffi - fix to support updated automake recipe #14460
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulharris
force-pushed
the
libffi-support-new-automake-recipe
branch
from
2791ce0 to
10c2fe9
Compare
SpaceIm
reviewed
Nov 29, 2022
Comment on lines
-134
to
-138
| ar_wrapper = unix_path(self, os.path.join(self.dependencies.direct_build['automake'].cpp_info.resdirs[0], f"automake-{automake_version}", "ar-lib")) | ||
| env.define("CC", f"{compile_wrapper}") | ||
| env.define("CXX", f"{compile_wrapper}") | ||
| env.define("LD", "link -nologo") | ||
| env.define("AR", f"{ar_wrapper} \"lib -nologo\"") |
There was a problem hiding this comment.
automake doesn't yet define this conf, and the fix here is not correct. Not sure it's worth struggling c3i for something we know fails for the moment.
Conan v1 pipelineFailure in build 2 (
Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability. |
|
Ok, I'll close this and can start again when automake is done... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Waiting on #12898
Pushing this up now to get the ball rolling.
Note that the original commented out line of code was:
env.define("AR", f"{unix_path(self, self.conf.get('tools.automake:ar-lib'))}")but I needed to do this for it to work:
env.define("AR", f"{unix_path(self, self.conf.get('user.automake:ar-lib'))}")Perhaps there are still things to change in automake / conan before this is merged?