-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add dbus requirement for building qt webengine on linux #14607
Conversation
This comment has been minimized.
This comment has been minimized.
I detected other pull requests that are modifying qt/6.x.x recipe:
This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why self.settings.get_safe("os")
as opposed to self.settings.os
?
04448e5
to
1f32dc8
Compare
This comment has been minimized.
This comment has been minimized.
I wasn't sure when to call I've updated the PR |
@EricAtORS you are now authorized. Can you close this PR and re-open it, to trigger CI ? |
I just triggered it now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
https://docs.conan.io/en/latest/reference/conanfile/attributes.html#settings Basically, it's used when an setting can be or not available. |
This comment has been minimized.
This comment has been minimized.
Hooks produced the following warnings for commit 1f32dc8qt/6.4.1
|
@EricAtORS This error is not related to your PR. can you please close/reopen the PR to retrigger CI ? |
Conan v1 pipelineAll green in build 4 (
|
Hooks produced the following warnings for commit 1f32dc8qt/6.2.4
qt/6.4.1
qt/6.3.2
|
Specify library name and version: qt/*
This PR closes #14603