Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jom: Download binaries in build method and fix test packages #14701

Merged
merged 4 commits into from
Dec 26, 2022

Conversation

jwillikers
Copy link
Contributor

Use conan.tools.files.copy.
Update license to be GPL-3.0-only.

Specify library name and version: lib/1.0

This is also a good place to share with all of us why you are submitting this PR (specially if it is a new addition to ConanCenter): is it a dependency of other libraries you want to package? Are you the author of the library? Thanks!


Use conan.tools.files.copy.
Update license to be GPL-3.0-only.
@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@jwillikers jwillikers closed this Dec 13, 2022
@jwillikers jwillikers reopened this Dec 13, 2022
@uilianries
Copy link
Member

Just restarted it now.

@conan-center-bot

This comment has been minimized.

uilianries
uilianries previously approved these changes Dec 14, 2022
Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

recipes/jom/all/conanfile.py Outdated Show resolved Hide resolved
recipes/jom/all/conanfile.py Outdated Show resolved Hide resolved
@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline

All green in build 6 (490be1f555a43d3d6c0bce943a02bcaa40848b33):

  • jom/1.1.3@:
    All packages built successfully! (All logs)

Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jwillikers
Copy link
Contributor Author

@ericLemanissier PTAL, thanks!

@conan-center-bot conan-center-bot merged commit 0200bc0 into conan-io:master Dec 26, 2022
@jwillikers jwillikers deleted the jom-conan-v2 branch December 26, 2022 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants