Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add tinycthreadpool #14703

Merged
merged 10 commits into from
Apr 17, 2023
Merged

add tinycthreadpool #14703

merged 10 commits into from
Apr 17, 2023

Conversation

bennyhuo
Copy link
Contributor

Specify library name and version: tinycthreadpool/1.0

This is a portable C threadpool. It is based on tinycthread and supports both Windows and POSIX systems.

@CLAassistant
Copy link

CLAassistant commented Dec 12, 2022

CLA assistant check
All committers have signed the CLA.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

4 similar comments
@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution. I see you are using Conan in your project already 😸

recipes/tinycthreadpool/all/conanfile.py Outdated Show resolved Hide resolved
recipes/tinycthreadpool/all/conanfile.py Outdated Show resolved Hide resolved
recipes/tinycthreadpool/all/conanfile.py Outdated Show resolved Hide resolved
recipes/tinycthreadpool/all/conanfile.py Outdated Show resolved Hide resolved
recipes/tinycthreadpool/all/conanfile.py Outdated Show resolved Hide resolved
recipes/tinycthreadpool/all/conanfile.py Outdated Show resolved Hide resolved
recipes/tinycthreadpool/all/test_package/CMakeLists.txt Outdated Show resolved Hide resolved
@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@bennyhuo
Copy link
Contributor Author

I have updated the recipe to make all the checks passed. Please let me know if there is something else to do to meet the requirements. Thanks.

@bennyhuo
Copy link
Contributor Author

@uilianries Hi there, I just wonder when can we have this pull request merged? Are there any problems I need to fix? : )

Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bennyhuo Thank you for your contribution! Please, take a look on my review

recipes/tinycthreadpool/all/conanfile.py Outdated Show resolved Hide resolved
recipes/tinycthreadpool/all/conanfile.py Outdated Show resolved Hide resolved
recipes/tinycthreadpool/all/conanfile.py Outdated Show resolved Hide resolved
recipes/tinycthreadpool/all/conanfile.py Outdated Show resolved Hide resolved
recipes/tinycthreadpool/all/conanfile.py Show resolved Hide resolved
@uilianries
Copy link
Member

@bennyhuo no fPIC neither shared option support? Does tinycthreadpool only supports static library?

bennyhuo and others added 3 commits April 8, 2023 21:44
Co-authored-by: Chris Mc <prince.chrismc@gmail.com>
Co-authored-by: Chris Mc <prince.chrismc@gmail.com>
Co-authored-by: Chris Mc <prince.chrismc@gmail.com>
@bennyhuo
Copy link
Contributor Author

bennyhuo commented Apr 8, 2023

I have some concerns about this project, since it's a fork we usually do not allow those

and when they add enough value we ask for teh author prefix... but when I was looking into I noticed this has a copy of

https://github.com/tinycthread/tinycthread

embeeded inside ... which is fine but for conan that would ideal be a dependency since people could want to use two lirbaries that depend on it this and something else that would hit linkage issues.

Have you considered linking against this library instead of copying it?

mbrossard/threadpool@master...bennyhuo:tinycthreadpool:master#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5

I have tried, but the recipe does not work well with the new conan version. Any suggestions? @prince-chrismc

tinycthread/cci.20161001: Downloaded recipe revision bbbf04729d59be014078ab872ab2482f
Graph root
    conanfile.txt: /Users/benny/WorkSpace/external/tinycthreadpool/conanfile.txt
*********************************************************
Recipe 'tinycthread/cci.20161001' seems broken.
It is possible that this recipe is not Conan 2.0 ready
If the recipe comes from ConanCenter check: https://conan.io/cci-v2.html
If it is your recipe, check if it is updated to 2.0
*********************************************************

ERROR: Package 'tinycthread/cci.20161001' not resolved: tinycthread/cci.20161001: Cannot load recipe.
Error loading conanfile at '/Users/benny/.conan2/p/tinyc23a3a45c6c35e/e/conanfile.py': Unable to load conanfile in /Users/benny/.conan2/p/tinyc23a3a45c6c35e/e/conanfile.py
  File "<frozen importlib._bootstrap_external>", line 850, in exec_module
  File "<frozen importlib._bootstrap>", line 228, in _call_with_frames_removed
  File "/Users/benny/.conan2/p/tinyc23a3a45c6c35e/e/conanfile.py", line 1, in <module>
    from conans import CMake, ConanFile, tools
ImportError: cannot import name 'CMake' from 'conans' (/Users/benny/Library/Python/3.9/lib/python/site-packages/conans/__init__.py)

@conan-center-bot

This comment has been minimized.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 8, 2023

Hooks produced the following warnings for commit 57ebec7
tinycthreadpool/1.0
post_package(): WARN: [APPLE RELOCATABLE SHARED LIBS (KB-H077)] install_name dir of these shared libs is not @rpath: libtinycthreadpool.dylib

@bennyhuo
Copy link
Contributor Author

Hello, any news about this? @prince-chrismc

@prince-chrismc
Copy link
Contributor

I'd suggest updateting you build script to link against the original library instead of trying to duplicate it, I made #17001 which is pretty small and will support v2

but we can make sure everything works with v1 in the mean time

@bennyhuo
Copy link
Contributor Author

I'd suggest updateting you build script to link against the original library instead of trying to duplicate it, I made #17001 which is pretty small and will support v2

but we can make sure everything works with v1 in the mean time

Great. I shall update my project after #17001 merged. Thanks.

@prince-chrismc
Copy link
Contributor

It was merged, drop a comment here if you have any questions. you can also find me in the cppalaince slack's Conan channel :)

@bennyhuo
Copy link
Contributor Author

It was merged, drop a comment here if you have any questions. you can also find me in the cppalaince slack's Conan channel :)

Great news, I will follow this up asap.

@conan-center-bot

This comment has been minimized.

@bennyhuo
Copy link
Contributor Author

bennyhuo commented Apr 15, 2023

Done. @prince-chrismc

prince-chrismc
prince-chrismc previously approved these changes Apr 17, 2023
Co-authored-by: Chris Mc <prince.chrismc@gmail.com>
Co-authored-by: Chris Mc <prince.chrismc@gmail.com>
@prince-chrismc
Copy link
Contributor

:) 🤞

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 42 (e665fc9bb4ce0aaec6c935f83a6453819afac55a):

  • tinycthreadpool/1.0@:
    All packages built successfully! (All logs)

Conan v2 pipeline (informative, not required for merge) ✔️

Note: Conan v2 builds are informative and they are not required for the PR to be merged.

All green in build 41 (e665fc9bb4ce0aaec6c935f83a6453819afac55a):

  • tinycthreadpool/1.0@:
    All packages built successfully! (All logs)

@conan-center-bot conan-center-bot merged commit 12f5b46 into conan-io:master Apr 17, 2023
franramirez688 pushed a commit to franramirez688/conan-center-index that referenced this pull request May 10, 2023
* add tinycthreadpool

* Update recipes/tinycthreadpool/all/conanfile.py

Co-authored-by: Chris Mc <prince.chrismc@gmail.com>

* Update recipes/tinycthreadpool/all/conanfile.py

Co-authored-by: Chris Mc <prince.chrismc@gmail.com>

* Update recipes/tinycthreadpool/all/conanfile.py

Co-authored-by: Chris Mc <prince.chrismc@gmail.com>

* Update recipes/tinycthreadpool/all/conanfile.py

Co-authored-by: Chris Mc <prince.chrismc@gmail.com>

* Update recipes/tinycthreadpool/all/conanfile.py

Co-authored-by: Chris Mc <prince.chrismc@gmail.com>

* Update recipes/tinycthreadpool/all/conanfile.py

Co-authored-by: Chris Mc <prince.chrismc@gmail.com>

* depends on tinycthread as a library not source.

* Update recipes/tinycthreadpool/all/conanfile.py

Co-authored-by: Chris Mc <prince.chrismc@gmail.com>

* Update recipes/tinycthreadpool/all/conanfile.py

Co-authored-by: Chris Mc <prince.chrismc@gmail.com>

---------

Co-authored-by: Chris Mc <prince.chrismc@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants