-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add tinycthreadpool #14703
add tinycthreadpool #14703
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
4 similar comments
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution. I see you are using Conan in your project already 😸
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
I have updated the recipe to make all the checks passed. Please let me know if there is something else to do to meet the requirements. Thanks. |
@uilianries Hi there, I just wonder when can we have this pull request merged? Are there any problems I need to fix? : ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bennyhuo Thank you for your contribution! Please, take a look on my review
@bennyhuo no fPIC neither shared option support? Does tinycthreadpool only supports static library? |
Co-authored-by: Chris Mc <prince.chrismc@gmail.com>
Co-authored-by: Chris Mc <prince.chrismc@gmail.com>
Co-authored-by: Chris Mc <prince.chrismc@gmail.com>
I have tried, but the recipe does not work well with the new conan version. Any suggestions? @prince-chrismc
|
This comment has been minimized.
This comment has been minimized.
Hooks produced the following warnings for commit 57ebec7tinycthreadpool/1.0
|
Hello, any news about this? @prince-chrismc |
I'd suggest updateting you build script to link against the original library instead of trying to duplicate it, I made #17001 which is pretty small and will support v2 but we can make sure everything works with v1 in the mean time |
It was merged, drop a comment here if you have any questions. you can also find me in the cppalaince slack's Conan channel :) |
Great news, I will follow this up asap. |
This comment has been minimized.
This comment has been minimized.
Done. @prince-chrismc |
Co-authored-by: Chris Mc <prince.chrismc@gmail.com>
Co-authored-by: Chris Mc <prince.chrismc@gmail.com>
:) 🤞 |
Conan v1 pipeline ✔️All green in build 42 (
Conan v2 pipeline (informative, not required for merge) ✔️
All green in build 41 (
|
* add tinycthreadpool * Update recipes/tinycthreadpool/all/conanfile.py Co-authored-by: Chris Mc <prince.chrismc@gmail.com> * Update recipes/tinycthreadpool/all/conanfile.py Co-authored-by: Chris Mc <prince.chrismc@gmail.com> * Update recipes/tinycthreadpool/all/conanfile.py Co-authored-by: Chris Mc <prince.chrismc@gmail.com> * Update recipes/tinycthreadpool/all/conanfile.py Co-authored-by: Chris Mc <prince.chrismc@gmail.com> * Update recipes/tinycthreadpool/all/conanfile.py Co-authored-by: Chris Mc <prince.chrismc@gmail.com> * Update recipes/tinycthreadpool/all/conanfile.py Co-authored-by: Chris Mc <prince.chrismc@gmail.com> * depends on tinycthread as a library not source. * Update recipes/tinycthreadpool/all/conanfile.py Co-authored-by: Chris Mc <prince.chrismc@gmail.com> * Update recipes/tinycthreadpool/all/conanfile.py Co-authored-by: Chris Mc <prince.chrismc@gmail.com> --------- Co-authored-by: Chris Mc <prince.chrismc@gmail.com>
Specify library name and version: tinycthreadpool/1.0
This is a portable C threadpool. It is based on tinycthread and supports both Windows and POSIX systems.