Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add mbits-mstch/1.0.4 #14788

Merged
merged 3 commits into from
Dec 26, 2022
Merged

add mbits-mstch/1.0.4 #14788

merged 3 commits into from
Dec 26, 2022

Conversation

mzdun
Copy link
Contributor

@mzdun mzdun commented Dec 17, 2022

Specify library name and version: mbits-mstch/1.0.4

@mzdun mzdun marked this pull request as draft December 17, 2022 15:57
@conan-center-bot

This comment has been minimized.

Sign in to view
@mzdun mzdun marked this pull request as ready for review December 17, 2022 16:34
@github-actions github-actions bot mentioned this pull request Dec 17, 2022
Open
uilianries
uilianries previously approved these changes Dec 19, 2022
View reviewed changes
Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mzdun mzdun mentioned this pull request Dec 22, 2022
Merged
4 tasks
@mzdun mzdun requested a review from uilianries December 22, 2022 10:35
uilianries
uilianries previously approved these changes Dec 22, 2022
View reviewed changes
@conan-center-bot

This comment has been minimized.

Sign in to view
@mzdun mzdun requested a review from uilianries December 22, 2022 11:10
@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline

All green in build 3 (467eff3e30d97234355064c97ede2ff2652767b1):

  • mbits-mstch/1.0.4@:
    All packages built successfully! (All logs)

Conan v2 pipeline (informative, not required for merge)

All green in build 3 (467eff3e30d97234355064c97ede2ff2652767b1):

  • mbits-mstch/1.0.4@:
    All packages built successfully! (All logs)

uilianries
uilianries approved these changes Dec 22, 2022
View reviewed changes
Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The missing option shared is okay as the upstream only supports static. LGTM

@conan-center-bot conan-center-bot merged commit 05fbb6d into conan-io:master Dec 26, 2022
@mzdun mzdun deleted the add-libmstch branch December 27, 2022 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uilianries uilianries uilianries approved these changes

@toge toge toge approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mzdun @conan-center-bot @toge @uilianries