Use pybind11 with cmake_find_package only #1481

danimtb · 2020-04-28T12:08:30Z

Specify library name and version: pybin11/all

Try to consume pybind11 in the canonical way indicated in the documentation for CMake.

I've read the guidelines for contributing.
I've followed the PEP8 style guides for Python code in the recipes.
I've used the latest Conan client version.
I've tried at least one configuration locally with the
conan-center hook activated.

conan-center-bot · 2020-04-28T12:12:10Z

Some configurations of 'pybind11/2.4.3' failed in build 1 (168855fb868d16ac160d5723bce4ac674a08e2c1):

Linux x86_64, Release, gcc 5, libstdc++
Access to all the logs

madebr · 2020-04-28T12:25:19Z

recipes/pybind11/all/test_package/CMakeLists.txt

-include("${CMAKE_BINARY_DIR}/conanbuildinfo.cmake")
-conan_basic_setup()


Isn't the cmake helper always required to make sure that the compiler flags are set correctly?

It is not mandatory. Here I wanted to test that the package can be consumed ina transparent way with the CMake macros they provide.

It will be needed when a cpython recipe is used.
Can't the call to conan_basic_setup be moved to after the find_package?

Yes, please, leave the conan_basic_setup() call, it is our toolchain until Conan provides a proper toolchain (WIP).

conan-center-bot · 2020-04-29T10:39:34Z

Some configurations of 'pybind11/2.4.3' failed in build 2 (050470a914c997b588fa092292bac1f271c070f3):

Linux x86_64, Release, gcc 5, libstdc++
Access to all the logs

conan-center-bot · 2020-04-29T10:56:03Z

Some configurations of 'pybind11/2.4.3' failed in build 3 (ff3528f2f4b09cd08182fcc9995f9753ddee9ff7):

Linux x86_64, Release, gcc 5, libstdc++
Access to all the logs

conan-center-bot · 2020-04-29T11:34:34Z

Some configurations of 'pybind11/2.4.3' failed in build 4 (ee030bca78f63c9f92021b881f648c9e249afc79):

Linux x86_64, Release, gcc 5, libstdc++
Access to all the logs

conan-center-bot · 2020-04-29T11:57:39Z

All green in build 5 (53ae50cd54ff381b306c017513c7c85494f9d31e)! 😊

pybind11/2.4.3: Generated 1 packages. All logs here

conan-center-bot · 2020-04-29T12:06:03Z

All green in build 6 (9d9ee45e9bcde50aa20d4c9eccecad24c56a1b17)! 😊

pybind11/2.4.3: Generated 1 packages. All logs here

conan-center-bot · 2020-04-29T12:11:18Z

All green in build 7 (dec99f18caa000391fc60f0bd804e0f8f02a5695)! 😊

pybind11/2.4.3: Generated 1 packages. All logs here

conan-center-bot · 2020-04-29T13:32:47Z

All green in build 8 (e9ad5c05c077eb304f6a940d8eb7f3f88b78467b)! 😊

pybind11/2.4.3: Generated 1 packages. All logs here

conan-center-bot · 2020-04-29T13:42:21Z

Some configurations of 'pybind11/2.4.3' failed in build 9 (f4ce1e73ca51257b04f503369c93b7305be294c7):

Linux x86_64, Release, gcc 5, libstdc++
Access to all the logs

conan-center-bot · 2020-04-29T13:55:14Z

Some configurations of 'pybind11/2.4.3' failed in build 10 (0e62081835b7c5bca56ed3b12ec504d122ba9fc0):

Linux x86_64, Release, gcc 5, libstdc++
Access to all the logs

conan-center-bot · 2020-04-29T14:02:06Z

An unexpected error happened and has been reported. Help is on its way! 🏇

conan-center-bot · 2020-04-29T14:07:42Z

Some configurations of 'pybind11/2.4.3' failed in build 12 (93cd294db5c8263a73d14905b5144ecac45b3563):

Linux x86_64, Release, gcc 5, libstdc++
Access to all the logs

danimtb · 2020-04-29T14:44:46Z

recipes/pybind11/all/conanfile.py

@@ -38,6 +38,8 @@ def package(self):
        cmake.install()
        os.unlink(os.path.join(self.package_folder, "lib", "cmake", "pybind11", "pybind11Config.cmake"))
        os.unlink(os.path.join(self.package_folder, "lib", "cmake", "pybind11", "pybind11ConfigVersion.cmake"))
+        pybind11tools_path = os.path.join(self.package_folder, "lib", "cmake", "pybind11", "pybind11Tools.cmake")
+        tools.replace_in_file(pybind11tools_path, "PYBIND11_INCLUDE_DIR", "pybind11_INCLUDE_DIRS")


@jgsogo maybe this is not a good solution when consuming this package from the cmake_package_multi generator?

What I see here is that inside the file pybind11Tools we have a problem. We shouldn't use pybind11_INCLUDE_DIRS but the pybind11::pybind11 target... but it won't work if using just a cmake generator.

I only have questions here: can we use the CONAN_LIB::... target? Probably not the same name for cmake_find_package generators. Should we create always the target pybind11::pybind11 even for cmake generator? What about old CMake without targets supports (do we care about so old versions for this recipe?)?

A different way to go is add a list to different include directories (it already has a bunch of them). We can add the generator expression that works for the cmake_find_package[_multi] generator:

target_include_directories(${target_name} ${inc_isystem} PRIVATE ${pybind11_INCLUDE_DIRS} # from project CMakeLists.txt PRIVATE ${pybind11_INCLUDE_DIR} # from pybind11Config PRIVATE ${PYTHON_INCLUDE_DIRS} )

Here we have a similar problem as the one be have in the protobuf package. We need to hardcode in a file something that works for any generator that we will define afterward. Can we workaround it? Is this one reason why we need a proper deploy function with the additional install folder in the cache?

I know this is not an answer, only questions, but I need to think more about this issue.

ericriff · 2020-05-05T23:23:01Z

I'm trying to replace my locally built pybind11 with one provided by conan but I get linking errors regarding pybind11::module and pybind11::embed which are defined in pybind11Config.cmake.
Maybe we can fix it in this PR.

CMake Error at path/CMakeLists.txt:6 (add_library):
  Target "some-obj" links to target "pybind11::module" but the
  target was not found.

SSE4 · 2020-07-27T14:53:51Z

@danimtb pls rebase

danimtb · 2020-07-27T15:55:03Z

@SSE4 this was just a test/proposal and it is still not ready to be merged. I have made it a draft. Thanks

madebr · 2020-10-17T18:36:08Z

Is this pull request still alive?

danimtb · 2020-10-20T12:36:58Z

@madebr I need to give it another try. Unfortunately, we cannot remove conan_basic_setup() and the replace in file after the installation of the package is dependant on the consumer's generator.

conan-center-bot · 2020-10-23T15:17:45Z

All green in build 15 (bec34d2a4e2837b3771c73f104006f76af5e99b9)! 😊

pybind11/2.4.3: Generated 1 packages. All logs here
pybind11/2.5.0: Generated 1 packages. All logs here

ericriff · 2020-10-23T15:19:55Z

Would it be possible to also add the targets that the documentation specifies?
https://pybind11.readthedocs.io/en/stable/cmake/index.html?highlight=cmake#exported-targets
Right now the conan packages for pybind11 are not interchangeable with the official ones because of the missing targets.

conan-center-bot · 2020-10-23T15:54:28Z

All green in build 16 (ea958b0033edcaae67449a85201e82e4fdbf650d)! 😊

pybind11/2.4.3: Generated 1 packages. All logs here
pybind11/2.5.0: Generated 1 packages. All logs here

danimtb · 2020-10-26T08:59:13Z

This PR is not exaclty what I was expecting but at least we prove that the consumption of the library can be simplified and the macros of cmake work. If you think it is not relevant I am fine dropping it. Thanks!

SSE4

less code is always nice!

conan-center-bot · 2020-11-10T15:52:32Z

All green in build 17 (17bd674e61b86484d5473e12744bb93b756ca310)! 😊

pybind11/2.4.3: Generated 1 packages. All logs here
pybind11/2.5.0: Generated 1 packages. All logs here

danimtb · 2020-11-10T15:53:50Z

Seems everything works fine after the line endings change, sorry for the noise 😅

Croydon · 2020-11-10T16:44:53Z

Wow. GitHub is not removing existing approvals when an empty commit is pushed. Very smart 👍

Use pybind11 with cmake_find_package only

168855f

danimtb self-assigned this Apr 28, 2020

conan-center-bot added the Failed label Apr 28, 2020

madebr reviewed Apr 28, 2020

View reviewed changes

Additional find packages

050470a

use include

ff3528f

check macros

ee030bc

more macros

53ae50c

conan-center-bot removed the Failed label Apr 29, 2020

remove macros

9d9ee45

remove finds

dec99f1

remove find macros

e9ad5c0

remvoe output directories

f4ce1e7

conan-center-bot added the Failed label Apr 29, 2020

only runtime directory

0e62081

and lib directory

93cd294

conan-center-bot added the Unexpected Error label Apr 29, 2020

also archive

a140d5a

danimtb commented Apr 29, 2020

View reviewed changes

danimtb marked this pull request as draft July 27, 2020 15:54

danimtb added 2 commits October 23, 2020 13:01

Merge branch 'master' into feature/pybind11_build_modules

648e66b

update

bec34d2

remove replace

ea958b0

danimtb marked this pull request as ready for review October 26, 2020 08:59

SSE4 approved these changes Oct 31, 2020

View reviewed changes

prince-chrismc approved these changes Nov 6, 2020

View reviewed changes

prince-chrismc mentioned this pull request Nov 6, 2020

Update to pybind11 2.6.0 #3305

Merged

4 tasks

danimtb assigned uilianries and unassigned danimtb Nov 6, 2020

Trigger CI

17bd674

prince-chrismc approved these changes Nov 10, 2020

View reviewed changes

Croydon approved these changes Nov 10, 2020

View reviewed changes

ericLemanissier mentioned this pull request Nov 12, 2020

[service] Potentially conflicting recipes #3517

Closed

uilianries approved these changes Nov 12, 2020

View reviewed changes

conan-center-bot merged commit 05d9b79 into conan-io:master Nov 12, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use pybind11 with cmake_find_package only #1481

Use pybind11 with cmake_find_package only #1481

danimtb commented Apr 28, 2020

conan-center-bot commented Apr 28, 2020

madebr Apr 28, 2020

danimtb Apr 29, 2020

madebr Apr 29, 2020

jgsogo May 6, 2020

conan-center-bot commented Apr 29, 2020

conan-center-bot commented Apr 29, 2020

conan-center-bot commented Apr 29, 2020

conan-center-bot commented Apr 29, 2020

conan-center-bot commented Apr 29, 2020

conan-center-bot commented Apr 29, 2020

conan-center-bot commented Apr 29, 2020

conan-center-bot commented Apr 29, 2020

conan-center-bot commented Apr 29, 2020

conan-center-bot commented Apr 29, 2020

conan-center-bot commented Apr 29, 2020

danimtb Apr 29, 2020

jgsogo May 6, 2020

ericriff commented May 5, 2020 •

edited

Loading

SSE4 commented Jul 27, 2020

danimtb commented Jul 27, 2020

madebr commented Oct 17, 2020

danimtb commented Oct 20, 2020

conan-center-bot commented Oct 23, 2020

ericriff commented Oct 23, 2020 •

edited

Loading

conan-center-bot commented Oct 23, 2020

danimtb commented Oct 26, 2020

SSE4 left a comment

conan-center-bot commented Nov 10, 2020

danimtb commented Nov 10, 2020

Croydon commented Nov 10, 2020

		include("${CMAKE_BINARY_DIR}/conanbuildinfo.cmake")
		conan_basic_setup()

Use pybind11 with cmake_find_package only #1481

Use pybind11 with cmake_find_package only #1481

Conversation

danimtb commented Apr 28, 2020

conan-center-bot commented Apr 28, 2020

madebr Apr 28, 2020

Choose a reason for hiding this comment

danimtb Apr 29, 2020

Choose a reason for hiding this comment

madebr Apr 29, 2020

Choose a reason for hiding this comment

jgsogo May 6, 2020

Choose a reason for hiding this comment

conan-center-bot commented Apr 29, 2020

conan-center-bot commented Apr 29, 2020

conan-center-bot commented Apr 29, 2020

conan-center-bot commented Apr 29, 2020

conan-center-bot commented Apr 29, 2020

conan-center-bot commented Apr 29, 2020

conan-center-bot commented Apr 29, 2020

conan-center-bot commented Apr 29, 2020

conan-center-bot commented Apr 29, 2020

conan-center-bot commented Apr 29, 2020

conan-center-bot commented Apr 29, 2020

danimtb Apr 29, 2020

Choose a reason for hiding this comment

jgsogo May 6, 2020

Choose a reason for hiding this comment

ericriff commented May 5, 2020 • edited Loading

SSE4 commented Jul 27, 2020

danimtb commented Jul 27, 2020

madebr commented Oct 17, 2020

danimtb commented Oct 20, 2020

conan-center-bot commented Oct 23, 2020

ericriff commented Oct 23, 2020 • edited Loading

conan-center-bot commented Oct 23, 2020

danimtb commented Oct 26, 2020

SSE4 left a comment

Choose a reason for hiding this comment

conan-center-bot commented Nov 10, 2020

danimtb commented Nov 10, 2020

Croydon commented Nov 10, 2020

ericriff commented May 5, 2020 •

edited

Loading

ericriff commented Oct 23, 2020 •

edited

Loading