icu: validate dat package file exists

recipes/icu/all/conanfile.py

@@ -1,19 +1,28 @@
 from conan import ConanFile
 from conan.tools.apple import is_apple_os
-from conan.tools.build import cross_building
+from conan.tools.build import cross_building, stdcpp_library
 from conan.tools.env import Environment, VirtualBuildEnv
 from conan.tools.files import apply_conandata_patches, copy, export_conandata_patches, get, mkdir, rename, replace_in_file, rm, rmdir, save
 from conan.tools.gnu import Autotools, AutotoolsToolchain
+from conan.tools.gnu.get_gnu_triplet import _get_gnu_triplet # Ugly but not currently exported in Conan 2.0
 from conan.tools.layout import basic_layout
 from conan.tools.microsoft import is_msvc, unix_path
-from conan.tools.scm import Version
-from conans.tools import get_gnu_triplet, sha256sum, stdcpp_library
 import glob
 import os
 import shutil
+import hashlib
 
-required_conan_version = ">=1.53.0"
+required_conan_version = ">=1.54.0"
 
+def sha256sum(file_path):
+    with open(file_path, "rb") as fh:
+        digest = hashlib.new("sha256")
+        while True:
+            data = fh.read(8192)
+            if not data:
+                break
+            digest.update(data)
+        return digest.hexdigest()
 
 class ICUConan(ConanFile):
     name = "icu"
@@ -72,8 +81,8 @@ def layout(self):
         basic_layout(self, src_folder="src")
 
     def package_id(self):
-        if self.options.dat_package_file:
-            dat_package_file_sha256 = sha256sum(str(self.options.dat_package_file))
+        if self.info.options.dat_package_file:
+            dat_package_file_sha256 = sha256sum(str(self.info.options.dat_package_file))
             self.info.options.dat_package_file = dat_package_file_sha256
 
     def build_requirements(self):
@@ -94,8 +103,8 @@ def generate(self):
         env.generate()
 
         tc = AutotoolsToolchain(self)
-        if (self.settings.compiler == "Visual Studio" and Version(self.settings.compiler.version) >= "12") or \
-           (self.settings.compiler == "msvc" and Version(self.settings.compiler.version) >= "180"):
+        if (self.settings.get_safe("compiler") == "Visual Studio" and self.settings.get_safe("compiler.version") >= "12") or \
+           (self.settings.get_safe("compiler") == "msvc" and self.settings.get_safe("compiler.version") >= "180"):
             tc.extra_cflags.append("-FS")
             tc.extra_cxxflags.append("-FS")
         if not self.options.shared:
@@ -119,18 +128,18 @@ def generate(self):
         if cross_building(self):
             base_path = unix_path(self, self.dependencies.build["icu"].package_folder)
             tc.configure_args.append(f"--with-cross-build={base_path}")
-            if (not is_msvc(self)):
+            if not is_msvc(self):
                 # --with-cross-build above prevents tc.generate() from setting --build option.
                 # Workaround for https://github.com/conan-io/conan/issues/12642
-                gnu_triplet = get_gnu_triplet(str(self._settings_build.os), str(self._settings_build.arch), str(self.settings.compiler))
+                gnu_triplet = _get_gnu_triplet(str(self._settings_build.os), str(self._settings_build.arch), str(self.settings.compiler))
                 tc.configure_args.append(f"--build={gnu_triplet}")
             if self.settings.os in ["iOS", "tvOS", "watchOS"]:
-                gnu_triplet = get_gnu_triplet("Macos", str(self.settings.arch))
+                gnu_triplet = _get_gnu_triplet("Macos", str(self.settings.arch))
                 tc.configure_args.append(f"--host={gnu_triplet}")
             elif is_msvc(self):
                 # ICU doesn't like GNU triplet of conan for msvc (see https://github.com/conan-io/conan/issues/12546)
-                host = get_gnu_triplet(str(self.settings.os), str(self.settings.arch), "gcc")
-                build = get_gnu_triplet(str(self._settings_build.os), str(self._settings_build.arch), "gcc")
+                host = _get_gnu_triplet(str(self.settings.os), str(self.settings.arch), "gcc")
+                build = _get_gnu_triplet(str(self._settings_build.os), str(self._settings_build.arch), "gcc")
                 tc.configure_args.extend([
                     f"--host={host}",
                     f"--build={build}",
@@ -201,22 +210,21 @@ def build(self):
 
     @property
     def _data_filename(self):
-        vtag = self.version.split(".")[0]
+        vtag = str(self.version).split('.', maxsplit=1)[0]
         return f"icudt{vtag}l.dat"
 
     @property
     def _data_path(self):
         data_dir_name = "icu"
         if self.settings.os == "Windows" and self.settings.build_type == "Debug":
             data_dir_name += "d"
-        data_dir = os.path.join(self.package_folder, "lib", data_dir_name, self.version)
+        data_dir = os.path.join(self.package_folder, "lib", data_dir_name, str(self.version))
         return os.path.join(data_dir, self._data_filename)
 
     def package(self):
         copy(self, "LICENSE", src=self.source_folder, dst=os.path.join(self.package_folder, "licenses"))
         autotools = Autotools(self)
-        # TODO: replace by autotools.install() once https://github.com/conan-io/conan/issues/12153 fixed
-        autotools.install(args=[f"DESTDIR={unix_path(self, self.package_folder)}"])
+        autotools.install()
 
         dll_files = glob.glob(os.path.join(self.package_folder, "lib", "*.dll"))
         if dll_files: