-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
openssl: add embed-bitcode if tools.apple:enable_bitcode is set #15336
Conversation
This comment has been minimized.
This comment has been minimized.
7fdfb42
to
3bf2df1
Compare
I detected other pull requests that are modifying openssl/3.x.x recipe: This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
isn't bitcode already deprecated by Apple? |
yes, it's deprecated in Xcode 14, but still valid in previous Xcode versions https://developer.apple.com/documentation/Xcode-Release-Notes/xcode-14-release-notes |
It seems the error is the same @jngrb is facing in #14426, and it's not strictly related to this PR:
Should I cherry-pick his commit to here or wait for the merge of this PR? Any suggestion? |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
#16510 must have been added by mistake |
v1 is still working 🤞 |
This comment has been minimized.
This comment has been minimized.
Conan v1 pipeline ✔️All green in build 11 (
Conan v2 pipeline (informative, not required for merge) ❌
The v2 pipeline failed. Please, review the errors and note this will be required for pull requests to be merged in the near future. See details:Failure in build 11 (
Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability. |
Please do not merge master, the GitHub UI is not the same as the bot logic and it can be confusing. IT's enabled for maintaers to fix merge conflicts easily :) |
…code is set * openssl: add embed-bitcode if tools.apple:enable_bitcode is set * openssl: add embed-bitcode to watchOS * openssl: do not override CFLAGS, append instead * openssl: set bitcode in templates instead of env vars --------- Co-authored-by: Chris Mc <christopherm@jfrog.com>
…code is set * openssl: add embed-bitcode if tools.apple:enable_bitcode is set * openssl: add embed-bitcode to watchOS * openssl: do not override CFLAGS, append instead * openssl: set bitcode in templates instead of env vars --------- Co-authored-by: Chris Mc <christopherm@jfrog.com>
Specify library name and version: openssl/1.x.x and openssl/3.x.x.
Add
-fembed-bitcode
iftools.apple:enable_bitcode
is configured; only foriOS
,tvOS
, andwatchOS
.It replaces #14580, after rebasing with recent changes from master.