-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
icu: small fixes to support Conan 2.0 #15821
icu: small fixes to support Conan 2.0 #15821
Conversation
I detected other pull requests that are modifying icu/all recipe: This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there. |
host_triplet = f"{str(self.settings.arch)}-apple-darwin" | ||
build_triplet = f"{str(self._settings_build.arch)}-apple" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are they valid triplet? I mean if arch is armv8, triplet should be aarch64-apple not armv8-apple.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've tested and icu doesn't seem to complain.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed - in a config.sub
this is likely to be appear like:
| arm | arm[lb]e | arme[lb] | armv* \
so it will work as long as the build scripts don't have further conditionals on the specific arch part of the triple. ICU doesn't seem too bothered. Even when building natively on apple silicon, the arch is autodetected as arm
(and not aarch64
like a more modern config.sub
would do).
Conan v1 pipeline ✔️All green in build 1 (
Conan v2 pipeline (informative, not required for merge) ✔️
All green in build 1 ( |
* icu: fix issues with Conan 2 * icu: remove unnecessary line
Specify library name and version: icu/all
Summary of changes
str(self.ref)
to support cross-building in Conan 2icu
build system (telling the build scripts that themh-msys-msvc
config fragment is needed).Other changes
-FS
flag - this is now possible withcheck_min_vs
when passingraise_invalid=False
.Manual testing, both working correctly: