Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

exprtk: upgrade for conan v2 #15907

Merged
merged 8 commits into from
Apr 4, 2023
Merged

exprtk: upgrade for conan v2 #15907

merged 8 commits into from
Apr 4, 2023

Conversation

paulharris
Copy link
Contributor

A header-only library, so finally a simple one, thank goodness.

There is one TODO question in test_package/CMakeLists.txt
msvc requires /bigobj flag... should this be added into the conan recipe somehow?

@conan-center-bot

This comment has been minimized.

Sign in to view
@paulharris paulharris closed this Feb 13, 2023
@paulharris paulharris reopened this Feb 13, 2023
@conan-center-bot

This comment has been minimized.

Sign in to view
@github-actions github-actions bot mentioned this pull request Feb 13, 2023
Open
This was referenced Feb 14, 2023
Closed
Closed
@ghost
Copy link

ghost commented Feb 14, 2023 •
edited by ghost
Loading

I detected other pull requests that are modifying exprtk/all recipe:

This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there.

toge
toge reviewed Feb 14, 2023
View reviewed changes
@ghost ghost mentioned this pull request Feb 15, 2023
Merged
@ArashPartow
Copy link
Contributor

@toge can this PR be closed as I've already set one up here:

#16035

@paulharris
Copy link
Contributor Author

@toge can this PR be closed as I've already set one up here:

#16035

Actually, no, this recipe upgrades compatibility for conan-v2,
yours just bumped the latest version.

So I'll merge yours and continue this PR

@paulharris
Copy link
Contributor Author

@toge @ArashPartow please review :)

@conan-center-bot

This comment has been minimized.

Sign in to view
@paulharris @toge
Update recipes/exprtk/all/conanfile.py
54a4d6f 
Co-authored-by: toge <toge.mail@gmail.com>
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
prince-chrismc
prince-chrismc reviewed Mar 31, 2023
View reviewed changes
recipes/exprtk/all/test_package/CMakeLists.txt
Comment on lines +13 to +14
# TODO should this be something added into conan recipe?
target_compile_options(${PROJECT_NAME} PRIVATE "/bigobj")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally not, it's possible to use a smaller peice of the lirbary and then you would not want to pay the performance penalty ... doing a quick search it's never exposed

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/bigobj is required for MSVC compiler to not die when building.
It may always be required to use this particular library, I'm not sure.
I'll leave it out of the recipe, but in the test_package (otherwise it won't build)

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 9 (644edb77242a093ad5acdcbb6c69b6d3ee68da63):

  • exprtk/0.0.2@:
    All packages built successfully! (All logs)

  • exprtk/0.0.1@:
    All packages built successfully! (All logs)

Conan v2 pipeline (informative, not required for merge) ✔️

Note: Conan v2 builds are informative and they are not required for the PR to be merged.

All green in build 10 (644edb77242a093ad5acdcbb6c69b6d3ee68da63):

  • exprtk/0.0.2@:
    All packages built successfully! (All logs)

  • exprtk/0.0.1@:
    All packages built successfully! (All logs)

@prince-chrismc
Copy link
Contributor

Please dont merge master unless there are merge conflicts since the github UI does not match the bots logic it gets a bit confusing

@paulharris
Copy link
Contributor Author

Please dont merge master unless there are merge conflicts since the github UI does not match the bots logic it gets a bit confusing

Ah ok, that isn't clear from that button.

@conan-center-bot conan-center-bot merged commit 4eff57e into conan-io:master Apr 4, 2023
@paulharris paulharris deleted the exprtk-conan-v2 branch April 4, 2023 14:46
pezy pushed a commit to pezy/conan-center-index that referenced this pull request Apr 7, 2023
@paulharris @toge @pezy
(conan-io#15907) exprtk: upgrade for conan v2
e43f687 
* exprtk: upgrade for conan v2

* Update recipes/exprtk/all/conanfile.py

Co-authored-by: toge <toge.mail@gmail.com>

* Update recipes/exprtk/all/conanfile.py

Co-authored-by: toge <toge.mail@gmail.com>

* Require C++11 as minimum

* Update recipes/exprtk/all/conanfile.py

Co-authored-by: toge <toge.mail@gmail.com>

---------

Co-authored-by: toge <toge.mail@gmail.com>
MartinDelille pushed a commit to MartinDelille/conan-center-index that referenced this pull request Apr 12, 2023
@paulharris @toge @MartinDelille
(conan-io#15907) exprtk: upgrade for conan v2
83a7c9d 
* exprtk: upgrade for conan v2

* Update recipes/exprtk/all/conanfile.py

Co-authored-by: toge <toge.mail@gmail.com>

* Update recipes/exprtk/all/conanfile.py

Co-authored-by: toge <toge.mail@gmail.com>

* Require C++11 as minimum

* Update recipes/exprtk/all/conanfile.py

Co-authored-by: toge <toge.mail@gmail.com>

---------

Co-authored-by: toge <toge.mail@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@toge toge toge left review comments

@SSE4 SSE4 SSE4 approved these changes

@prince-chrismc prince-chrismc prince-chrismc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@paulharris @conan-center-bot @ArashPartow @prince-chrismc @toge @SSE4