-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pkgconf: update to support Conan 2.0 #15990
Conversation
This comment has been minimized.
This comment has been minimized.
I detected other pull requests that are modifying pkgconf/all recipe: This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there. |
Conan v1 pipeline ✔️All green in build 4 (
Conan v2 pipeline (informative, not required for merge) ❌
The v2 pipeline failed. Please, review the errors and note this will be required for pull requests to be merged in the near future. See details:Failure in build 4 (
Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Great job 👏
if cross_building(self): | ||
raise ConanInvalidConfiguration("Cross-building is not implemented in the recipe, contributions welcome.") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But cross-build should be ok with the migration to MesonToolchain.
Specify library name and version: pkgconf/all
Summary of changes
Meson
andMesontoolchain
)_sharedstatedir
internal property - tested against all supported versions of the recipe and seems to make no difference in the packaged artifactsMeson
/MesonToolchain
The test package is slightly refactored for v2:
libexample1.pc
directly during the same step that executes autoreconf+configure on a small autotools project