Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkgconf: update to support Conan 2.0 #15990

Merged
merged 5 commits into from
Feb 15, 2023

Conversation

jcar87
Copy link
Contributor

@jcar87 jcar87 commented Feb 13, 2023

Specify library name and version: pkgconf/all

Summary of changes

  • Use newer integrations to build (Meson and Mesontoolchain)
  • General update to use tools compatible with Conan 2.0
  • Update meson build time requirement to Meson 1.0.0
  • Remove _sharedstatedir internal property - tested against all supported versions of the recipe and seems to make no difference in the packaged artifacts
  • vcvars istantiation is no longer needed as it is now implicitly done by Meson/MesonToolchain

The test package is slightly refactored for v2:

  • Test integration of finding libexample1.pc directly during the same step that executes autoreconf+configure on a small autotools project
  • Use cmake target generated by CMake deps, rather than legacy integration

@conan-center-bot

This comment has been minimized.

@ghost
Copy link

ghost commented Feb 13, 2023

I detected other pull requests that are modifying pkgconf/all recipe:

This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there.

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 4 (f0d3f18cc2c770fa970d8169bcf7b3af17eb7282):

  • pkgconf/1.7.4@:
    All packages built successfully! (All logs)

  • pkgconf/1.9.3@:
    All packages built successfully! (All logs)

  • pkgconf/1.7.3@:
    All packages built successfully! (All logs)


Conan v2 pipeline (informative, not required for merge) ❌

Note: Conan v2 builds are informative and they are not required for the PR to be merged.

The v2 pipeline failed. Please, review the errors and note this will be required for pull requests to be merged in the near future.

See details:

Failure in build 4 (f0d3f18cc2c770fa970d8169bcf7b3af17eb7282):

  • pkgconf/1.9.3@:
    Didn't run or was cancelled before finishing

  • pkgconf/1.7.4@:
    Didn't run or was cancelled before finishing

  • pkgconf/1.7.3@:
    CI failed to create some packages (All logs)

    Logs for packageID 8b5cf1367c351fd3c60ef4e28c1a50612761b13e:
    [settings]
    arch=x86_64
    build_type=Release
    compiler=apple-clang
    compiler.libcxx=libc++
    compiler.version=13
    os=Macos
    [options]
    */*:shared=False
    
    [...]
    
    -------- Computing dependency graph --------
    meson/1.0.0: Not found in local cache, looking in remotes...
    meson/1.0.0: Checking remote: conan-center-v2
    meson/1.0.0: Trying with 'conan-center-v2'...
    Downloading conanfile.py
    Downloading conan_export.tgz
    Downloading conanmanifest.txt
    Decompressing conan_export.tgz
    meson/1.0.0: Downloaded recipe revision 15586c0ac6f682805875ef903dbe7ee2
    ninja/1.11.1: Not found in local cache, looking in remotes...
    ninja/1.11.1: Checking remote: conan-center-v2
    ninja/1.11.1: Trying with 'conan-center-v2'...
    Downloading conanmanifest.txt
    Downloading conanfile.py
    Downloading conan_export.tgz
    Decompressing conan_export.tgz
    ninja/1.11.1: Downloaded recipe revision a2f0b832705907016f336839f96963f8
    Graph root
        virtual
    Requirements
        pkgconf/1.7.3#f592096d71575558ab456ce6af9db7ac - Cache
    Build requirements
        meson/1.0.0#15586c0ac6f682805875ef903dbe7ee2 - Downloaded (conan-center-v2)
        ninja/1.11.1#a2f0b832705907016f336839f96963f8 - Downloaded (conan-center-v2)
    
    -------- Computing necessary packages --------
    pkgconf/1.7.3: Forced build from source
    Requirements
        pkgconf/1.7.3#f592096d71575558ab456ce6af9db7ac:8b5cf1367c351fd3c60ef4e28c1a50612761b13e - Build
    Build requirements
        meson/1.0.0#15586c0ac6f682805875ef903dbe7ee2:da39a3ee5e6b4b0d3255bfef95601890afd80709#5c8fd51fc33f12e26519674d99afd0e5 - Download (conan-center-v2)
        ninja/1.11.1#a2f0b832705907016f336839f96963f8:9ac8640923e5284645f8852ef8ba335654f4020e - Missing
    
    -------- Installing packages --------
    
    -------- Installing (downloading, building) binaries... --------
    ERROR: Missing binary: ninja/1.11.1:9ac8640923e5284645f8852ef8ba335654f4020e
    
    ninja/1.11.1: WARN: Can't find a 'ninja/1.11.1' package binary '9ac8640923e5284645f8852ef8ba335654f4020e' for the configuration:
    [settings]
    arch=x86_64
    build_type=Release
    os=Macos
    
    ERROR: Missing prebuilt package for 'ninja/1.11.1'
    Use 'conan list packages ninja/1.11.1 --format=html -r=remote > table.html' and open the table.html file to see available packages
    Or try to build locally from sources with '--build=ninja/1.11.1'
    
    More Info at 'https://docs.conan.io/en/latest/faq/troubleshooting.html#error-missing-prebuilt-package'
    

Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.

@jcar87 jcar87 marked this pull request as ready for review February 13, 2023 18:32
Copy link
Contributor

@franramirez688 franramirez688 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Great job 👏

Comment on lines +57 to +58
if cross_building(self):
raise ConanInvalidConfiguration("Cross-building is not implemented in the recipe, contributions welcome.")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But cross-build should be ok with the migration to MesonToolchain.

@danimtb danimtb merged commit 892b44b into conan-io:master Feb 15, 2023
@jcar87 jcar87 deleted the lcc/feature/pkgconf-conanv2 branch February 15, 2023 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants