-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
arrow: add version 12.0.0 #17540
arrow: add version 12.0.0 #17540
Conversation
I detected other pull requests that are modifying arrow/all recipe:
This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot!
I have one comment regarding the option deletion, but the rest looks good!
This comment has been minimized.
This comment has been minimized.
f475a2c
to
6790155
Compare
@RubenRBS do you know if there's anything else to be done here? I can't see the CI checks that errored, I get a 403 Forbidden on these links: |
The error is before the build so the bot is not posting the logs :) But they do show up in the report by the bot in v2. The error is:
|
@RubenRBS this seems to have been happening in the past too, see:
Should we fix that on a different PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the conan 2 build error should be fixed in a different PR and this one is good as is.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's fix the issue in another PR as @mpimenov mentioned! :) Thanks a lot for your patience
Conan v1 pipeline ✔️All green in build 3 (
Conan v2 pipeline ❌
The v2 pipeline failed. Please, review the errors and note this will be required for pull requests to be merged in the near future. See details:Failure in build 3 (
Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability. |
I think we got this part wrong in conan-io#17540 I'm not sure if this name stays (see apache/arrow#15280) but currently the file being created is libarrow_acero.a I'm not sure what to do with names of other components, such as pkg_config: for arrow_substrait we prepend "arrow_" everywhere, for "arrow_flight_sql" we do not. I've chosen to make the smallest possible diff that I am sure about.
I think we got this part wrong in conan-io#17540 I'm not sure if this name stays (see apache/arrow#15280) but currently the file being created is libarrow_acero.a I'm not sure what to do with names of other components, such as pkg_config: for arrow_substrait we prepend "arrow_" everywhere, for "arrow_flight_sql" we do not. I've chosen to make the smallest possible diff that I am sure about.
I think we got this part wrong in conan-io#17540 It's not clear if this name stays (see apache/arrow#15280) but currently the file being created is libarrow_acero.a I'm not certain what to do with names of other components, such as pkg_config: for arrow_substrait we prepend "arrow_" everywhere, for "arrow_flight_sql" we do not. I've chosen to make the smallest possible diff that I am sure about.
I think we got this part wrong in #17540 It's not clear if this name stays (see apache/arrow#15280) but currently the file being created is libarrow_acero.a I'm not certain what to do with names of other components, such as pkg_config: for arrow_substrait we prepend "arrow_" everywhere, for "arrow_flight_sql" we do not. I've chosen to make the smallest possible diff that I am sure about. Co-authored-by: James <james@conan.io>
I think we got this part wrong in conan-io#17540 It's not clear if this name stays (see apache/arrow#15280) but currently the file being created is libarrow_acero.a I'm not certain what to do with names of other components, such as pkg_config: for arrow_substrait we prepend "arrow_" everywhere, for "arrow_flight_sql" we do not. I've chosen to make the smallest possible diff that I am sure about. Co-authored-by: James <james@conan.io>
I think we got this part wrong in conan-io#17540 It's not clear if this name stays (see apache/arrow#15280) but currently the file being created is libarrow_acero.a I'm not certain what to do with names of other components, such as pkg_config: for arrow_substrait we prepend "arrow_" everywhere, for "arrow_flight_sql" we do not. I've chosen to make the smallest possible diff that I am sure about. Co-authored-by: James <james@conan.io>
Specify library name and version: arrow/12.0.0
On the Arrow 12.0.0 release PLASMA was removed and ACERO was moved to its own shared library.