Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[onetbb] added tbbbind (via hwloc) support #17939

Merged
merged 1 commit into from
Aug 9, 2023
Merged

[onetbb] added tbbbind (via hwloc) support #17939

merged 1 commit into from
Aug 9, 2023

Conversation

ilya-lavrenov
Copy link
Contributor

@ilya-lavrenov ilya-lavrenov commented Jun 15, 2023 •
edited
Loading

Specify library name and version: onetbb/2021.9.0

Description: This PR is submitted as a continuation of adding hwloc library. With adding hwloc as a dependency, TBB provides extra plugin library which provides abilities to detect information about system topology such as number of NUMA nodes, number of P / E cores on CPU.

Details of implementation:

  • TBB does not support TBBBind library when TBB is built statically (just not implemented in TBB itself)
  • TBB has extra cmake option TBB_DISABLE_HWLOC_AUTOMATIC_SEARCH to control whether HWLOC should be automatically found by pkg-config, but available only since 2021.4. Created patch to have an unified recipe without a lot of conditions which are version dependent.
  • Before 2021 major release, TBB does not support HWLOC (no TBBBind is created)
  • TBBBind library does not need to be added into package_info section, because it's a plugin and loaded in runtime.
  • It's good to enable such option by default, because it's aligned with TBB behavior and allows users to use the library ready for all types of processors out of box.

Hope, these notes can help reviewers.

@ilya-lavrenov ilya-lavrenov marked this pull request as draft June 15, 2023 09:02
@conan-center-bot

This comment has been minimized.

Sign in to view
@ghost
Copy link

ghost commented Jun 15, 2023 •
edited by ghost
Loading

I detected other pull requests that are modifying onetbb/all recipe:

This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there.

This was referenced Jun 15, 2023
Closed
Closed
@ilya-lavrenov ilya-lavrenov changed the title [onetbb] added hwloc / tbbbind support [onetbb] added tbbbind (via hwloc) support Jun 15, 2023
@ilya-lavrenov ilya-lavrenov force-pushed the tbbbind branch 3 times, most recently from 7ee6c66 to 0c883e0 Compare June 15, 2023 10:02
@conan-center-bot

This comment has been minimized.

Sign in to view
@ilya-lavrenov ilya-lavrenov mentioned this pull request Jun 15, 2023
Closed
This was referenced Jun 15, 2023
Open
Closed
@ilya-lavrenov ilya-lavrenov force-pushed the tbbbind branch 2 times, most recently from 6d1c109 to 5f7e282 Compare June 15, 2023 13:45
@conan-center-bot

This comment has been minimized.

Sign in to view
@ericLemanissier ericLemanissier mentioned this pull request Jun 15, 2023
Closed
@conan-center-bot

This comment has been minimized.

Sign in to view
@ilya-lavrenov ilya-lavrenov force-pushed the tbbbind branch 5 times, most recently from 55fe1b8 to ec65e1f Compare June 15, 2023 14:12
@conan-center-bot

This comment has been minimized.

Sign in to view
@prince-chrismc prince-chrismc mentioned this pull request Jul 10, 2023
Open
@conan-center-bot

This comment has been minimized.

Sign in to view
@ilya-lavrenov
Copy link
Contributor Author

Hi @jcar87,
Could you please review and invite other people who can provide review?
Thanks in advance.

@ilya-lavrenov
Copy link
Contributor Author

Hi @jcar87 @uilianries @RubenRBS
Could you please review?

This was referenced Jul 18, 2023
Merged
Closed
@ilya-lavrenov
Copy link
Contributor Author

ping. Please, have a look.

@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@ghost ghost mentioned this pull request Aug 3, 2023
Merged
3 tasks
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 5 (5cb6c57fabb49825282d3ae1854b8a090e20bf70):

  • onetbb/2021.9.0@:
    All packages built successfully! (All logs)

  • onetbb/2021.8.0@:
    All packages built successfully! (All logs)

  • onetbb/2021.7.0@:
    All packages built successfully! (All logs)

  • onetbb/2021.3.0@:
    All packages built successfully! (All logs)

  • onetbb/2021.6.0@:
    All packages built successfully! (All logs)

Conan v2 pipeline ✔️

Note: Conan v2 builds may be required once they are on the v2 ready list

All green in build 5 (5cb6c57fabb49825282d3ae1854b8a090e20bf70):

  • onetbb/2021.9.0@:
    All packages built successfully! (All logs)

  • onetbb/2021.8.0@:
    All packages built successfully! (All logs)

  • onetbb/2021.6.0@:
    All packages built successfully! (All logs)

  • onetbb/2021.3.0@:
    All packages built successfully! (All logs)

  • onetbb/2021.7.0@:
    All packages built successfully! (All logs)

@uilianries uilianries requested a review from jcar87 August 7, 2023 08:09
@ilya-lavrenov
Copy link
Contributor Author

@jcar87 @RubenRBS @uilianries please, have a look

uilianries
uilianries approved these changes Aug 9, 2023
View reviewed changes
Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Besides the new rule for invalid configuration, it will not block current configuration. Plus, the new patch is available in the upstream.

@jcar87 jcar87 merged commit e05300c into conan-io:master Aug 9, 2023
@ilya-lavrenov ilya-lavrenov deleted the tbbbind branch August 9, 2023 11:41
datalogics-kam added a commit to datalogics-kam/conan-center-index that referenced this pull request Aug 9, 2023
@datalogics-kam
Merge branch 'master' of github.com:conan-io/conan-center-index into …
5f4c128 
…cmake-combined-recipe

* 'master' of github.com:conan-io/conan-center-index: (228 commits)
  (conan-io#19117) librttopo: bump geos
  (conan-io#19019) sqlitecpp: bump sqlite3 3.42.0
  (conan-io#19092) [sentry-breakpad] Replace _patch_sources by patches
  (conan-io#19054) simdutf: add version 3.2.15, remove older versions, remove unused patch
  (conan-io#18769) Add capnproto/0.10.4
  cargs: migrate to Conan v2 (conan-io#18704)
  uwebsockets: add version 20.45.0 (conan-io#19047)
  fontconfig: minimal change to ensure most recent rrev (conan-io#19114)
  [onetbb] added hwloc / tbbbind support (conan-io#17939)
  leptonica: add version 1.83.1, update libjpeg-turbo (conan-io#19101)
  Update list of references (prod-v2/ListPackages) (conan-io#19109)
  libcurl: add version 8.2.1 (conan-io#18923)
  [xapian-core] Use util-linux-libuuid instead of deprecated libuuid (conan-io#18551)
  [stduuid] Use util-linux-libuuid instead of deprecated libuuid (conan-io#18549)
  [fontconfig] Use util-linux-libuuid instead of deprecated libuuid (conan-io#18550)
  [drogon] Use util-linux-libuuid instead of deprecated libuuid (conan-io#18555)
  [czmq] Use util-linux-libuuid instead of deprecated libuuid (conan-io#18552)
  [cppcommon] Use util-linux-libuuid instead of deprecated libuuid (conan-io#18553)
  [azure-storage-cpp] Use util-linux-libuuid instead of deprecated libuuid (conan-io#18557)
  [aaf] Use util-linux-libuuid instead of deprecated libuuid (conan-io#18556)
  ...
@SpaceIm SpaceIm mentioned this pull request Aug 13, 2023
Closed
ericLemanissier pushed a commit to ericLemanissier/conan-center-index that referenced this pull request Sep 15, 2023
@ilya-lavrenov @ericLemanissier
[onetbb] added hwloc / tbbbind support (conan-io#17939)
65a5010
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AbrilRBS AbrilRBS AbrilRBS approved these changes

@uilianries uilianries uilianries approved these changes

@jcar87 jcar87 Awaiting requested review from jcar87

Assignees

@jcar87 jcar87

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ilya-lavrenov @conan-center-bot @jcar87 @uilianries @AbrilRBS