-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
libtiff: allow using zlib-ng instead of zlib #18289
Conversation
This comment has been minimized.
This comment has been minimized.
@@ -24,7 +24,7 @@ class LibtiffConan(ConanFile): | |||
"fPIC": [True, False], | |||
"lzma": [True, False], | |||
"jpeg": [False, "libjpeg", "libjpeg-turbo", "mozjpeg"], | |||
"zlib": [True, False], | |||
"zlib": [False, "zlib", "zlib-ng"], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change will break users that had zlib=True
option defined. I'd try to leave it True with meaning "zlib" and just add the new one.
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
Conan v1 pipeline ✔️All green in build 2 (
Conan v2 pipeline ✔️
All green in build 2 ( |
Hi @Nekto89 thanks a lot for your patience - These PRs got put on hold while we could think about ways to have this be used more generally, supported within the Conan client itself. There's now a PR conan-io/conan#14871 (We might or might not end up merging it, we're still in the thinking and discussion phase) that would introduce the possibility for users to do these kinds of substitutions in a global way, without the need to modify the recipes. If the feature does not go forward we'll then revisit the PRs, so either way, thanks a lot for your contribution :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, except for the backwards-compatibility concern mentioned by memsharded.
Hi @RubenRBS https://blog.conan.io/2024/02/20/Conan-2-graph-features.html Should I close PRs with zlib-ng option? Is it something that should be completely on user side with new |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This pull request has been automatically closed because it has not had recent activity. Thank you for your contributions. |
Specify library name and version: libtiff/all
zlib-ng provides better performance.