Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libtiff: allow using zlib-ng instead of zlib #18289

Closed
wants to merge 1 commit into from

Conversation

Nekto89
Copy link
Contributor

@Nekto89 Nekto89 commented Jul 2, 2023

Specify library name and version: libtiff/all

zlib-ng provides better performance.


@conan-center-bot

This comment has been minimized.

@Nekto89 Nekto89 marked this pull request as draft July 4, 2023 17:17
@@ -24,7 +24,7 @@ class LibtiffConan(ConanFile):
"fPIC": [True, False],
"lzma": [True, False],
"jpeg": [False, "libjpeg", "libjpeg-turbo", "mozjpeg"],
"zlib": [True, False],
"zlib": [False, "zlib", "zlib-ng"],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change will break users that had zlib=True option defined. I'd try to leave it True with meaning "zlib" and just add the new one.

@conan-center-bot

This comment has been minimized.

1 similar comment
@conan-center-bot

This comment has been minimized.

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 2 (24b47af412e983b7518526ce393108db67b08e45):

  • libtiff/4.5.1@:
    All packages built successfully! (All logs)

  • libtiff/4.3.0@:
    All packages built successfully! (All logs)

  • libtiff/4.4.0@:
    All packages built successfully! (All logs)

  • libtiff/4.5.0@:
    All packages built successfully! (All logs)


Conan v2 pipeline ✔️

Note: Conan v2 builds may be required once they are on the v2 ready list

All green in build 2 (24b47af412e983b7518526ce393108db67b08e45):

  • libtiff/4.4.0@:
    All packages built successfully! (All logs)

  • libtiff/4.5.0@:
    All packages built successfully! (All logs)

  • libtiff/4.5.1@:
    All packages built successfully! (All logs)

  • libtiff/4.3.0@:
    All packages built successfully! (All logs)

@AbrilRBS
Copy link
Member

AbrilRBS commented Oct 5, 2023

Hi @Nekto89 thanks a lot for your patience - These PRs got put on hold while we could think about ways to have this be used more generally, supported within the Conan client itself.

There's now a PR conan-io/conan#14871 (We might or might not end up merging it, we're still in the thinking and discussion phase) that would introduce the possibility for users to do these kinds of substitutions in a global way, without the need to modify the recipes.

If the feature does not go forward we'll then revisit the PRs, so either way, thanks a lot for your contribution :)

@AbrilRBS AbrilRBS self-assigned this Oct 5, 2023
@ghost ghost mentioned this pull request Dec 1, 2023
3 tasks
@ghost ghost mentioned this pull request Jan 2, 2024
3 tasks
@ghost ghost mentioned this pull request Feb 2, 2024
3 tasks
Copy link
Contributor

@valgur valgur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, except for the backwards-compatibility concern mentioned by memsharded.

@ghost ghost mentioned this pull request Mar 22, 2024
@Nekto89
Copy link
Contributor Author

Nekto89 commented Mar 25, 2024

Hi @Nekto89 thanks a lot for your patience - These PRs got put on hold while we could think about ways to have this be used more generally, supported within the Conan client itself.

There's now a PR conan-io/conan#14871 (We might or might not end up merging it, we're still in the thinking and discussion phase) that would introduce the possibility for users to do these kinds of substitutions in a global way, without the need to modify the recipes.

If the feature does not go forward we'll then revisit the PRs, so either way, thanks a lot for your contribution :)

Hi @RubenRBS

https://blog.conan.io/2024/02/20/Conan-2-graph-features.html

Should I close PRs with zlib-ng option? Is it something that should be completely on user side with new [replace_requires]? What about check of zlib_ng.options.zlib_compat option? How to implement it in case of [replace_requires] usage?

Copy link
Contributor

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label Apr 25, 2024
Copy link
Contributor

This pull request has been automatically closed because it has not had recent activity. Thank you for your contributions.

@github-actions github-actions bot closed this May 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants