Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kcov: migrate to Conan v2 #18672

Merged
merged 12 commits into from
Jun 17, 2024
Merged

kcov: migrate to Conan v2 #18672

merged 12 commits into from
Jun 17, 2024

Conversation

valgur
Copy link
Contributor

@valgur valgur commented Jul 19, 2023 •
edited by franramirez688
Loading

@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@valgur
Copy link
Contributor Author

valgur commented Jul 26, 2023

Closing temporarily to avoid unnecessary load on the CI. Will reopen when I'm actively working on the PR again.

@valgur valgur closed this Jul 26, 2023
@valgur valgur reopened this Aug 10, 2023
@conan-center-bot

This comment has been minimized.

Sign in to view
@stale
Copy link

stale bot commented Sep 17, 2023

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added stale and removed stale labels Sep 17, 2023
@valgur valgur marked this pull request as ready for review September 18, 2023 15:20
@conan-center-bot

This comment has been minimized.

Sign in to view
@valgur valgur mentioned this pull request Nov 8, 2023
Open
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@valgur
Copy link
Contributor Author

valgur commented Nov 27, 2023

Requires #21165.

@mayeut mayeut mentioned this pull request Dec 3, 2023
Merged
3 tasks
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@prince-chrismc prince-chrismc mentioned this pull request Jan 23, 2024
Open
@AbrilRBS AbrilRBS self-assigned this Apr 15, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 1, 2024

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label Jun 1, 2024
@conan-center-bot

This comment has been minimized.

Sign in to view
1 similar comment
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 4 (1b665da9f5a873581bf449cb786530801ccf95fa):

  • kcov/38:
    All packages built successfully! (All logs)

  • kcov/42:
    All packages built successfully! (All logs)

  • kcov/40:
    All packages built successfully! (All logs)

Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 4 (1b665da9f5a873581bf449cb786530801ccf95fa):

  • kcov/42:
    All packages built successfully! (All logs)

  • kcov/40:
    All packages built successfully! (All logs)

  • kcov/38:
    All packages built successfully! (All logs)

uilianries
uilianries approved these changes Jun 12, 2024
View reviewed changes
Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. About the adjusted variables, it could be a PR to the upstream, changing to use CMake targets instead :)

@uilianries uilianries requested a review from ErniGH June 12, 2024 07:31
perseoGI
perseoGI approved these changes Jun 12, 2024
View reviewed changes
Copy link
Contributor

@perseoGI perseoGI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

AbrilRBS
AbrilRBS approved these changes Jun 17, 2024
View reviewed changes
Copy link
Member

@AbrilRBS AbrilRBS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@conan-center-bot conan-center-bot merged commit 789662c into conan-io:master Jun 17, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uilianries uilianries uilianries approved these changes

@AbrilRBS AbrilRBS AbrilRBS approved these changes

@jwillikers jwillikers jwillikers approved these changes

@perseoGI perseoGI perseoGI approved these changes

@franramirez688 franramirez688 Awaiting requested review from franramirez688

@ErniGH ErniGH Awaiting requested review from ErniGH

Assignees

@AbrilRBS AbrilRBS

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@valgur @conan-center-bot @uilianries @AbrilRBS @jwillikers @perseoGI