scc: migrate to Conan v2 #18715
Merged
scc: migrate to Conan v2 #18715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
I am working on this, but still work to do. This PR is beyond 2.0 support, because it is fixing the previous recursive installation of packages hardcoded in scc CMakeLists.txt. I have hit the issue that |
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
conan-center-bot
added
Missing dependencies
This comment has been minimized.
This comment has been minimized.
conan-center-bot
removed
the
Version conflict
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
memsharded
reviewed
May 27, 2024
memsharded
reviewed
May 27, 2024
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Conan v1 pipeline ✔️All green in build 1 (
Conan v2 pipeline ✔️
All green in build 1 (
|
memsharded
approved these changes
Jul 1, 2024
| template<typename T> | ||
| inline void vcdEmitValueChangeReal(FPTR os, std::string const& handle, unsigned bits, T val){ | ||
| - auto buf = fmt::format("r{:.16g} {}\n", val, handle); | ||
| + auto buf = fmt::format("r{:.16g} {}\n", static_cast<double>(val), handle); |
There was a problem hiding this comment.
This has been merged upstream in Minres/SystemC-Components#51 and released in https://github.com/Minres/SystemC-Components/releases/tag/2024.03
AbrilRBS
approved these changes
Jul 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.