Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

qxmpp: migrate to Conan v2 #18743

Merged
merged 14 commits into from
Jun 24, 2024
Merged

qxmpp: migrate to Conan v2 #18743

merged 14 commits into from
Jun 24, 2024

Conversation

valgur
Copy link
Contributor

@valgur valgur commented Jul 20, 2023 •
edited
Loading

No description provided.

@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@valgur
Copy link
Contributor Author

valgur commented Jul 26, 2023

Closing temporarily to avoid unnecessary load on the CI. Will reopen when I'm actively working on the PR again.

@valgur valgur closed this Jul 26, 2023
@valgur valgur reopened this Aug 11, 2023
@conan-center-bot

This comment has been minimized.

Sign in to view
@stale
Copy link

stale bot commented Sep 17, 2023

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Sep 17, 2023
@valgur valgur marked this pull request as ready for review September 20, 2023 12:39
@stale stale bot removed the stale label Sep 20, 2023
@conan-center-bot

This comment has been minimized.

Sign in to view
@github-actions
Copy link
Contributor

Hooks produced the following warnings for commit 828a492
qxmpp/1.4.0@#6a014b324991b9f46f86a6d55cc5e8ec 
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libqxmpp.1.4.0.dylib' links to system library 'CFNetwork' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libqxmpp.dylib' links to system library 'CFNetwork' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libqxmpp.3.dylib' links to system library 'CFNetwork' but it is not in cpp_info.frameworks.

@valgur valgur mentioned this pull request Nov 8, 2023
Open
@conan-center-bot

This comment has been minimized.

Sign in to view
@stale Stale
Copy link

stale bot commented Dec 15, 2023

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@uilianries
Safe shared option value
7f17e04 
Signed-off-by: Uilian Ries <uilianries@gmail.com>
uilianries
uilianries previously approved these changes Jun 20, 2024
View reviewed changes
@uilianries
Accept Qt5
23f8fd8 
Signed-off-by: Uilian Ries <uilianries@gmail.com>
@conan-center-bot

This comment has been minimized.

Sign in to view
@uilianries uilianries marked this pull request as draft June 20, 2024 16:09
@conan-center-bot

This comment has been minimized.

Sign in to view
@uilianries
Fix Windows build
be8ff8a 
Signed-off-by: Uilian Ries <uilianries@gmail.com>
@uilianries
Copy link
Member

Built on Windows without exporting symbols using CMake: https://gist.github.com/uilianries/2205760389c47f99f6458477b5d33c52#file-windows-msvc-193-log

@uilianries uilianries marked this pull request as ready for review June 21, 2024 07:57
@conan-center-bot

This comment has been minimized.

Sign in to view
@uilianries
Support both Qt versions in patch
b59207d 
Signed-off-by: Uilian Ries <uilianries@gmail.com>
@conan-center-bot

This comment has been minimized.

Sign in to view
@uilianries
Add Qt as build requirement
e6e029f 
Signed-off-by: Uilian Ries <uilianries@gmail.com>
@conan-center-bot

This comment has been minimized.

Sign in to view
@uilianries
Add VirtualRunEnv
9ab50b9 
Signed-off-by: Uilian Ries <uilianries@gmail.com>
@uilianries @AbrilRBS
Update recipes/qxmpp/all/conanfile.py
d7184db 
Co-authored-by: Abril Rincón Blanco <git@rinconblanco.es>
@conan-center-bot

This comment has been minimized.

Sign in to view
@uilianries
Fix required version syntax
3f7c977 
Signed-off-by: Uilian Ries <uilianries@gmail.com>
@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 10 (3f7c9778e778de79bdd639ad72c530371ac0e155):

  • qxmpp/1.4.0:
    All packages built successfully! (All logs)

Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 10 (3f7c9778e778de79bdd639ad72c530371ac0e155):

  • qxmpp/1.4.0:
    All packages built successfully! (All logs)

@uilianries uilianries requested a review from AbrilRBS June 24, 2024 14:10
uilianries
uilianries approved these changes Jun 24, 2024
View reviewed changes
Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@conan-center-bot conan-center-bot merged commit 33ca2ea into conan-io:master Jun 24, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AbrilRBS AbrilRBS AbrilRBS approved these changes

@uilianries uilianries uilianries approved these changes

@jcar87 jcar87 Awaiting requested review from jcar87

Assignees

@uilianries uilianries

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@valgur @conan-center-bot @uilianries @AbrilRBS