Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pagmo2: migrate to Conan v2 #18820

Merged
merged 8 commits into from
Jul 3, 2024
Merged

pagmo2: migrate to Conan v2 #18820

merged 8 commits into from
Jul 3, 2024

Conversation

valgur
Copy link
Contributor

@valgur valgur commented Jul 22, 2023

No description provided.

@prince-chrismc prince-chrismc mentioned this pull request Jul 22, 2023
Open
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@valgur
Copy link
Contributor Author

valgur commented Jul 26, 2023

Closing temporarily to avoid unnecessary load on the CI. Will reopen when I'm actively working on the PR again.

@valgur valgur closed this Jul 26, 2023
@valgur valgur reopened this Aug 17, 2023
@conan-center-bot

This comment has been minimized.

Sign in to view
@stale
Copy link

stale bot commented Sep 17, 2023

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Sep 17, 2023
@valgur valgur closed this Sep 17, 2023
@valgur valgur reopened this Sep 17, 2023
@stale stale bot removed the stale label Sep 17, 2023
@conan-center-bot

This comment has been minimized.

Sign in to view
@valgur valgur force-pushed the migrate/pagmo2 branch 2 times, most recently from 96472b6 to 2749d69 Compare October 28, 2023 08:16
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot conan-center-bot added the Missing dependencies Build failed due missing dependencies in Conan Center label Nov 5, 2023
@conan-center-bot

This comment has been minimized.

Sign in to view
@valgur valgur mentioned this pull request Nov 8, 2023
Open
@conan-center-bot conan-center-bot removed the Missing dependencies Build failed due missing dependencies in Conan Center label Nov 16, 2023
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions
Copy link
Contributor

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label May 30, 2024
AbrilRBS
AbrilRBS reviewed May 30, 2024
View reviewed changes
Copy link
Member

@AbrilRBS AbrilRBS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! Sorry that it took this long to get this PR reviewed. When closing a PR, GitHub marks it as done so we did not have it in our project list. This looks good to me, except for the dependency versions which maybe could get updated to better align with the rest of the repository? Wdyt @valgur?

@AbrilRBS AbrilRBS self-assigned this May 30, 2024
@valgur
Copy link
Contributor Author

valgur commented May 30, 2024

@RubenRBS Updated the dependency versions. Thanks!

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 1 (64690eba2cd7b07277fdbb527e907b1bc15f87ea):

  • pagmo2/2.10:
    All packages built successfully! (All logs)

  • pagmo2/2.19.0:
    All packages built successfully! (All logs)

  • pagmo2/2.17.0:
    All packages built successfully! (All logs)

Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 1 (64690eba2cd7b07277fdbb527e907b1bc15f87ea):

  • pagmo2/2.10:
    All packages built successfully! (All logs)

  • pagmo2/2.19.0:
    All packages built successfully! (All logs)

  • pagmo2/2.17.0:
    All packages built successfully! (All logs)

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label Jun 30, 2024
@AbrilRBS
Copy link
Member

bump, dont close this

@github-actions github-actions bot removed the stale label Jul 1, 2024
@conan-center-bot conan-center-bot merged commit ef2ae81 into conan-io:master Jul 3, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwillikers jwillikers jwillikers approved these changes

@AbrilRBS AbrilRBS AbrilRBS approved these changes

@franramirez688 franramirez688 franramirez688 approved these changes

@uilianries uilianries Awaiting requested review from uilianries

Assignees

@AbrilRBS AbrilRBS

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@valgur @conan-center-bot @AbrilRBS @franramirez688 @jwillikers