Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gn: migrate to Conan v2 #18847

Merged
merged 14 commits into from
May 6, 2024
Merged

gn: migrate to Conan v2 #18847

merged 14 commits into from
May 6, 2024

Conversation

valgur
Copy link
Contributor

@valgur valgur commented Jul 23, 2023 •
edited
Loading

.

@prince-chrismc prince-chrismc mentioned this pull request Jul 23, 2023
Open
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@valgur valgur closed this Jul 26, 2023
@valgur valgur reopened this Aug 16, 2023
@conan-center-bot

This comment has been minimized.

Sign in to view
@stale
Copy link

stale bot commented Sep 17, 2023

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Sep 17, 2023
@valgur valgur closed this Sep 17, 2023
@valgur valgur reopened this Sep 17, 2023
@stale stale bot removed the stale label Sep 17, 2023
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
AbrilRBS
AbrilRBS reviewed Jan 15, 2024
View reviewed changes
Copy link
Member

@AbrilRBS AbrilRBS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question about the sleep loop

recipes/gn/all/conanfile.py Outdated Show resolved Hide resolved
@valgur valgur requested a review from AbrilRBS January 18, 2024 09:36
@maxnbk
Copy link

maxnbk commented Feb 1, 2024

Does this PR need any assistance other than review? Hoping to pull in a conan-2-compatible crashpad which @valgur has also helpfully PRed and is blocked only on this.

@AbrilRBS AbrilRBS self-assigned this Feb 1, 2024
@IanBullard
Copy link

Please review this pull request.

@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@IanBullard
Copy link

I'd appreciate it if we can get this merged.

danimtb
danimtb reviewed Apr 25, 2024
View reviewed changes
recipes/gn/all/test_v1_package/conanfile.py Outdated
@@ -0,0 +1,69 @@
from conans import ConanFile, CMake, tools
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At this point, we can drop conan v1 test_packages

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 5 (93347945fbf79e526df784cc6ddb513ffc2f78ad):

  • gn/cci.20210429:
    All packages built successfully! (All logs)

Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 5 (93347945fbf79e526df784cc6ddb513ffc2f78ad):

  • gn/cci.20210429:
    All packages built successfully! (All logs)

@valgur valgur requested a review from danimtb April 25, 2024 19:11
@conan-center-bot conan-center-bot merged commit 03b6084 into conan-io:master May 6, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uilianries uilianries uilianries left review comments

@jwillikers jwillikers jwillikers approved these changes

@danimtb danimtb danimtb approved these changes

@franramirez688 franramirez688 Awaiting requested review from franramirez688

@AbrilRBS AbrilRBS Awaiting requested review from AbrilRBS

Assignees

@AbrilRBS AbrilRBS

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@valgur @conan-center-bot @maxnbk @IanBullard @uilianries @AbrilRBS @danimtb @jwillikers