Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libtommath: migrate to Conan v2 #18852

Open
wants to merge 28 commits into
base: master
Choose a base branch
from
Open

libtommath: migrate to Conan v2 #18852

wants to merge 28 commits into from

Conversation

valgur
Copy link
Contributor

@valgur valgur commented Jul 23, 2023 •
edited
Loading

Continues from #16558 with minimal changes (also resolves #16558).

@ghost ghost mentioned this pull request Jul 23, 2023
Closed
@prince-chrismc prince-chrismc mentioned this pull request Jul 23, 2023
Open
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@valgur valgur closed this Jul 26, 2023
@valgur valgur reopened this Aug 11, 2023
@conan-center-bot

This comment has been minimized.

Sign in to view
@stale
Copy link

stale bot commented Sep 17, 2023

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added stale and removed stale labels Sep 17, 2023
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@valgur valgur mentioned this pull request Nov 8, 2023
Open
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
This was referenced Jan 2, 2024
Draft
Closed
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
AbrilRBS
AbrilRBS reviewed May 29, 2024
View reviewed changes
Copy link
Member

@AbrilRBS AbrilRBS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I have a few comments, will get back to you once I've talked with the team :)

recipes/libtommath/all/conanfile.py Outdated
# libtommath requires at least /O1 on MSVC for dead code elimination
# https://github.com/libtom/libtommath/blob/42b3fb07e7d504f61a04c7fca12e996d76a25251/s_mp_rand_platform.c#L120-L138
self.output.warning("Debug builds on MSVC are not supported, switching to RelWithDebInfo")
self.settings.build_type = "RelWithDebInfo"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! Thanks a lot for fixing the failing configuration. I'll talk with the team about your proposed solution, which while interesting, it's better if it has all our consensus on going ahead with it :)

@AbrilRBS AbrilRBS self-assigned this May 29, 2024
AbrilRBS
AbrilRBS requested changes Jun 5, 2024
View reviewed changes
Copy link
Member

@AbrilRBS AbrilRBS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! We'll need to change the approach to the msvc compilation errors, I've left a suggestion after talking with the team, let me know what you think :)

recipes/libtommath/all/conanfile.py Outdated Show resolved Hide resolved
@valgur valgur requested a review from AbrilRBS July 15, 2024 13:09
AbrilRBS
AbrilRBS previously approved these changes Jul 15, 2024
View reviewed changes
Copy link
Member

@AbrilRBS AbrilRBS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! :)

@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 6 (1828fa1b8f579140ea452a8970e171544c657a81):

  • libtommath/1.2.1:
    All packages built successfully! (All logs)

  • libtommath/1.3.0:
    All packages built successfully! (All logs)

  • libtommath/1.2.0:
    All packages built successfully! (All logs)

Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 6 (1828fa1b8f579140ea452a8970e171544c657a81):

  • libtommath/1.3.0:
    All packages built successfully! (All logs)

  • libtommath/1.2.1:
    All packages built successfully! (All logs)

  • libtommath/1.2.0:
    All packages built successfully! (All logs)

@valgur valgur requested a review from AbrilRBS September 3, 2024 21:29
@uilianries uilianries self-assigned this Sep 23, 2024
@github-actions GitHub Actions
Copy link
Contributor

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label Oct 24, 2024
@valgur
Copy link
Contributor Author

valgur commented Oct 24, 2024

.

@github-actions github-actions bot removed the stale label Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwillikers jwillikers jwillikers approved these changes

@uilianries uilianries Awaiting requested review from uilianries

@AbrilRBS AbrilRBS Awaiting requested review from AbrilRBS

At least 2 approving reviews are required to merge this pull request.

Assignees

@uilianries uilianries

@AbrilRBS AbrilRBS

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@valgur @conan-center-bot @uilianries @AbrilRBS @jwillikers @jowr @prince-chrismc