Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

liquid-dsp: migrate to Conan v2 #18866

Merged
merged 13 commits into from
Sep 23, 2024
Merged

liquid-dsp: migrate to Conan v2 #18866

merged 13 commits into from
Sep 23, 2024

Conversation

valgur
Copy link
Contributor

@valgur valgur commented Jul 24, 2023

No description provided.

@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@prince-chrismc prince-chrismc mentioned this pull request Jul 24, 2023
Open
@conan-center-bot

This comment has been minimized.

Sign in to view
This was referenced Jul 25, 2023
Closed
Closed
@valgur valgur closed this Jul 26, 2023
@valgur valgur reopened this Jul 27, 2023
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@valgur valgur mentioned this pull request Nov 8, 2023
Open
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 4, 2024

Hooks produced the following warnings for commit 48563f1
liquid-dsp/1.6.0@#feb4d99c249be296e0ed133042efef6c 
post_package(): WARN: [APPLE RELOCATABLE SHARED LIBS (KB-H077)] install_name dir of these shared libs is not @rpath: libliquid.dylib
liquid-dsp/1.3.2@#57aabc0acb8fb64c184458a6746b901b 
post_package(): WARN: [APPLE RELOCATABLE SHARED LIBS (KB-H077)] install_name dir of these shared libs is not @rpath: libliquid.dylib

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 4, 2024

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label Aug 4, 2024
@valgur
Copy link
Contributor Author

valgur commented Aug 4, 2024

not stale

@github-actions github-actions bot removed the stale label Aug 5, 2024
@perseoGI perseoGI self-assigned this Aug 5, 2024
perseoGI
perseoGI reviewed Aug 5, 2024
View reviewed changes
Copy link
Contributor

@perseoGI perseoGI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, but need answers for the decision of removing windows support

recipes/liquid-dsp/all/conanfile.py Outdated Show resolved Hide resolved
recipes/liquid-dsp/all/conanfile.py
raise ConanInvalidConfiguration("Cross building is not yet supported. Contributions are welcome")
if is_msvc(self):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In Conan 1 this recipe supports Windows, why are we removing support in this migration?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It did so only through fetching MinGW via Conan and building with it instead of MSVC. I did try that approach and got it to work locally, but it kept failing on C3I due to a missing DLL despite at least 10 iterations of trying to fix this (and Windows is very unhelpful with its DLL error messages).
Relying on GCC from MinGW is a bit of a fragile edge-case for Conan, since it also becomes a build/runtime dependency unless you link GCC statically into a shared library. It's not well supported. See also #21193 (comment)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okey, we will leave this for the future then. It is better to have this recipe working in conan v2 for now. Even if it does not support MSVC

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label Sep 19, 2024
@valgur
Copy link
Contributor Author

valgur commented Sep 19, 2024

don't close

@github-actions github-actions bot removed the stale label Sep 20, 2024
@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 7 (f3af01b1a4c5b75d4cb98e520a4b2d749abc6dfe):

  • liquid-dsp/1.3.2:
    Built 16 packages out of 22 (All logs)

  • liquid-dsp/1.6.0:
    Built 16 packages out of 22 (All logs)

Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 7 (f3af01b1a4c5b75d4cb98e520a4b2d749abc6dfe):

  • liquid-dsp/1.6.0:
    Built 4 packages out of 10 (All logs)

  • liquid-dsp/1.3.2:
    Built 4 packages out of 10 (All logs)

@github-actions GitHub Actions
Copy link
Contributor

Hooks produced the following warnings for commit f3af01b
liquid-dsp/1.3.2@#66e83a981bb7bfcdbd20d23273935fc1 
post_package(): WARN: [APPLE RELOCATABLE SHARED LIBS (KB-H077)] install_name dir of these shared libs is not @rpath: libliquid.dylib
liquid-dsp/1.6.0@#5ccd1f0ba8f6a9303a657be82b58564d 
post_package(): WARN: [APPLE RELOCATABLE SHARED LIBS (KB-H077)] install_name dir of these shared libs is not @rpath: libliquid.dylib

perseoGI
perseoGI approved these changes Sep 20, 2024
View reviewed changes
Copy link
Contributor

@perseoGI perseoGI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@uilianries uilianries self-assigned this Sep 23, 2024
uilianries
uilianries approved these changes Sep 23, 2024
View reviewed changes
Copy link
Member

@uilianries uilianries left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you for porting this recipe.

  • This library is not consumed by other recipes in CCI, so dropping oldest version is fine.
  • Originally, it comes from [request] liquid-dsp/latest (help needed) #5908, no MSVC support has been requested so far, so dropping it is fine as well.
  • An official CMake support will not happen, as there are 3 open PRs in the upstream and the author is not a fan of CMake. So we need to deal with Make and flags directly.

@conan-center-bot conan-center-bot merged commit 56b0e24 into conan-io:master Sep 23, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SpaceIm SpaceIm SpaceIm left review comments

@perseoGI perseoGI perseoGI approved these changes

@uilianries uilianries uilianries approved these changes

@franramirez688 franramirez688 Awaiting requested review from franramirez688

Assignees

@uilianries uilianries

@perseoGI perseoGI

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@valgur @conan-center-bot @uilianries @perseoGI @SpaceIm @qchateau