glslang version 13.0.0 #19277

psyinf · 2023-08-18T20:26:05Z

Specify library name and version: glslang/13.0.0

This introduces version 13.0.0 which did some restructuring and exposes additional headers needed also for this PR.
Unfortunately the patch management concerning the PIC got messy so I decided to move this all to a single patch file

Required by #18996

I've read the contributing guidelines.
I've used a recent Conan client version close to the currently deployed.
I've tried at least one configuration locally with the conan-center hook activated.

uilianries · 2023-09-07T07:51:34Z

@psyinf Thank you for your contribution, it seems like some libraries/components are no longer present in this new version. The Conan hook spotted that mismatch. Could you please check the cpp_info vs what is installed in fact? During the package step, all installed artifacts are listed, so it can give a help.

psyinf · 2023-09-08T21:47:52Z

@psyinf Thank you for your contribution, it seems like some libraries/components are no longer present in this new version. The Conan hook spotted that mismatch. Could you please check the cpp_info vs what is installed in fact? During the package step, all installed artifacts are listed, so it can give a help.
@uilianries I removed the components for the new version/shared build, but I honestly don't feel to confident here
After having the component problem out of the way the CI run fails due to an older CMake version in the build job than required by the package. Any hints here?

psyinf · 2023-09-17T15:37:24Z

@conan-io/barbarians Anything I can do about the failing builds due to the cmake version on the build-hosts is too low? Since the version is from the upstream package, there is not much I can do here

using a single patch instead of fiddling in conanfile deactivated removed modules when building shared library

require newer CMake version

conan-center-bot · 2023-09-19T23:03:48Z

Conan v1 pipeline ❌

Failure in build 12 (4328d3c798702827e3a97757ac57393e446f4eb3):

glslang/1.3.239.0:
All packages built successfully! (All logs)
glslang/1.3.236.0:
All packages built successfully! (All logs)
glslang/1.3.216.0:
All packages built successfully! (All logs)
glslang/1.3.224.0:
All packages built successfully! (All logs)
glslang/1.3.231.1:
Didn't run or was cancelled before finishing
glslang/1.3.211.0:
Didn't run or was cancelled before finishing

glslang/13.0.0:
CI failed to create some packages (All logs)

Logs for packageID d268931894af4ed937a806fe896eac335e4a8526:

[settings]
arch=x86_64
build_type=Release
compiler=gcc
compiler.libcxx=libstdc++11
compiler.version=7
os=Linux
[options]
glslang:shared=True

[...]
[ 79%] Building CXX object src/SPIRV/CMakeFiles/SPIRV.dir/InReadableOrder.cpp.o
[ 80%] Building CXX object src/SPIRV/CMakeFiles/SPIRV.dir/Logger.cpp.o
[ 82%] Building CXX object src/SPIRV/CMakeFiles/SPIRV.dir/SpvBuilder.cpp.o
[ 83%] Linking CXX shared library libglslang.so
[ 83%] Built target glslang
[ 85%] Building CXX object src/SPIRV/CMakeFiles/SPIRV.dir/SpvPostProcess.cpp.o
[ 86%] Building CXX object src/SPIRV/CMakeFiles/SPIRV.dir/doc.cpp.o
[ 88%] Building CXX object src/SPIRV/CMakeFiles/SPIRV.dir/SpvTools.cpp.o
[ 89%] Building CXX object src/SPIRV/CMakeFiles/SPIRV.dir/disassemble.cpp.o
[ 91%] Building CXX object src/SPIRV/CMakeFiles/SPIRV.dir/CInterface/spirv_c_interface.cpp.o
[ 92%] Linking CXX shared library libSPIRV.so
[ 92%] Built target SPIRV
[ 94%] Generating /home/conan/w/prod-v1/bsr/13035/cbacd/.conan/data/glslang/13.0.0/_/_/build/d268931894af4ed937a806fe896eac335e4a8526/build/Release/include/glslang/glsl_intrinsic_header.h
[ 95%] Building CXX object src/StandAlone/CMakeFiles/spirv-remap.dir/spirv-remap.cpp.o
[ 97%] Building CXX object src/StandAlone/CMakeFiles/glslang-standalone.dir/StandAlone.cpp.o
src/StandAlone/CMakeFiles/spirv-remap.dir/build.make:75: recipe for target 'src/StandAlone/CMakeFiles/spirv-remap.dir/spirv-remap.cpp.o' failed
CMakeFiles/Makefile2:405: recipe for target 'src/StandAlone/CMakeFiles/spirv-remap.dir/all' failed
[ 98%] Linking CXX executable glslang
[ 98%] Built target glslang-standalone
Makefile:135: recipe for target 'all' failed
glslang/13.0.0: 
CMake Deprecation Warning at CMakeLists.txt:1 (cmake_minimum_required):
  Compatibility with CMake < 3.5 will be removed from a future version of
  CMake.

  Update the VERSION argument <min> value or use a ...<max> suffix to tell
  CMake that the project does not need compatibility with older versions.


CMake Warning:
  Manually-specified variables were not used by the project:

    CMAKE_POLICY_DEFAULT_CMP0042


/home/conan/w/prod-v1/bsr/13035/cbacd/.conan/data/glslang/13.0.0/_/_/build/d268931894af4ed937a806fe896eac335e4a8526/src/StandAlone/spirv-remap.cpp:40:10: fatal error: filesystem: No such file or directory
 #include <filesystem>
          ^~~~~~~~~~~~
compilation terminated.
make[2]: *** [src/StandAlone/CMakeFiles/spirv-remap.dir/spirv-remap.cpp.o] Error 1
make[1]: *** [src/StandAlone/CMakeFiles/spirv-remap.dir/all] Error 2
make[1]: *** Waiting for unfinished jobs....
make: *** [all] Error 2
glslang/13.0.0: WARN: Using the new toolchains and generators without specifying a build profile (e.g: -pr:b=default) is discouraged and might cause failures and unexpected behavior
glslang/13.0.0: WARN: Using the new toolchains and generators without specifying a build profile (e.g: -pr:b=default) is discouraged and might cause failures and unexpected behavior
glslang/13.0.0: ERROR: Package 'd268931894af4ed937a806fe896eac335e4a8526' build failed
glslang/13.0.0: WARN: Build folder /home/conan/w/prod-v1/bsr/13035/cbacd/.conan/data/glslang/13.0.0/_/_/build/d268931894af4ed937a806fe896eac335e4a8526/build/Release
ERROR: glslang/13.0.0: Error in build() method, line 170
	cmake.build()
	ConanException: Error 2 while executing cmake --build "/home/conan/w/prod-v1/bsr/13035/cbacd/.conan/data/glslang/13.0.0/_/_/build/d268931894af4ed937a806fe896eac335e4a8526/build/Release" '--' '-j3'

glslang/8.13.3559:
Didn't run or was cancelled before finishing
glslang/11.7.0:
Didn't run or was cancelled before finishing
glslang/11.6.0:
Didn't run or was cancelled before finishing
glslang/11.5.0:
Didn't run or was cancelled before finishing
glslang/1.3.204.0:
Didn't run or was cancelled before finishing

^{Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.}

uilianries · 2023-09-20T09:12:09Z

@psyinf That new version requires C++ Filesystem, that's separated distributed:

https://en.cppreference.com/w/cpp/filesystem#Notes

Please, use the follow workaround to fix it:

https://github.com/conan-io/conan-center-index/blob/master/recipes/metall/all/conanfile.py#L85C48-L85C48

ghost · 2023-09-20T10:14:59Z

I detected other pull requests that are modifying glslang/all recipe:

glslang: update versions, simplify patching #19980

This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there.

psyinf · 2023-09-20T19:38:53Z

This seems to be superseeded by #19980

psyinf changed the title ~~add version 12.3.1~~ glslang version 12.3.1 Aug 18, 2023

prince-chrismc mentioned this pull request Aug 18, 2023

Pull Requests Ready to be Reviewed prince-chrismc/conan-center-index-pending-review#1

Open

conan-center-bot added the Failed label Aug 18, 2023

This comment has been minimized.

Sign in to view

ericLemanissier mentioned this pull request Aug 19, 2023

Updatable recipes ericLemanissier/conan-center-bot#1

Closed

uilianries mentioned this pull request Aug 18, 2023

Add shader-compiler option and versions 1.0.6, 1.0.7 and 1.0.8 #18996

Closed

3 tasks

This comment has been minimized.

Sign in to view

uilianries self-assigned this Sep 7, 2023

psyinf changed the title ~~glslang version 12.3.1~~ glslang version 13.0.0 Sep 8, 2023

This comment has been minimized.

Sign in to view

This was referenced Sep 9, 2023

Updatable recipes qchateau/conan-center-bot#1

Open

[request] Updatable recipes #3470

Closed

This comment has been minimized.

Sign in to view

psyinf added 8 commits September 19, 2023 21:08

add version 12.3.1

b7f0a65

some style corrections

889933a

some style corrections

1a87b42

some style corrections

c462880

conforming conandata

2f247c4

moving straight to 13.0.0

bf3e50f

using a single patch instead of fiddling in conanfile deactivated removed modules when building shared library

raise c++ std for version 13.0.0

63296ef

raise c++ std for version 13.0.0

4328d3c

require newer CMake version

psyinf force-pushed the glslang branch from 1107017 to 4328d3c Compare September 19, 2023 19:08

This was referenced Sep 20, 2023

[service] Potentially conflicting recipes #3571

Closed

glslang: update versions, simplify patching #19980

Merged

psyinf closed this Sep 20, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

glslang version 13.0.0 #19277

glslang version 13.0.0 #19277

psyinf commented Aug 18, 2023 •

edited

Loading

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

uilianries commented Sep 7, 2023

psyinf commented Sep 8, 2023 •

edited

Loading

This comment has been minimized.

This comment has been minimized.

psyinf commented Sep 17, 2023

This comment has been minimized.

This comment has been minimized.

conan-center-bot commented Sep 19, 2023

uilianries commented Sep 20, 2023

ghost commented Sep 20, 2023

psyinf commented Sep 20, 2023

glslang version 13.0.0 #19277

glslang version 13.0.0 #19277

Conversation

psyinf commented Aug 18, 2023 • edited Loading

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

uilianries commented Sep 7, 2023

psyinf commented Sep 8, 2023 • edited Loading

This comment has been minimized.

This comment has been minimized.

psyinf commented Sep 17, 2023

This comment has been minimized.

This comment has been minimized.

conan-center-bot commented Sep 19, 2023

Conan v1 pipeline ❌

uilianries commented Sep 20, 2023

ghost commented Sep 20, 2023

psyinf commented Sep 20, 2023

psyinf commented Aug 18, 2023 •

edited

Loading

psyinf commented Sep 8, 2023 •

edited

Loading