add spirv-tools/2020.3 + cmake components + pkg_config name + propagate C++ lib for C API #1931

SpaceIm · 2020-06-16T14:24:04Z

Specify library name and version: spirv-tools/2020.3

I've read the guidelines for contributing.
I've followed the PEP8 style guides for Python code in the recipes.
I've used the latest Conan client version.
I've tried at least one configuration locally with the
conan-center hook activated.

conan-center-bot · 2020-06-16T14:57:24Z

Some configurations of 'spirv-tools/v2019.2' failed in build 1 (441110569ccf2b0f3cbb0f7666b1465d55d7ac25):

Windows x86_64, Debug, Visual Studio 14, MTd. Options: spirv-tools:shared-False
Access to all the logs
Linux x86_64, Release, gcc 5, libstdc++ . Options: spirv-tools:shared-False
Access to all the logs

SpaceIm · 2020-06-16T15:03:20Z

I've introduced tools.stdcpp_library (conan 1.26.0) in this recipe #1918
(I rebase to not rely on 1.26.0 and use custom stdcpp_library function).

conan-center-bot · 2020-06-16T17:46:14Z

All green in build 2 (8643f014525b3dc4b3b074e90050f675f4aa30fc)! 😊

spirv-tools/v2019.2: Generated 130 packages. All logs here
spirv-tools/v2020.3: Generated 130 packages. All logs here

recipes/spirv-tools/all/conanfile.py

SpaceIm · 2020-06-17T06:53:20Z

By the way, how to raise ConanInvalidConfiguration if spirv-headers is overidden with non compatible version?

uilianries · 2020-06-17T16:52:21Z

@SpaceIm you can use self.deps_cpp_info["spirv-headers"].version under the build() method.

SpaceIm · 2020-06-28T21:15:33Z

@uilianries But build method is not called for pre-built binaries.

conan-center-bot · 2020-07-03T15:56:21Z

Some configurations of 'spirv-tools/v2019.2' failed in build 3 (aa23c61d3ec6aed379476fdab266a982900f3f01):

Windows x86_64, Debug, Visual Studio 14, MTd. Options: spirv-tools:shared-False
Access to all the logs

uilianries

Almost good to go

recipes/spirv-tools/all/conanfile.py

SpaceIm · 2020-07-03T21:16:07Z

Some configurations of 'spirv-tools/v2019.2' failed in build 3 (aa23c61d3ec6aed379476fdab266a982900f3f01):

* **Windows x86_64, Debug, Visual Studio 14,  MTd. Options:  spirv-tools:shared-False**
  
  * [Log download](https://c3i.jfrog.io/c3i/misc/logs/pr/1931/3/spirv-tools/v2019.2/fd7c50537851c0c29e9130b0cfd8fd5601d842c3/create_stdout.txt)
  * [Log error Download](https://c3i.jfrog.io/c3i/misc/logs/pr/1931/3/spirv-tools/v2019.2/fd7c50537851c0c29e9130b0cfd8fd5601d842c3/create_stderr.txt)
  * [Profile](https://c3i.jfrog.io/c3i/misc/logs/pr/1931/3/spirv-tools/v2019.2/fd7c50537851c0c29e9130b0cfd8fd5601d842c3/profile.txt)

* [Access to all the logs](https://c3i.jfrog.io/c3i/misc/logs/pr/1931/3/spirv-tools/v2019.2/)

C:\Program Files (x86)\MSBuild\Microsoft.Cpp\v4.0\V140\Microsoft.CppBuild.targets(312,5): error MSB3491: Could not write lines to file "x64\Debug\spirv-tools-spv-amd-shader-explicit-vertex-parameter\spirv-to.DA7493CC.tlog\spirv-tools-spv-amd-shader-explicit-vertex-parameter.lastbuildstate". The specified path, file name, or both are too long. The fully qualified file name must be less than 260 characters, and the directory name must be less than 248 characters. [C:\J\workspace\onan-center-pull-request_PR-1931\3\pr_1931_3_0_2\.short\9ec970\1\build_subfolder\source_subfolder\source\spirv-tools-spv-amd-shader-explicit-vertex-parameter.vcxproj]

This recipe has short_paths=True, so why this error? Moreover it was working previously, I did minor changes unrelated to path length.

Co-authored-by: Uilian Ries <uilianries@gmail.com>

conan-center-bot · 2020-07-03T21:45:06Z

Some configurations of 'spirv-tools/v2019.2' failed in build 4 (8546f62eb2b8b2c483602d322a4c122f2bbb7e14):

Windows x86_64, Debug, Visual Studio 14, MTd. Options: spirv-tools:shared-False
Access to all the logs

Croydon · 2020-07-05T23:14:48Z

recipes/spirv-tools/all/conandata.yml

@@ -2,3 +2,6 @@ sources:
 "v2019.2":
 sha256: 1fde9d2a0df920a401441cd77253fc7b3b9ab0578eabda8caaaceaa6c7638440
 url: https://github.com/KhronosGroup/SPIRV-Tools/archive/v2019.2.tar.gz
+ "v2020.3":


Probably too late to change now, but regularly we remove the v prefix if there is one

It has been discussed when this recipe was added: #1349 (comment). @jgsogo requested to add v prefix.

conan-center-bot · 2020-07-06T15:22:07Z

Some configurations of 'spirv-tools/v2019.2' failed in build 5 (8546f62eb2b8b2c483602d322a4c122f2bbb7e14):

Windows x86_64, Debug, Visual Studio 14, MTd. Options: spirv-tools:shared-False
Access to all the logs

jgsogo · 2020-07-06T15:33:03Z

I'm writing to the people in charge of the infrastructure. The path length limitation on Windows should have been removed, maybe this one is a rebel Windows node. I'll keep you updated.

conan-center-bot · 2020-07-06T16:44:05Z

Some configurations of 'spirv-tools/v2019.2' failed in build 6 (8546f62eb2b8b2c483602d322a4c122f2bbb7e14):

Windows x86_64, Debug, Visual Studio 14, MTd. Options: spirv-tools:shared-False
Access to all the logs

conan-center-bot · 2020-07-13T15:01:29Z

Some configurations of 'spirv-tools/v2019.2' failed in build 7 (8546f62eb2b8b2c483602d322a4c122f2bbb7e14):

Windows x86_64, Debug, Visual Studio 14, MTd. Options: spirv-tools:shared-False
Access to all the logs

conan-center-bot · 2020-07-18T21:52:54Z

All green in build 8 (8546f62eb2b8b2c483602d322a4c122f2bbb7e14)! 😊

spirv-tools/v2019.2: Generated 130 packages. All logs here
spirv-tools/v2020.3: Generated 130 packages. All logs here

SpaceIm · 2020-07-19T10:41:50Z

I should add a TODO. SPIRV-Tools exports one config file per target, and these imported targets aren't namespaced. It can't be modeled currently in conan for cmake_find_package and cmake_find_package_multi generators.

conan-center-bot added the Failed label Jun 16, 2020

SpaceIm force-pushed the bump/spirv-tools/2020.3 branch from 4411105 to 8643f01 Compare June 16, 2020 15:08

conan-center-bot removed the Failed label Jun 16, 2020

uilianries previously approved these changes Jun 16, 2020

View reviewed changes

uilianries requested review from danimtb and SSE4 June 16, 2020 21:02

SSE4 reviewed Jun 17, 2020

View reviewed changes

recipes/spirv-tools/all/conanfile.py Outdated Show resolved Hide resolved

SSE4 previously approved these changes Jun 22, 2020

View reviewed changes

add spirv-tools/2020.3 + components

aa23c61

SpaceIm dismissed stale reviews from SSE4 and uilianries via aa23c61 July 3, 2020 15:29

SpaceIm force-pushed the bump/spirv-tools/2020.3 branch from 8643f01 to aa23c61 Compare July 3, 2020 15:29

SpaceIm requested review from SSE4 and uilianries July 3, 2020 15:30

conan-center-bot added the Failed label Jul 3, 2020

uilianries requested changes Jul 3, 2020

View reviewed changes

recipes/spirv-tools/all/conanfile.py Show resolved Hide resolved

spirv-tools: delete fPIC if shared

8546f62

Co-authored-by: Uilian Ries <uilianries@gmail.com>

SpaceIm requested a review from uilianries July 3, 2020 21:20

Croydon reviewed Jul 5, 2020

View reviewed changes

SpaceIm mentioned this pull request Jul 7, 2020

add h3/3.6.4 + add option to build filters #2139

Merged

4 tasks

jgsogo mentioned this pull request Jul 7, 2020

adding srt/1.4.1 #2126

Merged

4 tasks

SpaceIm mentioned this pull request Jul 7, 2020

add glslang/8.13.3559 #1360

Merged

4 tasks

SSE4 approved these changes Jul 7, 2020

View reviewed changes

SSE4 added infrastructure Waiting on tools or services belonging to the infra blocked Affected by an external issue and waiting until it is solved labels Jul 7, 2020

This was referenced Jul 10, 2020

c-blosc: use Snappy::snappy target in patches #2178

Merged

nlopt: fix cmake target + delete fPIC if shared + propagate C++ lib if cxx routines #2182

Merged

SpaceIm closed this Jul 18, 2020

SpaceIm reopened this Jul 18, 2020

conan-center-bot removed the Failed label Jul 18, 2020

danimtb approved these changes Jul 20, 2020

View reviewed changes

uilianries approved these changes Jul 20, 2020

View reviewed changes

uilianries merged commit 239e948 into conan-io:master Jul 20, 2020

SpaceIm deleted the bump/spirv-tools/2020.3 branch July 20, 2020 17:40

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add spirv-tools/2020.3 + cmake components + pkg_config name + propagate C++ lib for C API #1931

add spirv-tools/2020.3 + cmake components + pkg_config name + propagate C++ lib for C API #1931

SpaceIm commented Jun 16, 2020

conan-center-bot commented Jun 16, 2020

SpaceIm commented Jun 16, 2020 •

edited

Loading

conan-center-bot commented Jun 16, 2020

SpaceIm commented Jun 17, 2020

uilianries commented Jun 17, 2020 •

edited

Loading

SpaceIm commented Jun 28, 2020 •

edited

Loading

conan-center-bot commented Jul 3, 2020

uilianries left a comment

SpaceIm commented Jul 3, 2020 •

edited

Loading

conan-center-bot commented Jul 3, 2020

Croydon Jul 5, 2020 •

edited

Loading

SpaceIm Jul 6, 2020 •

edited

Loading

conan-center-bot commented Jul 6, 2020

jgsogo commented Jul 6, 2020

conan-center-bot commented Jul 6, 2020

conan-center-bot commented Jul 13, 2020

conan-center-bot commented Jul 18, 2020

SpaceIm commented Jul 19, 2020 •

edited

Loading

add spirv-tools/2020.3 + cmake components + pkg_config name + propagate C++ lib for C API #1931

add spirv-tools/2020.3 + cmake components + pkg_config name + propagate C++ lib for C API #1931

Conversation

SpaceIm commented Jun 16, 2020

conan-center-bot commented Jun 16, 2020

SpaceIm commented Jun 16, 2020 • edited Loading

conan-center-bot commented Jun 16, 2020

SpaceIm commented Jun 17, 2020

uilianries commented Jun 17, 2020 • edited Loading

SpaceIm commented Jun 28, 2020 • edited Loading

conan-center-bot commented Jul 3, 2020

uilianries left a comment

Choose a reason for hiding this comment

SpaceIm commented Jul 3, 2020 • edited Loading

conan-center-bot commented Jul 3, 2020

Croydon Jul 5, 2020 • edited Loading

Choose a reason for hiding this comment

SpaceIm Jul 6, 2020 • edited Loading

Choose a reason for hiding this comment

conan-center-bot commented Jul 6, 2020

jgsogo commented Jul 6, 2020

conan-center-bot commented Jul 6, 2020

conan-center-bot commented Jul 13, 2020

conan-center-bot commented Jul 18, 2020

SpaceIm commented Jul 19, 2020 • edited Loading

SpaceIm commented Jun 16, 2020 •

edited

Loading

uilianries commented Jun 17, 2020 •

edited

Loading

SpaceIm commented Jun 28, 2020 •

edited

Loading

SpaceIm commented Jul 3, 2020 •

edited

Loading

Croydon Jul 5, 2020 •

edited

Loading

SpaceIm Jul 6, 2020 •

edited

Loading

SpaceIm commented Jul 19, 2020 •

edited

Loading