apriltag: add v3.4.2, remove old versions #20017
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
This was referenced Sep 21, 2023
valgur
force-pushed
the
update/apriltag
branch
from
554bd4b to
28668ef
Compare
This comment has been minimized.
This comment has been minimized.
valgur
force-pushed
the
update/apriltag
branch
from
28668ef to
ddf41d9
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
valgur
force-pushed
the
update/apriltag
branch
from
1c8e969 to
694df68
Compare
This comment has been minimized.
This comment has been minimized.
uilianries
reviewed
Nov 7, 2023
This comment has been minimized.
This comment has been minimized.
valgur
force-pushed
the
update/apriltag
branch
from
0dedb91 to
f75bced
Compare
This comment has been minimized.
This comment has been minimized.
valgur
force-pushed
the
update/apriltag
branch
from
f75bced to
79ccdc5
Compare
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
Don't close. |
This comment has been minimized.
This comment has been minimized.
Was solely due to the order of objects being destructed.
This comment has been minimized.
This comment has been minimized.
valgur
changed the title
Conan v1 pipeline ✔️All green in build 4 (
Conan v2 pipeline ✔️
All green in build 4 ( |
AbrilRBS
approved these changes
Sep 9, 2024
uilianries
approved these changes
Sep 12, 2024
There was a problem hiding this comment.
LGTM
- Replacing patches for NOMINMAX by Conan features was a good move
- Using CMAKE_WINDOWS_EXPORT_ALL_SYMBOLS is acceptable since the upstream is enforcing the same: https://github.com/AprilRobotics/apriltag/blob/v3.4.0/CMakeLists.txt#L35
- Confirmed that pthread4w is no longer needed: https://github.com/AprilRobotics/apriltag/blob/v3.2.0/CMakeLists.txt#L49
- Good catch with the debug prefix: https://github.com/AprilRobotics/apriltag/blob/v3.3.0/CMakeLists.txt#L54
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.