Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tensorflow-lite: add version 2.14.0 #20173

Closed
wants to merge 1 commit into from

Conversation

Wawha
Copy link

@Wawha Wawha commented Sep 27, 2023

Library name and version: tensorflow-lite/2.14.0

Add new version 2.14.0 of Tensorflow lite.
Modifications compare to tensorflow repo:

  • Add by headers files of library ml_dtypes to be able to compile.

Conan package modification:

  • Add Android support in test_package.

@CLAassistant
Copy link

CLAassistant commented Sep 27, 2023

CLA assistant check
All committers have signed the CLA.

@conan-center-bot

This comment has been minimized.

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ❌

Sorry, the build is only launched for Access Request users. You can request access writing in this issue.


Conan v2 pipeline ❌

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

The v2 pipeline failed. Please, review the errors and note this is required for pull requests to be merged. In case this recipe is still not ported to Conan 2.x, please, ping @conan-io/barbarians on the PR and we will help you.

See details:

Sorry, the build is only launched for Access Request users. You can request access writing in this issue.

Comment on lines +13 to +15
- patch_file: "patches/disable_fetch_content.patch"
patch_description: "Fail if the CMake build script tries to fetch external dependencies"
patch_type: "conan"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This patch can probably be replaced with simply setting FETCHCONTENT_FULLY_DISCONNECTED.

Comment on lines +9 to +10
-find_package(fft2d REQUIRED)
+find_package(fft REQUIRED)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can probably do deps = ConanDeps(self); deps.set_property("fft", "cmake_file_name", "fft2d") instead.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The same goes for xnnpack.

Comment on lines +114 to +121
- farmhash
+ farmhash::farmhash
fft2d_fftsg2d
- flatbuffers::flatbuffers
- gemmlowp::gemmlowp
- ml_dtypes
+ ${FLATBUFFERS_TARGET}
+ gemmlowp::eight_bit_int_gemm
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

deps.set_property("farmhash", "cmake_target_name", "farmhash")
deps.set_property("gemmlowp", "cmake_target_name", "gemmlowp::gemmlowp")

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At this point I would rather download() it from GitHub instead. That's a bit excessive for a patch.

Copy link
Contributor

@valgur valgur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The full header file is a tad excessive for a patch. Patching can probably simplified slightly. Otherwise LGTM.

Thanks!

@Wawha
Copy link
Author

Wawha commented Mar 26, 2024

The full header file is a tad excessive for a patch. Patching can probably simplified slightly. Otherwise LGTM.

Thanks!

Thank you for the review. Unfortunately I'm not working anymore on that project, so I do not have the setup to test the modification I could make with you remarks.
Perhaps I should close the pull request

@ghost ghost mentioned this pull request May 9, 2024
Copy link
Contributor

github-actions bot commented Sep 7, 2024

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label Sep 7, 2024
Copy link
Contributor

github-actions bot commented Oct 7, 2024

This pull request has been automatically closed because it has not had recent activity. Thank you for your contributions.

@github-actions github-actions bot closed this Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants