-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[openvino] ported upstream patches to 2023.1.0 #20245
[openvino] ported upstream patches to 2023.1.0 #20245
Conversation
I detected other pull requests that are modifying openvino/all recipe: This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there. |
This comment has been minimized.
This comment has been minimized.
6f0c578
to
ad07567
Compare
This comment has been minimized.
This comment has been minimized.
ad07567
to
0ebc694
Compare
url: "https://github.com/openvinotoolkit/openvino/archive/47b736f63edda256d66e2bbb572f42a9d6549f6e.tar.gz" | ||
sha256: "8a1dd5b35fe4b60440e97ee61e12e01aa4dd78b5be30550aa08fcd96c416e1d7" | ||
url: "https://github.com/openvinotoolkit/openvino/archive/refs/tags/2023.1.0.tar.gz" | ||
sha256: "ff88596b342440185874ddbe22874b47ad7b923f14671921af760b15c98aacd6" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
commit hash is the same, just replace with tag instead if commit hash:
$ git log -1 2023.1.0
commit 47b736f63edda256d66e2bbb572f42a9d6549f6e (tag: 2023.1.0)
Author: Tatiana Savina <tatiana.savina@intel.com>
Date: Mon Sep 4 15:04:36 2023 +0200
update links (#19563)
63eea71
to
a3ee522
Compare
This comment has been minimized.
This comment has been minimized.
a3ee522
to
11946a4
Compare
11946a4
to
f606af0
Compare
Conan v1 pipeline ✔️All green in build 12 (
Conan v2 pipeline ✔️
All green in build 12 (
|
@SpaceIm @RubenRBS |
@ilya-lavrenov yup, it's in the review backlog :) Thanks for your patience |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We usually prefer to have a mapping in the recipe code itself, but I guess this also works! Thanks a lot :)
I supposed that if we have mapping in code - we need to change it with every version of OpenVINO. So, when we introduce new version - Conan CI will rebuild all other OpenVINO versions, while they are actually not touched. I hoped to WA this rebuild issue with external files for dependencies, because OpenVINO rebuild is not a 2 mins task :) |
Hi @SSE4 @theirix @ericLemanissier @jwillikers |
Changes requested here #19681 (comment):
Several patches from upstream to make the recipe itself more future proof and minimize conditions when adding newer versions:
rapidjson
as a requirement instead of "local" copy of this dependency in 3rdparty. This allows to prevent possible ODR violations.Common changes: