Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aeron: fix missing glibc symbols on newer systems #20267

Merged
merged 3 commits into from
Oct 22, 2023
Merged

aeron: fix missing glibc symbols on newer systems #20267

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c63812d
aeron: add -fno-finite-math-only to fix issues with glibc >= 2.31
valgur Oct 3, 2023
c617296
aeron: bump deps
valgur Oct 3, 2023
d08c042
aeron: avoid overwriting of CMAKE_CXX_FLAGS in toolchain
valgur Oct 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions recipes/aeron/all/conanfile.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ class AeronConan(ConanFile):
description = "Efficient reliable UDP unicast, UDP multicast, and IPC message transport"
topics = ("udp", "messaging", "low-latency")
url = "https://github.com/conan-io/conan-center-index"
homepage = "https://github.com/real-logic/aeron/wiki"
homepage = "https://github.com/real-logic/aeron"
license = "Apache-2.0"

package_type = "library"
Expand Down Expand Up @@ -72,7 +72,7 @@ def validate(self):
raise ConanInvalidConfiguration("This platform (os=Macos arch=armv8) is not yet supported by this recipe")

def build_requirements(self):
self.tool_requires("zulu-openjdk/11.0.15")
self.tool_requires("zulu-openjdk/11.0.19")

def source(self):
get(self, **self.conan_data["sources"][self.version], strip_root=True)
Expand All @@ -90,6 +90,12 @@ def generate(self):
tc.cache_variables["AERON_BUILD_DOCUMENTATION"] = False
tc.cache_variables["AERON_INSTALL_TARGETS"] = True
tc.cache_variables["AERON_ENABLE_NONSTANDARD_OPTIMIZATIONS"] = True
# The finite-math-only optimization has no effect and can cause linking errors
# when linked against glibc >= 2.31
tc.blocks["cmake_flags_init"].template += (
'string(APPEND CMAKE_CXX_FLAGS_INIT " -fno-finite-math-only")\n'
'string(APPEND CMAKE_C_FLAGS_INIT " -fno-finite-math-only")\n'
)
tc.generate()

def _patch_sources(self):
Expand Down