-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
openjpeg: fix missing glibc symbols on newer systems #20274
Conversation
070cf26
to
774b478
Compare
This comment has been minimized.
This comment has been minimized.
774b478
to
b9333d1
Compare
This comment has been minimized.
This comment has been minimized.
Hooks produced the following warnings for commit b9333d1openjpeg/2.3.1@#9485608b5ce6912057cbf50016291e9c
openjpeg/2.5.0@#6bec0285d8d57d37cb8fe0cc65716b0a
openjpeg/2.4.0@#51a915beb91ce694df230ec25f326351
|
This comment has been minimized.
This comment has been minimized.
1b8455c
to
b274746
Compare
Conan v1 pipeline ✔️All green in build 9 (
Conan v2 pipeline ✔️
All green in build 9 ( |
@@ -137,6 +144,7 @@ def package_info(self): | |||
self.cpp_info.set_property("cmake_build_modules", [self._module_vars_rel_path]) | |||
self.cpp_info.set_property("pkg_config_name", "libopenjp2") | |||
self.cpp_info.includedirs.append(os.path.join("include", self._openjpeg_subdir)) | |||
self.cpp_info.builddirs.append(os.path.join("lib", "cmake")) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was this just completely missing beforehand?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was, somehow.
Related to conan-io/hooks#508
Applying the hook temporarily as a part of the package to validate that the fix for the glibc issue works.
A full list of packages affected by removed glibc symbols can be found here:
https://gist.github.com/valgur/4fec44c680d3df6401495dc8be4642d2