Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libinput: Add recipe #20346

Merged
merged 9 commits into from
Mar 22, 2024
Merged

libinput: Add recipe #20346

merged 9 commits into from
Mar 22, 2024

Conversation

jwillikers
Copy link
Contributor

@jwillikers jwillikers commented Oct 4, 2023 •
edited
Loading

Specify library name and version: libinput/1.25.0

libinput is a library that handles input devices for display servers and other applications that need to directly deal with input devices.

libinput is required to enable the libinput backend in wlroots.

The following PRs are required first:

Optionally, a libwacom package could be added to enable libwacom support.

@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@jwillikers jwillikers mentioned this pull request Oct 12, 2023
Draft
10 tasks
@ghost ghost mentioned this pull request Feb 28, 2024
Closed
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@jwillikers jwillikers marked this pull request as ready for review February 29, 2024 12:16
@prince-chrismc prince-chrismc mentioned this pull request Feb 29, 2024
Open
@jwillikers jwillikers mentioned this pull request Feb 29, 2024
Draft
7 tasks
@conan-center-bot

This comment has been minimized.

Sign in to view
@franramirez688 franramirez688 self-assigned this Mar 7, 2024
AbrilRBS
AbrilRBS reviewed Mar 14, 2024
View reviewed changes
Copy link
Member

@AbrilRBS AbrilRBS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! Step by step we have finally merged the blocking PRs so good to finally be able to come back to this one, I have some initial questions about this recipe, but overall looks great :)

recipes/libinput/all/conanfile.py Show resolved Hide resolved
recipes/libinput/all/conanfile.py Outdated Show resolved Hide resolved
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 3 (a56078318cbcd85c76e0ed923a5f4f9352baa0d5):

  • libinput/1.25.0:
    All packages built successfully! (All logs)

Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 3 (a56078318cbcd85c76e0ed923a5f4f9352baa0d5):

  • libinput/1.25.0:
    All packages built successfully! (All logs)

@conan-center-bot conan-center-bot merged commit 31cb467 into conan-io:master Mar 22, 2024
13 checks passed
@jwillikers jwillikers deleted the libinput branch March 22, 2024 12:25
@franramirez688
Copy link
Contributor

FYI, I just tried this:

$ conan create . --version 1.25.0 -o debug_gui=True --build missing
...

ERROR: Version conflict: Conflict between expat/2.6.0 and expat/2.5.0 in the graph.
Conflict originates from fontconfig/2.14.2

Run conan graph info with your recipe and add --format=html to inspect the graph errors in an easier to visualize way.

@jwillikers
Copy link
Contributor Author

FYI, I just tried this:

$ conan create . --version 1.25.0 -o debug_gui=True --build missing
...

ERROR: Version conflict: Conflict between expat/2.6.0 and expat/2.5.0 in the graph.
Conflict originates from fontconfig/2.14.2

Run conan graph info with your recipe and add --format=html to inspect the graph errors in an easier to visualize way.

Oh, that's from cairo most likely. PR #22696 should fix that or at least one of the conflicts.

SpaceIm
SpaceIm reviewed Mar 27, 2024
View reviewed changes
recipes/libinput/all/conanfile.py
self.requires("gtk/system")
if self.options.with_wayland:
self.requires("wayland/1.22.0")
self.requires("wayland-protocols/1.33")
Copy link
Contributor

@SpaceIm SpaceIm Mar 27, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wayland-protocols should be a build requirement

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SpaceIm Right you are! This slipped through the recipes I needed to update to do this. I'll take care of it in a follow up PR. Thanks!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR #23301

Ahajha pushed a commit to Ahajha/conan-center-index that referenced this pull request Apr 6, 2024
@jwillikers @Ahajha
(conan-io#20346) libinput: Add recipe
9095e56 
* libinput: Add recipe

* Link transitively to both libevdev and mtdev

* Revert "Link transitively to both libevdev and mtdev"

This reverts commit 20d94b1.

* Remove comment

* Disable debug_gui by default to reduce default number of dependencies

* Fix error in the test package

* Update

* Bump eudev version

* Remove comment and only require wayland when debug_gui is enabled
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SpaceIm SpaceIm SpaceIm left review comments

@AbrilRBS AbrilRBS AbrilRBS approved these changes

@ericLemanissier ericLemanissier ericLemanissier approved these changes

@franramirez688 franramirez688 Awaiting requested review from franramirez688

Assignees

@franramirez688 franramirez688

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jwillikers @conan-center-bot @franramirez688 @ericLemanissier @AbrilRBS @SpaceIm