Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pipes: move checks to validate() instead of configure() and add msvc min version #20369

Merged
merged 6 commits into from
Oct 30, 2024

Conversation

SpaceIm
Copy link
Contributor

@SpaceIm SpaceIm commented Oct 5, 2023

Specify library name and version: lib/1.0


@AbrilRBS
Copy link
Member

AbrilRBS commented Oct 5, 2023

I've won the race to post the build results against the bot, here are the v2 errors https://c3i.jfrog.io/c3i/misc-v2/summary.html?json=https://c3i.jfrog.io/c3i/misc-v2/logs/pr/20369/1-linux-gcc/pipes/1.0.0//summary.json

@AbrilRBS AbrilRBS self-assigned this Oct 5, 2023
@SpaceIm
Copy link
Contributor Author

SpaceIm commented Oct 5, 2023

I could restore hardcoded CMAKE_CXX_STANDARD 14 in test package just to pass pipeline, but it would be a lie because compiler.cppstd would not be honored in test package. It seems that this header-only lib doesn't work with C++17, it's bad.

@conan-center-bot

This comment has been minimized.

@AbrilRBS
Copy link
Member

AbrilRBS commented Oct 6, 2023

Oh that's a pitty that it can't compile in C++17 - I'm ok having a check for max_cppstd in the validate too even if it then only creates binaries for msvc

jcar87
jcar87 previously approved these changes Jun 12, 2024
AbrilRBS
AbrilRBS previously approved these changes Jun 17, 2024
@conan-center-bot

This comment has been minimized.

Signed-off-by: Uilian Ries <uilianries@gmail.com>
@uilianries uilianries dismissed stale reviews from AbrilRBS and jcar87 via c3f9085 October 30, 2024 08:17
uilianries
uilianries previously approved these changes Oct 30, 2024
Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@uilianries uilianries assigned uilianries and unassigned AbrilRBS Oct 30, 2024
@conan-center-bot

This comment has been minimized.

Signed-off-by: Uilian Ries <uilianries@gmail.com>
@conan-center-bot

This comment has been minimized.

Signed-off-by: Uilian Ries <uilianries@gmail.com>
@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

Warning

Conan Center will stop receiving updates for Conan 1.x packages soon - please see announcement.

All green in build 4 (117859903ddca3c6c2d9942039f6ac4a3e2b2ba4):

  • pipes/1.0.0:
    Built 5 packages out of 11 (All logs)

Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 4 (117859903ddca3c6c2d9942039f6ac4a3e2b2ba4):

  • pipes/1.0.0:
    Built 4 packages out of 5 (All logs)

@conan-center-bot conan-center-bot merged commit a9f61a0 into conan-io:master Oct 30, 2024
8 checks passed
@SpaceIm SpaceIm deleted the pipes-raise-validate branch October 30, 2024 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants