-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pipes: move checks to validate()
instead of configure()
and add msvc min version
#20369
pipes: move checks to validate()
instead of configure()
and add msvc min version
#20369
Conversation
I've won the race to post the build results against the bot, here are the v2 errors https://c3i.jfrog.io/c3i/misc-v2/summary.html?json=https://c3i.jfrog.io/c3i/misc-v2/logs/pr/20369/1-linux-gcc/pipes/1.0.0//summary.json |
I could restore hardcoded CMAKE_CXX_STANDARD 14 in test package just to pass pipeline, but it would be a lie because compiler.cppstd would not be honored in test package. It seems that this header-only lib doesn't work with C++17, it's bad. |
This comment has been minimized.
This comment has been minimized.
Oh that's a pitty that it can't compile in C++17 - I'm ok having a check for max_cppstd in the validate too even if it then only creates binaries for msvc |
This comment has been minimized.
This comment has been minimized.
Signed-off-by: Uilian Ries <uilianries@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
This comment has been minimized.
This comment has been minimized.
Signed-off-by: Uilian Ries <uilianries@gmail.com>
This comment has been minimized.
This comment has been minimized.
Signed-off-by: Uilian Ries <uilianries@gmail.com>
Conan v1 pipeline ✔️Warning Conan Center will stop receiving updates for Conan 1.x packages soon - please see announcement. All green in build 4 (
Conan v2 pipeline ✔️
All green in build 4 (
|
Specify library name and version: lib/1.0