Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new library: Diplib #20452

Open
wants to merge 15 commits into
base: master
Choose a base branch
from
Open

new library: Diplib #20452

wants to merge 15 commits into from

Conversation

weatherhead99
Copy link
Contributor

@weatherhead99 weatherhead99 commented Oct 9, 2023

Specify library name and version: diplib/3.4.0

fairly well used package especially in computational microscopy, DIPlib, from here: https://diplib.org.

Most options are implemented in this recipe.
Currently it uses internal libics, but that library could also be contributed to conan in future


@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@AbrilRBS
Copy link
Member

AbrilRBS commented Oct 9, 2023

@AbrilRBS AbrilRBS self-assigned this Oct 9, 2023
Copy link
Member

@AbrilRBS AbrilRBS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thanks a lot for your contribution, we really appreciate it.
As Conan Center Index only builds the recipe with their default options, we're pushing for these PRs to have proof that other variations of the options also work, by asking for logs of their compilation/tests of those variations you feel that are worth providing (We also check locally, but our findings of what's important might differ and that's always interesting to know!)

Note that we are also happy to get simpler PRs in that just the bare minimum options, or most useful/common ones are supported, we'd muych rather prefer to have solid recipes that work under all conditions that untested combinations :)

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ❌

Failure in build 9 (9825862a3a6a51905eb1d2ba100ef43a1103529b):

  • diplib/3.4.0:
    CI failed to create some packages (All logs)

    Logs for packageID 5f6baba44b7b655f3bfb09f25ac63b13079f5f97:
    [settings]
    arch=x86_64
    build_type=Debug
    compiler=Visual Studio
    compiler.runtime=MDd
    compiler.version=16
    os=Windows
    [options]
    diplib:shared=False
    
    [...]
    diplib/3.4.0 (test package): CMake command: cmake -G "Visual Studio 16 2019" -DCMAKE_TOOLCHAIN_FILE="C:/J2/w/prod-v1/bsr/cci-a567bada/recipes/diplib/all/test_package/build/generators/conan_toolchain.cmake" -DCMAKE_POLICY_DEFAULT_CMP0091="NEW" "C:\J2\w\prod-v1\bsr\cci-a567bada\recipes\diplib\all\test_package\."
    
    ----Running------
    > cmake -G "Visual Studio 16 2019" -DCMAKE_TOOLCHAIN_FILE="C:/J2/w/prod-v1/bsr/cci-a567bada/recipes/diplib/all/test_package/build/generators/conan_toolchain.cmake" -DCMAKE_POLICY_DEFAULT_CMP0091="NEW" "C:\J2\w\prod-v1\bsr\cci-a567bada\recipes\diplib\all\test_package\."
    -----------------
    -- Using Conan toolchain: C:/J2/w/prod-v1/bsr/cci-a567bada/recipes/diplib/all/test_package/build/generators/conan_toolchain.cmake
    -- The CXX compiler identification is MSVC 19.29.30148.0
    -- Detecting CXX compiler ABI info
    -- Detecting CXX compiler ABI info - done
    -- Check for working CXX compiler: C:/Program Files (x86)/Microsoft Visual Studio/2019/Community/VC/Tools/MSVC/14.29.30133/bin/Hostx64/x64/cl.exe - skipped
    -- Detecting CXX compile features
    -- Detecting CXX compile features - done
    -- Conan: Target declared 'DIPlib::DIP'
    -- Conan: Component target declared 'Eigen3::Eigen'
    -- Conan: Target declared 'JPEG::JPEG'
    -- Conan: Target declared 'TIFF::TIFF'
    -- Conan: Target declared 'ZLIB::ZLIB'
    -- Conan: Component target declared 'libdeflate::libdeflate_static'
    -- Conan: Target declared 'LibLZMA::LibLZMA'
    -- Conan: Including build module from 'C:/J2/w/prod-v1/bsr/26598/dbbac/.conan/data/xz_utils/5.4.4/_/_/package/d057732059ea44a47760900cb5e4855d2bea8714/lib/cmake/conan-official-xz_utils-variables.cmake'
    -- Conan: Target declared 'jbig::jbig'
    -- Conan: Component target declared 'zstd::libzstd_static'
    -- Conan: Component target declared 'WebP::webpdecoder'
    -- Conan: Component target declared 'WebP::sharpyuv'
    -- Conan: Component target declared 'WebP::webp'
    -- Conan: Component target declared 'WebP::webpdemux'
    -- Conan: Component target declared 'WebP::libwebpmux'
    -- Conan: Target declared 'libwebp::libwebp'
    -- Configuring done
    -- Generating done
    -- Build files have been written to: C:/J2/w/prod-v1/bsr/cci-a567bada/recipes/diplib/all/test_package/build
    diplib/3.4.0 (test package): CMake command: cmake --build "C:\J2\w\prod-v1\bsr\cci-a567bada\recipes\diplib\all\test_package\build" --config Debug
    
    ----Running------
    > cmake --build "C:\J2\w\prod-v1\bsr\cci-a567bada\recipes\diplib\all\test_package\build" --config Debug
    -----------------
    Microsoft (R) Build Engine version 16.11.2+f32259642 for .NET Framework
    Copyright (C) Microsoft Corporation. All rights reserved.
    
      Checking Build System
      Building Custom Rule C:/J2/w/prod-v1/bsr/cci-a567bada/recipes/diplib/all/test_package/CMakeLists.txt
      main.cpp
    main.obj : error LNK2019: unresolved external symbol "__declspec(dllimport) struct dip::LibraryInformation const dip::libraryInformation" (__imp_?libraryInformation@dip@@3ULibraryInformation@1@B) referenced in function main [C:\J2\w\prod-v1\bsr\cci-a567bada\recipes\diplib\all\test_package\build\test_package.vcxproj]
    C:\J2\w\prod-v1\bsr\cci-a567bada\recipes\diplib\all\test_package\build\Debug\test_package.exe : fatal error LNK1120: 1 unresolved externals [C:\J2\w\prod-v1\bsr\cci-a567bada\recipes\diplib\all\test_package\build\test_package.vcxproj]
    WARN: libtiff/4.6.0: requirement zlib/[>=1.2.11 <2] overridden by diplib/3.4.0 to zlib/1.3 
    diplib/3.4.0 (test package): WARN: Using the new toolchains and generators without specifying a build profile (e.g: -pr:b=default) is discouraged and might cause failures and unexpected behavior
    diplib/3.4.0 (test package): WARN: Using the new toolchains and generators without specifying a build profile (e.g: -pr:b=default) is discouraged and might cause failures and unexpected behavior
    ERROR: diplib/3.4.0 (test package): Error in build() method, line 20
    	cm.build()
    	ConanException: Error 1 while executing cmake --build "C:\J2\w\prod-v1\bsr\cci-a567bada\recipes\diplib\all\test_package\build" --config Debug
    

Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.


Conan v2 pipeline ❌

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

The v2 pipeline failed. Please, review the errors and note this is required for pull requests to be merged. In case this recipe is still not ported to Conan 2.x, please, ping @conan-io/barbarians on the PR and we will help you.

See details:

Failure in build 9 (9825862a3a6a51905eb1d2ba100ef43a1103529b):

  • diplib/3.4.0:
    CI failed to create some packages (All logs)

    Logs for packageID 12a707874faddbb952e781414ff9bd4fcf282623:
    [settings]
    arch=x86_64
    build_type=Release
    compiler=msvc
    compiler.cppstd=14
    compiler.runtime=dynamic
    compiler.runtime_type=Release
    compiler.version=192
    os=Windows
    [options]
    */*:shared=False
    
    [...]
    diplib/3.4.0 (test package): Running CMake.configure()
    diplib/3.4.0 (test package): RUN: cmake -G "Visual Studio 16 2019" -DCMAKE_TOOLCHAIN_FILE="C:/J2/w/prod-v2/bsr/cci-c8e4c0bb/recipes/diplib/all/test_package/build/msvc-192-x86_64-14-release/generators/conan_toolchain.cmake" -DCMAKE_INSTALL_PREFIX="C:/J2/w/prod-v2/bsr/cci-c8e4c0bb/recipes/diplib/all/test_package" -DCMAKE_POLICY_DEFAULT_CMP0091="NEW" "C:\J2\w\prod-v2\bsr\cci-c8e4c0bb\recipes\diplib\all\test_package"
    -- Using Conan toolchain: C:/J2/w/prod-v2/bsr/cci-c8e4c0bb/recipes/diplib/all/test_package/build/msvc-192-x86_64-14-release/generators/conan_toolchain.cmake
    -- Conan toolchain: C++ Standard 14 with extensions OFF
    -- The CXX compiler identification is MSVC 19.29.30148.0
    -- Detecting CXX compiler ABI info
    -- Detecting CXX compiler ABI info - done
    -- Check for working CXX compiler: C:/Program Files (x86)/Microsoft Visual Studio/2019/Community/VC/Tools/MSVC/14.29.30133/bin/Hostx64/x64/cl.exe - skipped
    -- Detecting CXX compile features
    -- Detecting CXX compile features - done
    -- Conan: Target declared 'DIPlib::DIP'
    -- Conan: Target declared 'TIFF::TIFF'
    -- Conan: Component target declared 'libdeflate::libdeflate_static'
    -- Conan: Target declared 'LibLZMA::LibLZMA'
    -- Conan: Including build module from 'C:/J2/w/prod-v2/bsr/21489/babbe/p/xz_ut81b897e312a60/p/lib/cmake/conan-official-xz_utils-variables.cmake'
    -- Conan: Target declared 'JPEG::JPEG'
    -- Conan: Target declared 'jbig::jbig'
    -- Conan: Component target declared 'zstd::libzstd_static'
    -- Conan: Component target declared 'WebP::webpdecoder'
    -- Conan: Component target declared 'WebP::sharpyuv'
    -- Conan: Component target declared 'WebP::webp'
    -- Conan: Component target declared 'WebP::webpdemux'
    -- Conan: Component target declared 'WebP::libwebpmux'
    -- Conan: Target declared 'libwebp::libwebp'
    -- Conan: Target declared 'ZLIB::ZLIB'
    -- Configuring done
    -- Generating done
    -- Build files have been written to: C:/J2/w/prod-v2/bsr/cci-c8e4c0bb/recipes/diplib/all/test_package/build/msvc-192-x86_64-14-release
    
    diplib/3.4.0 (test package): Running CMake.build()
    diplib/3.4.0 (test package): RUN: cmake --build "C:\J2\w\prod-v2\bsr\cci-c8e4c0bb\recipes\diplib\all\test_package\build\msvc-192-x86_64-14-release" --config Release
    Microsoft (R) Build Engine version 16.11.2+f32259642 for .NET Framework
    Copyright (C) Microsoft Corporation. All rights reserved.
    
      Checking Build System
      Building Custom Rule C:/J2/w/prod-v2/bsr/cci-c8e4c0bb/recipes/diplib/all/test_package/CMakeLists.txt
      main.cpp
    main.obj : error LNK2019: unresolved external symbol "__declspec(dllimport) struct dip::LibraryInformation const dip::libraryInformation" (__imp_?libraryInformation@dip@@3ULibraryInformation@1@B) referenced in function main [C:\J2\w\prod-v2\bsr\cci-c8e4c0bb\recipes\diplib\all\test_package\build\msvc-192-x86_64-14-release\test_package.vcxproj]
    C:\J2\w\prod-v2\bsr\cci-c8e4c0bb\recipes\diplib\all\test_package\build\msvc-192-x86_64-14-release\Release\test_package.exe : fatal error LNK1120: 1 unresolved externals [C:\J2\w\prod-v2\bsr\cci-c8e4c0bb\recipes\diplib\all\test_package\build\msvc-192-x86_64-14-release\test_package.vcxproj]
    
    *********************************************************
    Recipe 'diplib/3.4.0 (test package)' cannot build its binary
    It is possible that this recipe is not Conan 2.0 ready
    If the recipe comes from ConanCenter, report it at https://github.com/conan-io/conan-center-index/issues
    If it is your recipe, check if it is updated to 2.0
    *********************************************************
    
    ERROR: diplib/3.4.0 (test package): Error in build() method, line 20
    	cm.build()
    	ConanException: Error 1 while executing
    

Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.

@perseoGI perseoGI self-assigned this Jun 14, 2024
Copy link
Contributor

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants