Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

util-linux-libuuid: Add version 2.40.2 and use Meson #20508

Closed
wants to merge 48 commits into from

Conversation

jwillikers
Copy link
Contributor

@jwillikers jwillikers commented Oct 10, 2023

The upstream util-linux project is moving towards Meson. This PR migrates the recipe from Autotools to Meson for version 2.40.2. Version 2.39 has cross-compilation issues when using Meson.

Blocked by upstream issue causing build failures on macOS:


@conan-center-bot

This comment has been minimized.

AbrilRBS
AbrilRBS previously approved these changes Oct 11, 2023
@AbrilRBS AbrilRBS self-requested a review October 11, 2023 09:20
@conan-center-bot

This comment has been minimized.

@jwillikers jwillikers force-pushed the util-linux-libuuid-meson branch from adddf48 to fcbafad Compare March 6, 2024 16:07
@jwillikers jwillikers changed the title util-linux-libuuid/2.39: Switch to Meson util-linux-libuuid: Add version 2.40 and use Meson Mar 6, 2024
@jwillikers jwillikers marked this pull request as draft March 6, 2024 16:08
@jwillikers
Copy link
Contributor Author

jwillikers commented Mar 6, 2024

Using Meson to cross-compile version 2.39 results in this error:

libmount/lib_mount.a.p/src_hook_mount.c.o -MF libmount/lib_mount.a.p/src_hook_mount.c.o.d -o libmount/lib_mount.a.p/src_hook_mount.c.o -c ../src/libmount/src/hook_mount.c
../src/libmount/src/hook_mount.c: In function ‘hook_create_mount’:
../src/libmount/src/hook_mount.c:302:40: error: ‘struct statx’ has no member named ‘stx_mnt_id’; did you mean ‘stx_uid’?
  302 |                 cxt->fs->id = (int) st.stx_mnt_id;
      |                                        ^~~~~~~~~~
      |                                        stx_uid

I've decided to target Meson for the upcoming 2.40 version. The 2.40-rc2 version cross-compiles successfully for me. Unitl version 2.40 is out, I'm marking this as a draft.

@conan-center-bot

This comment has been minimized.

@jwillikers jwillikers force-pushed the util-linux-libuuid-meson branch from fcbafad to 3ce0f20 Compare March 6, 2024 16:21
@conan-center-bot

This comment has been minimized.

@jwillikers jwillikers force-pushed the util-linux-libuuid-meson branch from 3ce0f20 to 0f795bb Compare March 7, 2024 20:14
@jwillikers
Copy link
Contributor Author

Ran into an issue: util-linux/util-linux#2830

@conan-center-bot

This comment has been minimized.

@jwillikers jwillikers force-pushed the util-linux-libuuid-meson branch from 0f795bb to 0666c43 Compare March 7, 2024 20:35
@conan-center-bot

This comment has been minimized.

The upstream util-linux project is moving towards Meson.
This PR adds version 2.40 and uses Meson for this version.
I had trouble when using the 2.39 version with Meson, so I'm not switching those over to it.
@jwillikers jwillikers force-pushed the util-linux-libuuid-meson branch from 0666c43 to 07d263b Compare March 20, 2024 15:01
@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@jwillikers jwillikers changed the title util-linux-libuuid: Add version 2.40 and use Meson util-linux-libuuid: Add version 2.40.1 and use Meson May 7, 2024
@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@jwillikers jwillikers changed the title util-linux-libuuid: Add version 2.40.1 and use Meson util-linux-libuuid: Add version 2.40.2 and use Meson Jul 15, 2024
@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ❌

Failure in build 43 (4540ac779a29e83f22bffb1a483831d206f9624a):

  • util-linux-libuuid/2.39.2:
    Didn't run or was cancelled before finishing

  • util-linux-libuuid/2.39:
    Didn't run or was cancelled before finishing

  • util-linux-libuuid/2.40.2:
    CI failed to create some packages (All logs)

    Logs for packageID d50a0d523d98c15bb147b18fa7d203887c38be8b:
    [settings]
    arch=x86_64
    build_type=Release
    compiler=gcc
    compiler.libcxx=libstdc++11
    compiler.version=7
    os=Linux
    [options]
    util-linux-libuuid:shared=False
    
    [...]
    [32/141] Compiling C object lib/libcommon.a.p/linux_version.c.o
    [33/141] Compiling C object lib/libcommon.a.p/xxhash.c.o
    [34/141] Compiling C object lib/libcommon.a.p/cpuset.c.o
    [35/141] Compiling C object lib/libcommon.a.p/loopdev.c.o
    [36/141] Compiling C object lib/libcommon.a.p/path.c.o
    [37/141] Compiling C object lib/libcommon.a.p/sysfs.c.o
    [38/141] Linking static target lib/libcommon.a
    [39/141] Compiling C object libuuid/libuuid.so.1.3.0.p/src_clear.c.o
    [40/141] Compiling C object lib/libtcolors.a.p/color-names.c.o
    [41/141] Compiling C object libuuid/libuuid.so.1.3.0.p/src_compare.c.o
    [42/141] Compiling C object libuuid/libuuid.so.1.3.0.p/src_copy.c.o
    [43/141] Compiling C object lib/libtcolors.a.p/colors.c.o
    [44/141] Linking static target lib/libtcolors.a
    [45/141] Compiling C object libuuid/libuuid.so.1.3.0.p/src_isnull.c.o
    [46/141] Compiling C object libuuid/libuuid.so.1.3.0.p/src_pack.c.o
    [47/141] Compiling C object libuuid/libuuid.so.1.3.0.p/src_parse.c.o
    [48/141] Compiling C object libuuid/libuuid.so.1.3.0.p/src_predefined.c.o
    [49/141] Compiling C object libuuid/libuuid.so.1.3.0.p/src_uuid_time.c.o
    [50/141] Compiling C object libuuid/libuuid.so.1.3.0.p/src_unpack.c.o
    [51/141] Compiling C object libuuid/libuuid.so.1.3.0.p/src_gen_uuid.c.o
    [52/141] Compiling C object libuuid/libuuid.so.1.3.0.p/src_unparse.c.o
    [53/141] Compiling C object libuuid/libuuid.so.1.3.0.p/.._lib_randutils.c.o
    [54/141] Building translation po/ca/LC_MESSAGES/util-linux-ca.mo
    [55/141] Compiling C object libuuid/libuuid.so.1.3.0.p/.._lib_md5.c.o
    [56/141] Building translation po/cs/LC_MESSAGES/util-linux-cs.mo
    [57/141] Building translation po/da/LC_MESSAGES/util-linux-da.mo
    [58/141] Building translation po/de/LC_MESSAGES/util-linux-de.mo
    [59/141] Compiling C object libuuid/libuuid.so.1.3.0.p/.._lib_sha1.c.o
    [60/141] Linking target libuuid/libuuid.so.1.3.0
    FAILED: libuuid/libuuid.so.1.3.0 
    gcc  -o libuuid/libuuid.so.1.3.0 libuuid/libuuid.so.1.3.0.p/src_clear.c.o libuuid/libuuid.so.1.3.0.p/src_compare.c.o libuuid/libuuid.so.1.3.0.p/src_copy.c.o libuuid/libuuid.so.1.3.0.p/src_gen_uuid.c.o libuuid/libuuid.so.1.3.0.p/src_isnull.c.o libuuid/libuuid.so.1.3.0.p/src_pack.c.o libuuid/libuuid.so.1.3.0.p/src_parse.c.o libuuid/libuuid.so.1.3.0.p/src_uuid_time.c.o libuuid/libuuid.so.1.3.0.p/src_predefined.c.o libuuid/libuuid.so.1.3.0.p/src_unpack.c.o libuuid/libuuid.so.1.3.0.p/src_unparse.c.o libuuid/libuuid.so.1.3.0.p/.._lib_randutils.c.o libuuid/libuuid.so.1.3.0.p/.._lib_md5.c.o libuuid/libuuid.so.1.3.0.p/.._lib_sha1.c.o -Wl,--as-needed -Wl,--no-undefined -Wl,-O1 -shared -fPIC -Wl,-soname,libuuid.so.1 -Wl,--version-script=/home/conan/workspace/prod-v1/bsr/69994/bbabd/.conan/data/util-linux-libuuid/2.40.2/_/_/build/d50a0d523d98c15bb147b18fa7d203887c38be8b/src/libuuid/src/libuuid.sym
    libuuid/libuuid.so.1.3.0.p/src_gen_uuid.c.o: In function `uuid_generate_time':
    gen_uuid.c:(.text+0xe0c): undefined reference to `pthread_atfork'
    libuuid/libuuid.so.1.3.0.p/src_gen_uuid.c.o: In function `uuid_generate_time_safe':
    gen_uuid.c:(.text+0xf4c): undefined reference to `pthread_atfork'
    collect2: error: ld returned 1 exit status
    [61/141] Building translation po/es/LC_MESSAGES/util-linux-es.mo
    [62/141] Building translation po/et/LC_MESSAGES/util-linux-et.mo
    ninja: build stopped: subcommand failed.
    INFO: autodetecting backend as ninja
    INFO: calculating backend command to run: /home/conan/workspace/prod-v1/bsr/69994/bbabd/.conan/data/ninja/1.11.1/_/_/package/24647d9fe8ec489125dfbae4b3ebefaf7581674c/bin/ninja -j 3
    util-linux-libuuid/2.40.2: 
    
    Generating targets:   0%|          | 0/166 eta ?
    Generating targets:  36%|███▌      | 59/166 eta 00:00
    Generating targets:  71%|███████   | 118/166 eta 00:00
    Generating targets:  99%|█████████▉| 165/166 eta 00:00
                                                          
    
    Writing build.ninja:   0%|          | 0/450 eta ?
                                                     
    WARN: *** Conan 1 is legacy and on a deprecation path ***
    WARN: *** Please upgrade to Conan 2 ***
    util-linux-libuuid/2.40.2: WARN: Using the new toolchains and generators without specifying a build profile (e.g: -pr:b=default) is discouraged and might cause failures and unexpected behavior
    util-linux-libuuid/2.40.2: ERROR: Package 'd50a0d523d98c15bb147b18fa7d203887c38be8b' build failed
    util-linux-libuuid/2.40.2: WARN: Build folder /home/conan/workspace/prod-v1/bsr/69994/bbabd/.conan/data/util-linux-libuuid/2.40.2/_/_/build/d50a0d523d98c15bb147b18fa7d203887c38be8b/build-release
    ERROR: util-linux-libuuid/2.40.2: Error in build() method, line 113
    	meson.build()
    	ConanException: Error 1 while executing meson compile -C "/home/conan/workspace/prod-v1/bsr/69994/bbabd/.conan/data/util-linux-libuuid/2.40.2/_/_/build/d50a0d523d98c15bb147b18fa7d203887c38be8b/build-release" -j3
    

Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.


Conan v2 pipeline ❌

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

The v2 pipeline failed. Please, review the errors and note this is required for pull requests to be merged. In case this recipe is still not ported to Conan 2.x, please, ping @conan-io/barbarians on the PR and we will help you.

Failure in build 43 (4540ac779a29e83f22bffb1a483831d206f9624a):

  • util-linux-libuuid/2.39:
    Didn't run or was cancelled before finishing

  • util-linux-libuuid/2.39.2:
    Didn't run or was cancelled before finishing

  • util-linux-libuuid/2.40.2:
    CI failed to create some packages (All logs)

    Logs for packageID b647c43bfefae3f830561ca202b6cfd935b56205:
    [settings]
    arch=x86_64
    build_type=Release
    compiler=gcc
    compiler.cppstd=17
    compiler.libcxx=libstdc++11
    compiler.version=11
    os=Linux
    [options]
    */*:shared=False
    
    [...]
    [28/141] Compiling C object lib/libcommon.a.p/ttyutils.c.o
    [29/141] Compiling C object lib/libcommon.a.p/xxhash.c.o
    [30/141] Compiling C object lib/libcommon.a.p/timeutils.c.o
    [31/141] Compiling C object lib/libcommon.a.p/caputils.c.o
    [32/141] Compiling C object lib/libcommon.a.p/linux_version.c.o
    [33/141] Compiling C object lib/libcommon.a.p/strutils.c.o
    [34/141] Compiling C object lib/libcommon.a.p/cpuset.c.o
    [35/141] Compiling C object lib/libcommon.a.p/path.c.o
    [36/141] Compiling C object lib/libcommon.a.p/sysfs.c.o
    [37/141] Compiling C object lib/libcommon.a.p/loopdev.c.o
    [38/141] Linking static target lib/libcommon.a
    [39/141] Compiling C object lib/libtcolors.a.p/color-names.c.o
    [40/141] Compiling C object libuuid/libuuid.so.1.3.0.p/src_clear.c.o
    [41/141] Compiling C object libuuid/libuuid.so.1.3.0.p/src_copy.c.o
    [42/141] Compiling C object libuuid/libuuid.so.1.3.0.p/src_compare.c.o
    [43/141] Compiling C object lib/libtcolors.a.p/colors.c.o
    [44/141] Linking static target lib/libtcolors.a
    [45/141] Compiling C object libuuid/libuuid.so.1.3.0.p/src_isnull.c.o
    [46/141] Compiling C object libuuid/libuuid.so.1.3.0.p/src_pack.c.o
    [47/141] Compiling C object libuuid/libuuid.so.1.3.0.p/src_uuid_time.c.o
    [48/141] Compiling C object libuuid/libuuid.so.1.3.0.p/src_parse.c.o
    [49/141] Compiling C object libuuid/libuuid.so.1.3.0.p/src_predefined.c.o
    [50/141] Compiling C object libuuid/libuuid.so.1.3.0.p/src_unpack.c.o
    [51/141] Compiling C object libuuid/libuuid.so.1.3.0.p/src_gen_uuid.c.o
    [52/141] Compiling C object libuuid/libuuid.so.1.3.0.p/src_unparse.c.o
    [53/141] Compiling C object libuuid/libuuid.so.1.3.0.p/.._lib_randutils.c.o
    [54/141] Building translation po/ca/LC_MESSAGES/util-linux-ca.mo
    [55/141] Compiling C object libuuid/libuuid.so.1.3.0.p/.._lib_md5.c.o
    [56/141] Building translation po/cs/LC_MESSAGES/util-linux-cs.mo
    [57/141] Compiling C object libuuid/libuuid.so.1.3.0.p/.._lib_sha1.c.o
    [58/141] Linking target libuuid/libuuid.so.1.3.0
    FAILED: libuuid/libuuid.so.1.3.0 
    gcc  -o libuuid/libuuid.so.1.3.0 libuuid/libuuid.so.1.3.0.p/src_clear.c.o libuuid/libuuid.so.1.3.0.p/src_compare.c.o libuuid/libuuid.so.1.3.0.p/src_copy.c.o libuuid/libuuid.so.1.3.0.p/src_gen_uuid.c.o libuuid/libuuid.so.1.3.0.p/src_isnull.c.o libuuid/libuuid.so.1.3.0.p/src_pack.c.o libuuid/libuuid.so.1.3.0.p/src_parse.c.o libuuid/libuuid.so.1.3.0.p/src_uuid_time.c.o libuuid/libuuid.so.1.3.0.p/src_predefined.c.o libuuid/libuuid.so.1.3.0.p/src_unpack.c.o libuuid/libuuid.so.1.3.0.p/src_unparse.c.o libuuid/libuuid.so.1.3.0.p/.._lib_randutils.c.o libuuid/libuuid.so.1.3.0.p/.._lib_md5.c.o libuuid/libuuid.so.1.3.0.p/.._lib_sha1.c.o -Wl,--as-needed -Wl,--no-undefined -Wl,-O1 -shared -fPIC -Wl,-soname,libuuid.so.1 -Wl,--version-script=/home/conan/workspace/prod-v2/bsr/63153/fccaf/p/b/util-97e46bf5c3038/b/src/libuuid/src/libuuid.sym
    /opt/conan/binutils/bin/ld: libuuid/libuuid.so.1.3.0.p/src_gen_uuid.c.o: in function `uuid_generate_time':
    gen_uuid.c:(.text+0xc84): undefined reference to `pthread_atfork'
    /opt/conan/binutils/bin/ld: libuuid/libuuid.so.1.3.0.p/src_gen_uuid.c.o: in function `uuid_generate_time_safe':
    gen_uuid.c:(.text+0xdec): undefined reference to `pthread_atfork'
    collect2: error: ld returned 1 exit status
    [59/141] Building translation po/da/LC_MESSAGES/util-linux-da.mo
    [60/141] Building translation po/de/LC_MESSAGES/util-linux-de.mo
    ninja: build stopped: subcommand failed.
    INFO: autodetecting backend as ninja
    INFO: calculating backend command to run: /home/conan/workspace/prod-v2/bsr/63153/fccaf/p/ninja6fed3c8400c5b/p/bin/ninja -j 3
    
    util-linux-libuuid/2.40.2: ERROR: 
    Package 'b647c43bfefae3f830561ca202b6cfd935b56205' build failed
    util-linux-libuuid/2.40.2: WARN: Build folder /home/conan/workspace/prod-v2/bsr/63153/fccaf/p/b/util-97e46bf5c3038/b/build-release
    ERROR: util-linux-libuuid/2.40.2: Error in build() method, line 113
    	meson.build()
    	ConanException: Error 1 while executing
    

Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.

Copy link
Contributor

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label Nov 13, 2024
Copy link
Contributor

This pull request has been automatically closed because it has not had recent activity. Thank you for your contributions.

@github-actions github-actions bot closed this Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants