Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

podofo/all: bump deps, use version range for OpenSSL #20725

Merged
merged 10 commits into from
Aug 19, 2024

Conversation

mayeut
Copy link
Contributor

@mayeut mayeut commented Oct 21, 2023

Specify library name and version: podofo/all

fix conflicts, build with conan v2


@conan-center-bot

This comment has been minimized.

@mayeut
Copy link
Contributor Author

mayeut commented Oct 22, 2023

The podofo recipe itself is v2 ready (builds fine without idn)
v2 is thus blocked on #18641 being merged.

@AbrilRBS
Copy link
Member

@mayeut thanks for linking it, will try to prioritize getting that one merged to unblock you :)

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@mayeut
Copy link
Contributor Author

mayeut commented Apr 19, 2024

The podofo recipe itself is v2 ready (builds fine without idn)
v2 is thus blocked on #18641 being merged.

@RubenRBS, It's been merged !

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@AbrilRBS
Copy link
Member

AbrilRBS commented May 9, 2024

@mayeut sorry I missed the ping, building now

@conan-center-bot conan-center-bot added Bump dependencies Only bumping dependencies versions in the recipe Failed and removed Waiting for CI labels May 9, 2024
@conan-center-bot

This comment has been minimized.

@conan-center-bot conan-center-bot removed Failed Bump dependencies Only bumping dependencies versions in the recipe labels May 9, 2024
@conan-center-bot

This comment has been minimized.

@mayeut
Copy link
Contributor Author

mayeut commented May 10, 2024

@RubenRBS,
The failed build relates to c++17 being used on macOS.
Given 0.9.7 builds properly with c++17 and is the only version referenced in other recipes, I just disabled building 0.9.6 with c++17 rather than trying to hack something to build with c++14 (which would also require to check that the API does not use removed features).

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 8 (2e598a0485ff2cabb5ef775f95ab59b83fe7dcb1):

  • podofo/0.9.7:
    All packages built successfully! (All logs)

  • podofo/0.9.6:
    All packages built successfully! (All logs)


Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 8 (2e598a0485ff2cabb5ef775f95ab59b83fe7dcb1):

  • podofo/0.9.7:
    All packages built successfully! (All logs)

  • podofo/0.9.6:
    All packages built successfully! (All logs)

Copy link
Member

@AbrilRBS AbrilRBS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the patience, this finally is good to go :)

if self.options.with_unistring:
self.requires("libunistring/0.9.10")

def validate(self):
if self.info.settings.compiler.get_safe("cppstd") and Version(self.version) >= "0.9.7":
check_min_cppstd(self, 11)
if conan_version.major >= 2 and Version(self.version) < "0.9.7":
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can remove the old version in a follow-up PR at some point :)

@conan-center-bot conan-center-bot merged commit 64bf3d5 into conan-io:master Aug 19, 2024
16 checks passed
@mayeut mayeut deleted the podofo-bump branch August 19, 2024 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants