brunsli: allow shared brotli dependency

[valgur]

No description provided.

[conan-center-bot]

Conan v1 pipeline ✔️

All green in build 2 (8d98bbb454e32870a074b7828fa199de0a2c2c4d):

• brunsli/cci.20231024:
  All packages built successfully! (All logs)

• brunsli/0.1:
  All packages built successfully! (All logs)

---

Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 2 (8d98bbb454e32870a074b7828fa199de0a2c2c4d):

• brunsli/cci.20231024:
  All packages built successfully! (All logs)

• brunsli/0.1:
  All packages built successfully! (All logs)

[AbrilRBS]

What was the reasoning behind disabling shared builds in the first place? has anything changed in the meantime? Upstream I do see references to brotli being used in static variants, so I'm a bit confused, would appreciate extra insight, thanks! :)

[valgur]

The project itself hard-codes the builds to be static, but I patched around that in the original PR and forgot to re-enable it in the recipe.

[valgur]

@RubenRBS Ping.

[AbrilRBS]

My main fear with this is that we could become maintainers of "using shared brotli" if upstream does not really wants to support that - I'm initially in favour, but let me quickly double check with the team, sorry for the delay!

[jcar87]

Seems like the upstream project allows shared since version 1.1.0: google/brotli@641bec0
(unsure how that correlates with the conan center index).

in general please add context to the PR description when removing these checks - they are (usually) there for a very valid reason, and without additional context we don't have information to determine whether we risk bringing back old problems or not.

Edit: apologies, was looking at wrong recipe.

@AbrilRBS - let's please open an issue with the brunsli maintainers before moving forward - they may not be aware, or may have a very good reason to not allow it.