-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cantera: Add new recipe #21324
base: master
Are you sure you want to change the base?
cantera: Add new recipe #21324
Conversation
This comment has been minimized.
This comment has been minimized.
a1438f5
to
d6a5456
Compare
This comment has been minimized.
This comment has been minimized.
d6a5456
to
47fa734
Compare
This comment has been minimized.
This comment has been minimized.
47fa734
to
ee91f65
Compare
This comment has been minimized.
This comment has been minimized.
ee91f65
to
ca3b0d1
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
cd586d1
to
7656e91
Compare
This comment has been minimized.
This comment has been minimized.
7656e91
to
e3c13fc
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your first contribution!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The entire test_v1_package
can be avoided for new recipes: #19104
Please, remove this folder.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah thanks, I was struggling how to run the reciep for test_v1_package
, so that is pretty nice. :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, do not include custom cmake files in case the upstream does not provide one. Instead, use CMakeDeps
. Please, remove this file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, that is a relict form my first implementation. I just didn't removed it so far. I will do that as soon as possible.
recipes/cantera/all/conanfile.py
Outdated
self.scons_sundials_include = self.dependencies["sundials"].cpp_info.includedirs[0] | ||
self.scons_sundials_libdir = self.dependencies["sundials"].cpp_info.libdirs[0] | ||
|
||
self.scons_boost_inc_dir = self.dependencies["boost"].cpp_info.includedirs[0] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't locally, but have you tried SConsDeps? https://docs.conan.io/2/reference/tools/scons.html
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did, but I have to admit, that I do not know SCons well and therefore do not know, how to ue the SConscript_conandeps
file generated by SConsDeps
. I think In order to use it, I have to modify the SConstruct
file but I do not want to modify the original file.
recipes/cantera/all/conanfile.py
Outdated
self.scons_boost_inc_dir = self.dependencies["boost"].cpp_info.includedirs[0] | ||
|
||
def layout(self): | ||
self.folders.source = "." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it not possible to use basic_layout
? https://docs.conan.io/2/reference/tools/layout.html
Please, use basic_layout, so we can predict the folders layout.
This comment has been minimized.
This comment has been minimized.
I think the current problem with MSVC is the last one. It looks like there is a problem while linking cantera. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Hooks produced the following warnings for commit 70fdeafcantera/3.0.0@#e3869ef48ea863e3def825d57bd76895
|
This comment has been minimized.
This comment has been minimized.
18a5007
to
209a837
Compare
This comment has been minimized.
This comment has been minimized.
ce96854
to
4416af5
Compare
This comment has been minimized.
This comment has been minimized.
4416af5
to
b9d3672
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Conan v1 pipeline ❌Failure in build 11 (
Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability. Conan v2 pipeline ❌
The v2 pipeline failed. Please, review the errors and note this is required for pull requests to be merged. In case this recipe is still not ported to Conan 2.x, please, ping Failure in build 11 (
Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability. |
Hooks produced the following warnings for commit 4f748d4cantera/3.0.0@#530766ea609dd4c9ee11b257336f0599
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Specify library name and version: cantera/3.0.0
Recently, I created a conan package of cantera and pushed it to a local conan repository of my company.
I thought it might be usefull for other people if cantera is accessible via conancenter.
Because of that, I contacted the authors of cantera and asked them if it would be ok if I publish cantera at conancenter.
They are fine with that and now I want to add cantera to conancenter.