Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mpfr: cleanup patches #21339

Merged
merged 1 commit into from
Nov 27, 2023
Merged

Conversation

ericLemanissier
Copy link
Contributor

they were introduced in #14687 but never applied

also, use more compact archives

identified by #21146
and https://ericlemanissier.github.io/conan-center-lint-conandata/

Specify library name and version: lib/1.0


they were introduced in conan-io#14687 but never applied

also, use more compact archives

identified by conan-io#21146
and https://ericlemanissier.github.io/conan-center-lint-conandata/
@ericLemanissier
Copy link
Contributor Author

The build is now finished. You can take a look at the results here

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 1 (ae150ff9e94dc8f0cf08fc42d82f9e443cb971aa):

  • mpfr/4.2.1:
    All packages built successfully! (All logs)

  • mpfr/4.1.0:
    All packages built successfully! (All logs)

  • mpfr/4.2.0:
    All packages built successfully! (All logs)

  • mpfr/4.0.2:
    All packages built successfully! (All logs)


Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 1 (ae150ff9e94dc8f0cf08fc42d82f9e443cb971aa):

  • mpfr/4.2.1:
    All packages built successfully! (All logs)

  • mpfr/4.2.0:
    All packages built successfully! (All logs)

  • mpfr/4.1.0:
    All packages built successfully! (All logs)

  • mpfr/4.0.2:
    All packages built successfully! (All logs)

@AbrilRBS AbrilRBS self-assigned this Nov 24, 2023
@ericLemanissier
Copy link
Contributor Author

for the record:
a 33.0% (718kB) smaller archive exists at https://ftp.gnu.org/gnu/mpfr/mpfr-4.2.1.tar.xz
a 33.0% (710kB) smaller archive exists at https://ftp.gnu.org/gnu/mpfr/mpfr-4.2.0.tar.xz
a 35.3% (812kB) smaller archive exists at https://ftp.gnu.org/gnu/mpfr/mpfr-4.1.0.tar.xz
a 34.8% (752kB) smaller archive exists at https://ftp.gnu.org/gnu/mpfr/mpfr-4.0.2.tar.xz

@uilianries
Copy link
Member

I like to use .xz due its reduced size, but it requires xz-utils installed as well, so it's one more dependency. For Python >=3.3 it should not be a problem because lzma is already supported (Conan 2.x requires Python 3.5) https://docs.python.org/3/library/tarfile.html

I'm totally fine with this change, I just would not want to see PR only changing it, tar.gz is fine as well, are only few MBs more in total.

Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@conan-center-bot conan-center-bot merged commit a45917a into conan-io:master Nov 27, 2023
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants